From: Markus Elfring Date: Thu, 28 May 2020 11:00:03 +0000 Subject: Re: [v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() Message-Id: <5e25fc22-fb61-46f8-a8ec-232bceee40b7@web.de> List-Id: References: <20200527075715.36849-1-qiang.zhang@windriver.com> <284c7851-4e89-a00f-a2e6-aa8e2e1f3fce@web.de> <20200528095703.GH30374@kadam> <20200528103809.GK83516@mtj.thefacebook.com> In-Reply-To: <20200528103809.GK83516@mtj.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo , Dan Carpenter , Zhang Qiang , Lai Jiangshan Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org >> Guys, the patch is wrong. The kfree is harmless when this is called >> from destroy_workqueue() and required when it's called from >> pwq_unbound_release_workfn(). Lai Jiangshan already explained this >> already. Why are we still discussing this? > > Oops, missed that. Reverting. Can it matter to use separate callback functions for these cases? https://elixir.bootlin.com/linux/v5.7-rc7/C/ident/rcu_free_pwq Regards, Markus