From: Michael Walle Subject: Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller Date: Tue, 28 Apr 2020 16:43:24 +0200 Message-ID: <5e2d486077f9e2ce8bd9b171cf806fd9@walle.cc> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-6-michael@walle.cc> <20200428125049.GU185537@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from ssl.serverraum.org ([176.9.125.105]:41983 "EHLO ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbgD1On1 (ORCPT ); Tue, 28 Apr 2020 10:43:27 -0400 In-Reply-To: <20200428125049.GU185537@smile.fi.intel.com> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Am 2020-04-28 14:50, schrieb Andy Shevchenko: > On Thu, Apr 23, 2020 at 07:45:32PM +0200, Michael Walle wrote: >> This patch adds core support for the board management controller found >> on the SMARC-sAL28 board. It consists of the following functions: >> - watchdog >> - GPIO controller >> - PWM controller >> - fan sensor >> - interrupt controller > > ... > >> obj-$(CONFIG_MFD_STMFX) += stmfx.o >> >> obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o >> + >> +obj-$(CONFIG_MFD_SL28CPLD) += sl28cpld.o > > Perhaps keep an order? I don't see any order in that makefile. Looked to me like every new file was added at the end. > > ... > >> + return devm_mfd_add_devices(dev, -1, sl28cpld_devs, > > -1 has its own definition. ok, I'll replace that by PLATFORM_DEVID_NONE. Thanks, -michael > >> + ARRAY_SIZE(sl28cpld_devs), NULL, >> + i2c->irq, NULL); >> +}