Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B2BFC10F27 for ; Wed, 11 Mar 2020 09:28:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45F382192A for ; Wed, 11 Mar 2020 09:28:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MF6IUq1u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45F382192A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0UnOx5/2q5CwM5guEe41Bl2zSn+H2cVueNTngON6tpk=; b=MF6IUq1u0aGz6QcaGOGsD10NA QJ/0K+CDQayKY8sx/W2muuhDnAqeuJRAsHpWcfbBoX7e4eTnMXV2TQ3rCS4WM4RzsFO/jSanE6yub V4I6gHUr+gjyNI6T9sHWpPVJ5WibuhThaEejAlr78e6QS1TiaxT+suLTAkKfKU6E3XWgfpXYINh3p hL23OVUVTgrzMTHkyrRLQFOjKWOFN3C2cqNWkE4uFRRs3o4+YwJdX3XWudvvXT2Ok15nUoVgl2dTL n5pqzgymoC8zbmbrFjElejUFTTwHh2XVhYsD6hEwv15d19dCXpS0LI58Jo/fwIwnZq1zNgAXV8ssD M9yjTxiaQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBxfH-00007I-4a; Wed, 11 Mar 2020 09:28:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBxf4-0008R4-Fi for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 09:28:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6A7231B; Wed, 11 Mar 2020 02:28:21 -0700 (PDT) Received: from [10.163.1.234] (unknown [10.163.1.234]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E49DC3F67D; Wed, 11 Mar 2020 02:28:17 -0700 (PDT) Subject: Re: [PATCH v6 06/18] arm64: ptrauth: Add bootup/runtime flags for __cpu_setup To: Vincenzo Frascino , linux-arm-kernel@lists.infradead.org References: <1583476525-13505-1-git-send-email-amit.kachhap@arm.com> <1583476525-13505-7-git-send-email-amit.kachhap@arm.com> From: Amit Kachhap Message-ID: <5e339fd0-8434-10bb-e6a0-417bc1c0dc09@arm.com> Date: Wed, 11 Mar 2020 14:58:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_022822_607321_3290423C X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Suzuki K Poulose , Catalin Marinas , Kristina Martsenko , Dave Martin , Mark Brown , James Morse , Ramana Radhakrishnan , Will Deacon , Ard Biesheuvel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 3/10/20 5:44 PM, Vincenzo Frascino wrote: > Hi Amit, > > On 3/6/20 6:35 AM, Amit Daniel Kachhap wrote: >> This patch allows __cpu_setup to be invoked with one of these flags, >> ARM64_CPU_BOOT_PRIMARY, ARM64_CPU_BOOT_SECONDARY or ARM64_CPU_RUNTIME. >> This is required as some cpufeatures need different handling during >> different scenarios. >> > > I could not find any explanation in this patch on what these flags stand for. > Could you please add it? Maybe near where you define them. I will add in my V7 version. > > With this: > > Reviewed-by: Vincenzo Frascino Thanks. > >> The input parameter in x0 is preserved till the end to be used inside >> this function. >> >> There should be no functional change with this patch and is useful >> for the subsequent ptrauth patch which utilizes it. Some upcoming >> arm cpufeatures can also utilize these flags. >> >> Suggested-by: James Morse >> Reviewed-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel