From: "cron2 (Code Review)"
Date: Wed, 26 Jun 2024 12:29:20 +0000
In-Reply-To:
References:
Reply-To: gert@...1296..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <5e47ba70cd91ae5e0b1003e35aa328d67ace228d-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="gKenYOu5wb8="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: configure: Try to
detect LZO with pkg-config
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: flichtenheld
Cc: plaisthos , openvpn-devel
--gKenYOu5wb8=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/556?usp=3Demail )
Change subject: configure: Try to detect LZO with pkg-config
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
Patchset:
PS6:
> close... [=E2=80=A6]
I think the pc is broken... everything LZO itself includes uses ... but it's the same (`Cflags: -I${includedir}/lzo`) on gentoo... wher=
e it just happens to work because `/usr/include` is in the include path any=
way. Gah.
Patchset:
PS7:
Tested on FreeBSD 14, "configure with no option" -> succeeds & builds fine =
(LZO in /usr/local/..., make using `-I/usr/local/include/lzo -I/usr/local/i=
nclude` because that's where cmocka and lz4 are living). Disabling LZ4 mak=
es compilation succeed with only `-I/usr/local/include/lzo`. This is good =
:-)
All the buildbots still succeed, which means this hasn't broken explicitly =
setting "whatever we used before".
oi2024 has lzo in `/usr/include/`, so, boring case.
obsd75 has lzo in `/usr/local/include/lzo`, patched configure works, compil=
e works. With `--disable-lz4` there is no mention of `-I/usr/local/include=
` anymore, and it still succeeds ;-)
nbsd81 has `/usr/pkg/include/lzo/` and the patched configure finds it fine,=
and then barfs on
```
configure:18379: checking for lzo1x.h
configure:18379: gcc -c -g -O2 -std=3Dc99 -I/usr/pkg/include/lzo conftest.=
c >&5
In file included from conftest.c:136:0:
/usr/pkg/include/lzo/lzodefs.h:1035:6: error: #error "unexpected configurat=
ion -
check your compiler defines"
# error "unexpected configuration - check your compiler defines"
^
```
which is something weird about UINT_MAX testing against LZO_0xffffffffL. N=
ot sure how to fix that. It does not break on the buildbot as that one has=
a symlink from `/usr/include/lzo -> /usr/pkg/include/lzo` (to apease older=
source trees) - with that, the configure change works fine. Without, it b=
ombs. I would still tend to progress the patch, unless someone has a good =
idea how to tackle this...
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee61fee74f26e693
Gerrit-Change-Number: 556
Gerrit-PatchSet: 7
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: cron2
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 26 Jun 2024 12:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--gKenYOu5wb8=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
Patch set 7:Code-Review +2=
Vi=
ew Change
2 comments:
I think the pc is broken... everything LZO itself includes uses <lz=
o/lzoconf.h>... but it's the same (`Cflags: -I${includedir}/lzo`) on=
gentoo... where it just happens to work because `/usr/include` is in the i=
nclude path anyway. Gah.
Patchset:
Patch Set #=
7:
Teste=
d on FreeBSD 14, "configure with no option" -> succeeds & =
builds fine (LZO in /usr/local/..., make using `-I/usr/local/include/lzo -I=
/usr/local/include` because that's where cmocka and lz4 are living). D=
isabling LZ4 makes compilation succeed with only `-I/usr/local/include/lzo`=
. This is good :-)
All the buildbots still succeed, which means this hasn't broken =
explicitly setting "whatever we used before".
oi2024 has lzo in `/usr/include/=
`, so, boring case.
obsd75 has lzo in `/usr/local/include/lzo`, patched configure works,=
compile works. With `--disable-lz4` there is no mention of `-I/usr/local/=
include` anymore, and it still succeeds ;-)
nbsd81 has `/usr/pkg/include/lzo/` and the p=
atched configure finds it fine, and then barfs on
```
configure:18379: c=
hecking for lzo1x.h
configure:18379: gcc -c -g -O2 -std=3Dc99 -I/usr/pkg=
/include/lzo conftest.c >&5
In file included from conftest.c:136=
:0:
/usr/pkg/include/lzo/lzodefs.h:1035:6: error: #error "unexpecte=
d configuration -
check your compiler defines"
# error &quo=
t;unexpected configuration - check your compiler defines"
^```
which=
is something weird about UINT_MAX testing against LZO_0xffffffffL. Not su=
re how to fix that. It does not break on the buildbot as that one has a sy=
mlink from `/usr/include/lzo -> /usr/pkg/include/lzo` (to apease older s=
ource trees) - with that, the configure change works fine. Without, it bom=
bs. I would still tend to progress the patch, unless someone has a good id=
ea how to tackle this...
To view, visit change 556. =
To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee6=
1fee74f26e693
Gerrit-Change-Number: 556
Gerrit-PatchSet: 7
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Wed, 26 Jun 2024 12:29:20=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Gerrit-MessageType: comment
--gKenYOu5wb8=--