Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18DC1C77B7C for ; Wed, 2 Jul 2025 13:38:03 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1031158.1404891 (Exim 4.92) (envelope-from ) id 1uWxen-00079i-Bt; Wed, 02 Jul 2025 13:37:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1031158.1404891; Wed, 02 Jul 2025 13:37:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uWxen-00079b-91; Wed, 02 Jul 2025 13:37:49 +0000 Received: by outflank-mailman (input) for mailman id 1031158; Wed, 02 Jul 2025 13:37:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uWxem-00079V-LL for xen-devel@lists.xenproject.org; Wed, 02 Jul 2025 13:37:48 +0000 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [2a00:1450:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b84a7bdb-5749-11f0-b894-0df219b8e170; Wed, 02 Jul 2025 15:37:38 +0200 (CEST) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3a365a6804eso3693309f8f.3 for ; Wed, 02 Jul 2025 06:37:38 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74af57ef4dbsm14719122b3a.160.2025.07.02.06.37.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 06:37:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b84a7bdb-5749-11f0-b894-0df219b8e170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1751463458; x=1752068258; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=nFNNKWRcQuzR+IT5J/+O2THj5e4vszSpALK6pyX76Bk=; b=Vet76eXcNTeSgsUVdzEoE/Q15d1eCYqUebJrTSwmhrSdv7kl6JNSMDdgZRb4yTnh/q DW8w12yVqdFWUsMaNOQqnSjV3Xj8X+jwXjfKrKpZeFcBkRk4bgQFA7UQkHbiiFLRuqUl gf431QhIBOu7ko5MlRzbePTALuTvLsD9mvvdTPEiiziQBOqJ2kwhkmN6M3lCrcFXKbUq k2OxsHRJfOKcn9wkYKdlAP36O+MS7dafgpzIHQUnokGrXGj5eKt5h2aedBQsiSjCoA26 37FCQ8QE05EL43ll1AEVI01Z7kaQ21Xc/3CuSteneIv6xvDY+sPpnFkPsEKRg78ylwo+ hxyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751463458; x=1752068258; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nFNNKWRcQuzR+IT5J/+O2THj5e4vszSpALK6pyX76Bk=; b=m9uKDdfC9RGEzH6jNw0chG4seAmo0Kz3yYjaXLlUF4W5nNcRDGorgA//JxcR3Vvrd/ Vr2L/JmBvsHwrvrpUSGNE9FK1IALbGYPvfdvcmgIMe1KIIetKWVmfK5EQbzEVL5NSYn/ DWK/Z/ZMRhJn9ijsx7OtMzwLGvCeWE8soD89I0YD8OCz7N9MIDZOKLFcEnsZRmhJ2IqT v6CjL2ycOAuTGUfEgrk2B8+ivj5rodL14hPdkp7fzwJkf1esLPhpf2lawndOoLwb5C66 mSscaoHZgvmyvJnBq5cqUxymlU2Um+ukrCLgZm/z8FhUf5Ir3PATEHoWz9tpeLTXbXxX +qew== X-Forwarded-Encrypted: i=1; AJvYcCVB8PVyXhzjV3VEOwzFMcuf9x7mmEOVj0vzZA7rd7Cxm1sts/MS9WTsiARhEDHpP/kGdtmiTrtQkgg=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzf6AOqrLG5kR0s7FUd4lLEiZK8vsEROjyGHCTakgyzuOLfg6j4 gssE9cJQ5n4JWhpkAsCOVNTwZKQ/SELLU28qDQGUcuGr8dv2xfgClJaZjr+1++xAsQ== X-Gm-Gg: ASbGncs8fvboG2nTgE0o4HGwdUuC+JrWaN9EC4+oluN9v3TifqNlroJ2qEs5VE1dkyJ j0kSLfHuoVrFUgeHeAsNXHvHjKN6yVWco2dmPtEwFGUeUjzGNHrLWK5xMDL+91LeLgTescT2l9v ah0KWuqFjs5s94RfwwCvWzAW7ZNdILru9Ai9Yf9Iez7baqpm1+EkqeCDqVc/mphPesk+DPspImd ih1eoXHIRZ1VxrQDurpjc9f3Z2TLRcjGJ84A+AIx3pKqeRDakhYPTFvzCxgawogQ6WUEyHhRFMy DBmNVt9ocEAh4BsPyn6+/ltvlUuRC/MDRTFRW6l+u41RM4OuTcUyi0Sl4zkbUy0Z3NYfwAI0+FM ttxUmTi02P7AvueoinCwRgtMq3pAcNFDMZZWNatACS3jye5Q= X-Google-Smtp-Source: AGHT+IHiONL6+uDakrTB4/LYyo5IW1pZDjrzYLrzE46kKexzRYJBio/dmaJTWhwYIZ21mbe6iLJDRA== X-Received: by 2002:a05:6000:1ace:b0:3a6:c923:bc5f with SMTP id ffacd0b85a97d-3b1fdd16da2mr2285155f8f.17.1751463457951; Wed, 02 Jul 2025 06:37:37 -0700 (PDT) Message-ID: <5e52900c-97fb-4895-bde5-33ccfb132986@suse.com> Date: Wed, 2 Jul 2025 15:37:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Arm: tidy page_get_owner_and_nr_reference() To: Julien Grall Cc: Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Michal Orzel , Oleksii Kurochko , "xen-devel@lists.xenproject.org" References: <0d330757-ed73-42bc-8634-e8d445f69c4c@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02.07.2025 15:18, Julien Grall wrote: > On 02/07/2025 14:06, Jan Beulich wrote: >> When the bumping by (instead of just 1) was introduced, a comment >> was left untouched, and a bogus ASSERT_UNREACHABLE() was inserted. That >> code path can in principle be taken (depending on configuration coming >> from the outside), and we shouldn't assert anything we didn't check >> elsewhere. > > I suggested to add the ASSERT_UNREACHABLE (see [1]). My take is the > overflow is not something that should happen and it is good to be able > to catch very clearly in debug build. But catching an anomalous entry in DT (which aiui the values come from, even if perhaps indirectly) isn't going to depend on people using debug builds. It depends on what DT blobs they use. And issues there shouldn't be checked by assertions, as those blobs live outside of Xen. > So I am reluctant to remove it at the moment. But then some checking needs to be added elsewhere. Jan