From: Marek Vasut Date: Wed, 16 Sep 2020 16:08:19 +0200 Subject: [PATCH 4/4] arm: rmobile: Add HopeRun HiHope RZ/G2M board support In-Reply-To: <20200915143630.7678-5-biju.das.jz@bp.renesas.com> References: <20200915143630.7678-1-biju.das.jz@bp.renesas.com> <20200915143630.7678-5-biju.das.jz@bp.renesas.com> Message-ID: <5e847c9e-0508-23ea-23f3-061c2d44e21d@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 9/15/20 4:36 PM, Biju Das wrote: [...] > diff --git a/arch/arm/mach-rmobile/Kconfig.64 b/arch/arm/mach-rmobile/Kconfig.64 > index 07f607dd9d..2290be725f 100644 > --- a/arch/arm/mach-rmobile/Kconfig.64 > +++ b/arch/arm/mach-rmobile/Kconfig.64 > @@ -4,6 +4,8 @@ menu "Select Target SoC" > > config R8A774A1 > bool "Renesas SoC R8A774A1" > + imply CLK_R8A774A1 > + imply PINCTRL_PFC_R8A774A1 Can you please fix the indent with the "bool" too ? It seems there is some inconsistency. [...] > +++ b/board/hoperun/hihope-rzg2/hihope-rzg2.c [...] > + dm_gpio_set_dir_flags(&rev_bit1, GPIOD_IS_IN); > + dm_gpio_set_dir_flags(&rev_bit0, GPIOD_IS_IN); > + revision = 0x03 + ((dm_gpio_get_value(&rev_bit1) << 1) | > + dm_gpio_get_value(&rev_bit0)); I think dm_gpio_get_value can return error too, so applying bit ops might fail. > + return revision; > +} [...] > +void clear_wlan_bt_reg_on(void) > +{ > + struct gpio_desc bt_power, wifi_power; > + char *bt_power_gpio = "gpio at e605300013"; /* GP3_13 */ > + char *wifi_power_gpio = "gpio at e60540006"; /* GP4_06 */ Can you use DT gpio-hog to set the GPIOs instead ? [...] > +/* Kconfig forces this on, so just return 0 */ > +int board_early_init_f(void) > +{ Likely should be fixed on Kconfig side. > + return 0; > +} > + > +int board_init(void) > +{ > + /* address of boot parameters */ > + gd->bd->bi_boot_params = CONFIG_SYS_TEXT_BASE + 0x50000; > + > + /* USB1 pull-up */ > + setbits_le32(PFC_PUEN6, PUEN_USB1_OVC | PUEN_USB1_PWEN); Is this USB stuff really needed on this board ? [...] > +int dram_init(void) > +{ > + return fdtdec_setup_mem_size_base(); > +} Isn't this already in rcar-common.c ? > +int dram_init_banksize(void) > +{ > + return fdtdec_setup_memory_banksize(); > +} > + > +void reset_cpu(ulong addr) > +{ > + writel(RST_CODE, RST_CA57RESCNT); > +} [...] I'll apply the PFC patches to sh/next , so feel free to resend only a subset of the patches based on sh/next .