From: "cron2 (Code Review)" Date: Fri, 23 May 2025 06:14:05 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <5f08d08d5013665d56a0f580198773e6bd1169a8-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="r/CMiOE2TbA="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: dns: deal with --dhcp-options when --dns is active List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: stipa , flichtenheld , plaisthos , openvpn-devel --r/CMiOE2TbA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/904?usp=3Demail ) Change subject: dns: deal with --dhcp-options when --dns is active ...................................................................... Patch Set 21: (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/904/comment/aaf0a34c_938d33d0 : PS15, Line 4299: tuntap_options_postprocess_dns(o); > The reason why is that both had DNS before and they were using the DNS re= lated elements in `struct t [=E2=80=A6] I have thought about this a while now, and would suggest to do the following - *if and only if* we are using the tap driver with ip-win32 dhcp, keep DNS= things "as they are in 2.6" -> fill in DHCP options, do not set DNS via is= ervice - if DCO is used or a non-DHCP mode -> use iservice this will effectively make us use iservice most of the time, but if someone= really wants old behaviour and relies on DHCP, they can have that (... and= , alas, we see users that use a) tap, b) dhcp, and c) no iservice... - whic= h is strongly not recommended, but...) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a Gerrit-Change-Number: 904 Gerrit-PatchSet: 21 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: d12fk Gerrit-Attention: stipa Gerrit-Comment-Date: Fri, 23 May 2025 06:14:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: d12fk Comment-In-Reply-To: stipa Gerrit-MessageType: comment --r/CMiOE2TbA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, flichtenheld, plaisthos, s= tipa.

View C= hange

1 comment: