From: "d12fk (Code Review)"
Date: Thu, 26 Jun 2025 12:28:34 +0000
In-Reply-To:
References:
Reply-To: heiko@...515..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277...
Message-ID: <5f1e6a82dfd9b0be64bd983befc91cbaac1b4e08-EmailReplacePatchSet-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="RvpDRT3Dmdw="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: dns: create NRPT
registry key if it doesn't exist
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos , flichtenheld , stipa
Cc: openvpn-devel
--RvpDRT3Dmdw=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: d12fk, flichtenheld, plaisthos.
Hello flichtenheld, plaisthos, stipa,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1069?usp=3Demail
to look at the new patch set (#3).
Change subject: dns: create NRPT registry key if it doesn't exist
......................................................................
dns: create NRPT registry key if it doesn't exist
Windows 2019 Server by default does not have the key where local system
NRPT rules are stored. Tests have determined that NRPT is actually
working when rules are created under the key. So, instead of failing if
the key doesn't exist, we create it, and things will start working.
Github: OpenVPN/openvpn#768
Change-Id: I46132ebaf3bf3b16798b6f2416f7bf7272f5646b
Signed-off-by: Heiko Hund
---
M src/openvpnserv/interactive.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/69/1069/3
diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index 3bd2722..628a96b 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -2662,7 +2662,7 @@
if (err =3D=3D ERROR_FILE_NOT_FOUND)
{
*gpol =3D FALSE;
- err =3D RegOpenKeyExA(HKEY_LOCAL_MACHINE, sys_key, 0, KEY_ALL_ACCE=
SS, &nrpt);
+ err =3D RegCreateKeyExA(HKEY_LOCAL_MACHINE, sys_key, 0, NULL, 0, K=
EY_ALL_ACCESS, NULL, &nrpt, NULL);
if (err)
{
nrpt =3D INVALID_HANDLE_VALUE;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1069?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I46132ebaf3bf3b16798b6f2416f7bf7272f5646b
Gerrit-Change-Number: 1069
Gerrit-PatchSet: 3
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: stipa
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: d12fk
Gerrit-MessageType: newpatchset
--RvpDRT3Dmdw=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: d12fk, flichtenheld, plaisthos. <=
/p>
d12fk uploaded patch set #3 to this change.
View Change=
a>
dns: create NRPT registry key if it doesn't exist
Windows 201=
9 Server by default does not have the key where local system
NRPT rules =
are stored. Tests have determined that NRPT is actually
working when rul=
es are created under the key. So, instead of failing if
the key doesn=
9;t exist, we create it, and things will start working.
Github: Open=
VPN/openvpn#768
Change-Id: I46132ebaf3bf3b16798b6f2416f7bf7272f5646b
=
Signed-off-by: Heiko Hund <heiko@...2662...>
---
M src/openvpns=
erv/interactive.c
1 file changed, 1 insertion(+), 1 deletion(-)
<=
/pre>git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/69/1069/3
=
diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interact=
ive.c
index 3bd2722..628a96b 100644
--- a/s=
rc/openvpnserv/interactive.c
+++ b/src/openvpnserv/interact=
ive.c
@@ -2662,7 +2662,7 @@
if (err =
=3D=3D ERROR_FILE_NOT_FOUND)
{
=
*gpol =3D FALSE;
- =
err =3D RegOpenKeyExA(HKEY_LOCAL_MACHINE, sys_key, 0, KEY_ALL_ACCESS, =
&nrpt);
+ =
err =3D RegCreateKeyExA(HKEY_LOCAL_MACHINE, sys_key, 0, NULL, 0, KEY_ALL_AC=
CESS, NULL, &nrpt, NULL);
if (err)
<=
span> {
nrpt =3D INVALID_HANDLE_VALUE;=
To view, visit change 1069. To unsubscribe=
, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I46132ebaf3bf3b16798b6f2416f=
7bf7272f5646b
Gerrit-Change-Number: 1069
Gerrit-PatchSet: 3
Gerrit-Owner: d12fk <heiko@...515...> =
div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...=
>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: d12fk <heiko@...515...>=
;
Gerrit-MessageType: newpatchset
--RvpDRT3Dmdw=--