From: "flichtenheld (Code Review)" Date: Sat, 4 Apr 2026 17:49:11 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <5f6b8d066e289ea53a338533df5ddebf62ab017b-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="x5CIKzN7/tE="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --x5CIKzN7/tE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1608?usp=3Demail to review the following change. Change subject: openvpnmsica: Fix setting of iTicks in schedule_adapter_del= ete ...................................................................... openvpnmsica: Fix setting of iTicks in schedule_adapter_delete Increase the integer, not the pointer. Found by cppcheck. Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb Signed-off-by: Frank Lichtenheld --- M src/openvpnmsica/openvpnmsica.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/08/1608/1 diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsic= a.c index a145b64..fdb610c 100644 --- a/src/openvpnmsica/openvpnmsica.c +++ b/src/openvpnmsica/openvpnmsica.c @@ -613,7 +613,7 @@ msica_arg_seq_add_tail(seq, szArgument); } - iTicks +=3D MSICA_ADAPTER_TICK_SIZE; + *iTicks +=3D MSICA_ADAPTER_TICK_SIZE; break; /* Adapter names are unique. There should be no other a= dapter with this name. */ } } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1608?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb Gerrit-Change-Number: 1608 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --x5CIKzN7/tE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

openvpnmsica: Fix setting of iTicks in sche=
dule_adapter_delete

Increase the integer, not the pointer.

Fo= und by cppcheck.

Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908b= b
Signed-off-by: Frank Lichtenheld <frank@...2641...>
---
M = src/openvpnmsica/openvpnmsica.c
1 file changed, 1 insertion(+), 1 deleti= on(-)

git pull ssh://gerrit.openvpn.net:29418/op=
envpn refs/changes/08/1608/1
diff --git a/src/openvpnmsica/openvpnm=
sica.c b/src/openvpnmsica/openvpnmsica.c
index a145b64..fdb= 610c 100644
--- a/src/openvpnmsica/openvpnmsica.c+++ b/src/openvpnmsica/openvpnmsica.c
@@ -613,7 +613= ,7 @@
msica_arg_seq_add_tail(seq, szArgume= nt);
}

- iTicks +=3D MSICA_ADAPTER_TICK_= SIZE;
+ *i= Ticks +=3D MSICA_ADAPTER_TICK_SIZE;
break; /* = Adapter names are unique. There should be no other adapter with this name. = */
}
}

To view, visit change 1608. To unsubscribe, or for help writing m= ail filters, visit settings.

<= /div>
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d6501ddfb321f57a76841f29ff= 92c5a412908bb
Gerrit-Change-Number: 1608
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --x5CIKzN7/tE=--