Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D04C56201 for ; Fri, 30 Oct 2020 15:20:24 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DE0820756 for ; Fri, 30 Oct 2020 15:20:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="eDKWL/38" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DE0820756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.15993.39260 (Exim 4.92) (envelope-from ) id 1kYWCH-0006uF-5l; Fri, 30 Oct 2020 15:20:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 15993.39260; Fri, 30 Oct 2020 15:20:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYWCH-0006u8-03; Fri, 30 Oct 2020 15:20:09 +0000 Received: by outflank-mailman (input) for mailman id 15993; Fri, 30 Oct 2020 15:20:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYWCG-0006u3-6y for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 15:20:08 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8586bb31-0833-4606-96aa-ff504cdea0b2; Fri, 30 Oct 2020 15:20:06 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0E372B244; Fri, 30 Oct 2020 15:20:06 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYWCG-0006u3-6y for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 15:20:08 +0000 X-Inumbo-ID: 8586bb31-0833-4606-96aa-ff504cdea0b2 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8586bb31-0833-4606-96aa-ff504cdea0b2; Fri, 30 Oct 2020 15:20:06 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1604071206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XkTMwdHT+Hhj9foVuFHCZGD8dyJ/KCsO+t+XPA2294g=; b=eDKWL/38CisnvUcOLVO0kzf0Fx5q4s/0JCnqfGZVOAY8qQGYzeeb7Vg/OmLP6zAvpXBvWz 51aKDVAY1+H1wpPpOLf6MzyoWLlZloZxVCTy/RSCJyT+Z9FFfuAy4i/DdkxuNjiZJmNVqQ njlrnInOqYUPSh0nWhHVzqKf/lo68w0= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0E372B244; Fri, 30 Oct 2020 15:20:06 +0000 (UTC) Subject: Re: [PATCH 2/2] xen/rwlock: add check_lock() handling to rwlocks From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20201030142500.5464-1-jgross@suse.com> <20201030142500.5464-3-jgross@suse.com> <239c8495-46fb-122a-be69-6aee98a3ea82@suse.com> <4cea5bfd-5a91-1a77-9c49-989fa191f8d6@suse.com> Message-ID: <5f6f94cb-79fa-209a-b48a-b386d2ecb2a1@suse.com> Date: Fri, 30 Oct 2020 16:20:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <4cea5bfd-5a91-1a77-9c49-989fa191f8d6@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 30.10.20 16:13, Jürgen Groß wrote: > On 30.10.20 16:10, Jan Beulich wrote: >> On 30.10.2020 15:25, Juergen Gross wrote: >>> --- a/xen/include/xen/rwlock.h >>> +++ b/xen/include/xen/rwlock.h >>> @@ -65,7 +65,11 @@ static inline int _read_trylock(rwlock_t *lock) >>>            * arch_lock_acquire_barrier(). >>>            */ >>>           if ( likely(_can_read_lock(cnts)) ) >>> +        { >>> +            check_lock(&lock->lock.debug, true); >>>               return 1; >>> +        } >> >> Why not unconditionally earlier in the function? > > Its trylock, so we don't want to call check_lock() without having > got the lock. Hmm, OTOH we do so for spinlocks, too. So maybe its really better to move it up. Juergen