Message-ID: <5fd732f2cffefd65bfcba983ecf5e11fedb5bc2d.camel@codeconstruct.com.au>
Subject: Re: [PATCH v2 0/3] ARM: dts: aspeed: Add Balcones system
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Rob Herring <robh@kernel.org>, Eddie James <eajames@linux.ibm.com>
Cc: krzk+dt@kernel.org, devicetree@vger.kernel.org, 
	linux-aspeed@lists.ozlabs.org, conor+dt@kernel.org
Date: Tue, 18 Mar 2025 11:31:29 +1030
In-Reply-To: <CAL_Jsq+QF6m1YD_MKi0mxJWtn0n+f+iL2x-jYv3NWytv0X4Jjg@mail.gmail.com>
References: <20250220205948.1777200-1-eajames@linux.ibm.com>
	 <174015998324.3469672.1009055817022487781.robh@kernel.org>
	 <52f6f6fc93144b6bd93870e9ef054da19d809b05.camel@codeconstruct.com.au>
	 <0801c8fc-97c8-4331-b31a-b60a90d683e5@linux.ibm.com>
	 <CAL_Jsq+QF6m1YD_MKi0mxJWtn0n+f+iL2x-jYv3NWytv0X4Jjg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2025-02-28 at 11:23 -0600, Rob Herring wrote:
> On Fri, Feb 28, 2025 at 10:46=E2=80=AFAM Eddie James <eajames@linux.ibm.c=
om>
> wrote:
> >=20
> >=20
> > On 2/24/25 22:34, Andrew Jeffery wrote:
> > > On Fri, 2025-02-21 at 12:11 -0600, Rob Herring (Arm) wrote:
> > > > On Thu, 20 Feb 2025 14:59:45 -0600, Eddie James wrote:
> > > > > The Balcones system is similar to Bonnell but with a POWER11
> > > > > processor.
> > > > >=20
> > > > > Changes since v1:
> > > > > =C2=A0 - Add all the ucd9000 driver supported compatible strings
> > > > > =C2=A0 - Fix node ordering in Balcones device tree
> > > > > =C2=A0 - Improve commit message to explain addition of ibm-
> > > > > power11-dual.dtsi
> > > > >=20
> > > > > Eddie James (3):
> > > > > =C2=A0=C2=A0 dt-bindings: arm: aspeed: add IBM Balcones board
> > > > > =C2=A0=C2=A0 dt-bindings: hwmon: ucd90320: Add additional compati=
ble
> > > > > strings
> > > > > =C2=A0=C2=A0 ARM: dts: aspeed: Add Balcones system
> > > > >=20
> > > > > =C2=A0 .../bindings/arm/aspeed/aspeed.yaml=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 +
> > > > > =C2=A0 .../bindings/hwmon/pmbus/ti,ucd90320.yaml=C2=A0=C2=A0=C2=
=A0=C2=A0 |=C2=A0=C2=A0 6 +
> > > > > =C2=A0 arch/arm/boot/dts/aspeed/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 +
> > > > > =C2=A0 .../dts/aspeed/aspeed-bmc-ibm-balcones.dts=C2=A0=C2=A0=C2=
=A0 | 594
> > > > > +++++++++++++
> > > > > =C2=A0 .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779
> > > > > ++++++++++++++++++
> > > > > =C2=A0 .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +-----=
-
> > > > > ----------
> > > > > =C2=A0 6 files changed, 1383 insertions(+), 767 deletions(-)
> > > > > =C2=A0 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm=
-
> > > > > balcones.dts
> > > > > =C2=A0 create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-
> > > > > dual.dtsi
> > > > >=20
> > > > > --
> > > > > 2.43.5
> > > > >=20
> > > > >=20
> > > > >=20
> > > >=20
> > > > My bot found new DTB warnings on the .dts files added or
> > > > changed in this
> > > > series.
> > > >=20
> > > ...
> > >=20
> > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb:
> > > > gpio@1e780000: 'usb-power-hog' does not match any of the
> > > > regexes: 'pinctrl-[0-9]+'
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 from schema $id:
> > > > http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#
> > > Ah, can you address this one?
> > >=20
> > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb:
> > > > /ahb/apb/bus@1e78a000/i2c@400/pwm@53: failed to match any
> > > > schema with compatible: ['maxim,max31785a']
> > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb:
> > > > pressure-sensor@76: '#io-channel-cells' does not match any of
> > > > the regexes: 'pinctrl-[0-9]+'
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 from schema $id:
> > > > http://devicetree.org/schemas/trivial-devices.yaml#
> > > And these also?
> > >=20
> > > The rest looked like the usual noise.
> >=20
> >=20
> > Well, all of these errors are also present in Blueridge. I would
> > need to
> > write a new binding for dps310, move max31785 to yaml format, and
> > I'm
> > not sure how to fix the gpio hog one. I don't see that error when I
> > run
> > CHECK_DTBS myself... any suggestions?
>=20
> I think the hog one got fixed recently. The tests run on top of
> whatever b4 picks for the base or linux-next if it can't figure out
> the base. So that might be the difference.

Eddie: Yeah, disregard the hog one. An alternative to
writing/converting the bindings is dropping the relevant nodes for now,
and adding them back once the bindings have been dealt with. Up to you.

Andrew