Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67239C76188 for ; Wed, 5 Apr 2023 14:42:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CFA5D85F9D; Wed, 5 Apr 2023 16:42:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="oMRrBHkS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 18AEF85F94; Wed, 5 Apr 2023 16:42:29 +0200 (CEST) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B1DA280375 for ; Wed, 5 Apr 2023 16:42:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=afd@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 335EgMBR063473; Wed, 5 Apr 2023 09:42:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680705742; bh=1w9KMFrusVS8onELTa2IwY2MlbPzavKoyFjDv69YSoI=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=oMRrBHkSmuYF8BZLNIGTfsHgwhaIH1D0b1t1oFlely9X/3oHngJ+a4Jxp5sz9ZgqV nCZ13dfjOwrwqlc7KLyXsyrlVAZqxzf0QFN5N0cHyTKcyAsF0fUltnxptuLOd55NKz HiHSnfDQrmGF0Ihpb/uDMa/iSCT+0049VFkXuEp4= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 335EgM3g037789 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 5 Apr 2023 09:42:22 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 5 Apr 2023 09:42:22 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 5 Apr 2023 09:42:22 -0500 Received: from [10.250.32.15] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 335EgL7M046622; Wed, 5 Apr 2023 09:42:21 -0500 Message-ID: <5fe69e8a-d559-030f-0b45-030509de8f8a@ti.com> Date: Wed, 5 Apr 2023 09:42:21 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 08/12] arm: mach-k3: Add weak do_board_detect() to common file To: Christian Gmeiner CC: Simon Glass , Tom Rini , References: <20230330202857.8216-1-afd@ti.com> <20230330202857.8216-8-afd@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 4/2/23 5:44 AM, Christian Gmeiner wrote: > Hi Andrew > > Am Do., 30. März 2023 um 22:30 Uhr schrieb Andrew Davis : >> >> This matches how it was done for pre-K3 TI platforms and it allows >> us to move the forward declaration out of sys_proto.h. >> >> It also removes the need to check for TI_I2C_BOARD_DETECT before >> calling this function, which might not be the right guard ifdef >> should a board use a different method for board detection. >> >> Signed-off-by: Andrew Davis > > This change is conflicting with what is u-boot/next: > https://source.denx.de/u-boot/u-boot/-/commit/e44657ed744d1b4e216d8dda5d528ff0d0a6234e > Thanks for the heads up, will rebase on latest and resend. Andrew