From: "flichtenheld (Code Review)"
Date: Wed, 16 Apr 2025 11:51:54 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <5ff18fe194470db615112c2927bec669b6862889-EmailReplacePatchSet-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="ojjgGMCeR8c="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Define a
.clang-format file for the project
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--ojjgGMCeR8c=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/790?usp=3Demail
to look at the new patch set (#11).
Change subject: Define a .clang-format file for the project
......................................................................
Define a .clang-format file for the project
Each of these statements has been reviewed but
not all of them are obvious.
Also add a pre-commit config to easily check the
formatting.
Change-Id: I40f6af10c5ee2f5aed4185d783fc622a2e3c19ff
Signed-off-by: Frank Lichtenheld
---
A .clang-format
A .pre-commit-config.yaml
2 files changed, 55 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/790/11
diff --git a/.clang-format b/.clang-format
new file mode 100644
index 0000000..77a7d6d
--- /dev/null
+++ b/.clang-format
@@ -0,0 +1,47 @@
+---
+BasedOnStyle: Mozilla
+AccessModifierOffset: '-4'
+AlignAfterOpenBracket: Align
+AlignConsecutiveMacros:
+ Enabled: true
+ AcrossEmptyLines: false
+ AcrossComments: true
+AlignEscapedNewlines: Left
+AlignOperands: true
+AlignTrailingComments:
+ Kind: Always
+ OverEmptyLines: 1
+AllowAllParametersOfDeclarationOnNextLine: true
+AllowShortBlocksOnASingleLine: Never
+AllowShortCaseLabelsOnASingleLine: false
+AllowShortFunctionsOnASingleLine: None
+AllowShortIfStatementsOnASingleLine: Never
+AllowShortLoopsOnASingleLine: false
+AlwaysBreakAfterReturnType: None
+BinPackArguments: true
+BreakBeforeBinaryOperators: NonAssignment
+BreakBeforeBraces: Allman
+BreakBeforeTernaryOperators: true
+BreakStringLiterals: false
+ColumnLimit: '100'
+ContinuationIndentWidth: '4'
+DerivePointerAlignment: false
+IndentCaseLabels: true
+IndentGotoLabels: false
+IndentWidth: '4'
+IndentWrappedFunctionNames: false
+KeepEmptyLinesAtTheStartOfBlocks: false
+Language: Cpp
+MaxEmptyLinesToKeep: '2'
+PointerAlignment: Right
+ReflowComments: true
+SortIncludes: false
+SpaceAfterCStyleCast: false
+SpaceBeforeAssignmentOperators: true
+SpaceBeforeParens: ControlStatements
+SpacesBeforeTrailingComments: '2'
+SpacesInParens: Never
+TabWidth: '4'
+TypeNames: [DWORD]
+UseTab: Never
+WhitespaceSensitiveMacros: [_STRINGIFY]
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
new file mode 100644
index 0000000..0f09a06
--- /dev/null
+++ b/.pre-commit-config.yaml
@@ -0,0 +1,8 @@
+repos:
+ - repo: https://github.com/pre-commit/mirrors-clang-format
+ rev: 'v19.1.4'
+ hooks:
+ - id: clang-format
+ files: \.[ch]$
+ # preserve upstream formatting
+ exclude: ^(src/compat/compat-lz4\.[ch]|src/openvpn/ovpn_dco_(linux=
|win)\.h)$
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/790?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I40f6af10c5ee2f5aed4185d783fc622a2e3c19ff
Gerrit-Change-Number: 790
Gerrit-PatchSet: 11
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-MessageType: newpatchset
--ojjgGMCeR8c=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld uploaded patch set #11 to this change.
=
View C=
hange
Define a .clang-format file for the project
Each of these =
statements has been reviewed but
not all of them are obvious.
Als=
o add a pre-commit config to easily check the
formatting.
Change-=
Id: I40f6af10c5ee2f5aed4185d783fc622a2e3c19ff
Signed-off-by: Frank Licht=
enheld <frank@...2641...>
---
A .clang-format
A .pre-commit-=
config.yaml
2 files changed, 55 insertions(+), 0 deletions(-)
=
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/790/11
diff --git a/.clang-format b/.clang-format
new file mod=
e 100644
index 0000000..77a7d6d
--- /dev/nu=
ll
+++ b/.clang-format
@@ -0,0 +1,47 @@
+---
+BasedOnStyle: Mozilla
+AccessModifierOffset: '-4'
+AlignAfterOpenBracket:=
Align
+AlignConsecut=
iveMacros:
+ Enabled=
: true
+ AcrossEmpty=
Lines: false
+ Acros=
sComments: true
+Alig=
nEscapedNewlines: Left
+AlignOperands: true
+AlignTrailingComments:
+ Kind: Always
=
+ OverEmptyLines: 1
=
+AllowAllParametersOfDeclarationOnNextLine: true
+AllowShortBlocksOnASingleLine: Never
+AllowShortCaseLabelsOnASingle=
Line: false
+AllowSho=
rtFunctionsOnASingleLine: None
+AllowShortIfStatementsOnASingleLine: Never
+AllowShortLoopsOnASingleLine: false
+AlwaysBreakAfterReturnTyp=
e: None
+BinPackArgum=
ents: true
+BreakBefo=
reBinaryOperators: NonAssignment
+BreakBeforeBraces: Allman
+BreakBeforeTernaryOperators: true
+BreakStringLiterals: false
+ColumnLimit: '100'<=
br>+ContinuationIndentWidth: =
39;4'
+DerivePoin=
terAlignment: false
+=
IndentCaseLabels: true
+IndentGotoLabels: false
+IndentWidth: '4'
+IndentWrappedFunctionNames: false
+KeepEmptyLinesAtTheStartOfBlocks: false
+Language: Cpp
+MaxEmptyLinesToKeep: '2'
+PointerAlignment: Righ=
t
+ReflowComments: tr=
ue
+SortIncludes: fal=
se
+SpaceAfterCStyleC=
ast: false
+SpaceBefo=
reAssignmentOperators: true
+SpaceBeforeParens: ControlStatements
+SpacesBeforeTrailingComments: '2'+SpacesInParens: Never=
+TabWidth: '4'
+TypeNames: [DWORD]
+UseTab: Never
<=
span style=3D"color: hsl(120, 100%, 40%);">+WhitespaceSensitiveMacros: [_ST=
RINGIFY]
diff --git a/.pre-commit-config.yaml b/.pre-commit=
-config.yaml
new file mode 100644
index 000=
0000..0f09a06
--- /dev/null
+++ b/.pre-comm=
it-config.yaml
@@ -0,0 +1,8 @@
+repos:
+ - repo: https://github.com/pre-commit/mirrors-clang-format<=
/span>
+ rev: 'v19.1.=
4'
+ hooks:
+ - id: clang-form=
at
+ files: \.=
[ch]$
+ # pres=
erve upstream formatting
+ exclude: ^(src/compat/compat-lz4\.[ch]|src/openvpn/ovpn_dco_(l=
inux|win)\.h)$
To view, visit change 790. =
To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I40f6af10c5ee2f5aed4185d783f=
c622a2e3c19ff
Gerrit-Change-Number: 790
Gerrit-PatchSet: 11
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-MessageType: newpatchset
--ojjgGMCeR8c=--