Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FB91C43217 for ; Tue, 8 Nov 2022 16:19:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AF1D384FD1; Tue, 8 Nov 2022 17:19:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="TzhNaNL7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 550B184FE0; Tue, 8 Nov 2022 17:19:14 +0100 (CET) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B631C84FD1 for ; Tue, 8 Nov 2022 17:19:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=martyn.welch@collabora.com Received: from [IPv6:2a00:23c6:c311:3401:7395:ffd:f557:ca4e] (unknown [IPv6:2a00:23c6:c311:3401:7395:ffd:f557:ca4e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: martyn) by madras.collabora.co.uk (Postfix) with ESMTPSA id E985C6602997; Tue, 8 Nov 2022 16:19:10 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667924351; bh=vrNdll6E2uGMEBotliRBCVMLLtr6QjipFKi4BbeY1P0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=TzhNaNL7EoBE71Fdkezh/Sm1K2X9zPdduiuPSyz9N09xcF3xvsfP/Lbj1BLavBf+C ih/EfxYdWr4ZFqOKm9ybbaMxdxjEDuq+7cQvb8MQ/gOWSGdB1UbS5jM+GyPOonfyH4 me/HujxtmxSJ3E/d1/qStKCcwuhiXp/jeKAcrXiS+JSlaXXkRUNt0inKhOVL1aNYZ6 XdtfVtpIIG6pfhijTE/nZ+EgOlak83wQSxbG+pa7byasK4tVZRjK/HhaozTBYbTyT9 fb23YwtFNSuiXO54IZbMB1LvuJnX5wU8ltjAaEon6lJ5wuHpPYCpVmgREntHjDzV1m e+FpuOwfzf8Pg== Message-ID: <608b546ea7881df60cc94e2e85608ae680650815.camel@collabora.com> Subject: Re: [PATCH] msc_sm2s_imx8mp: Convert to CONFIG_TEXT_BASE From: Martyn Welch To: Stefano Babic , Fabio Estevam Cc: u-boot@lists.denx.de, Fabio Estevam Date: Tue, 08 Nov 2022 16:19:08 +0000 In-Reply-To: References: <20221108144253.3012814-1-festevam@gmail.com> Organization: Collabora Ltd. Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0-2 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 2022-11-08 at 15:50 +0100, Stefano Babic wrote: > Hi Fabio, >=20 > On 08.11.22 15:42, Fabio Estevam wrote: > > From: Fabio Estevam > >=20 > > The conversion to CONFIG_TEXT_BASE was missed here. > >=20 > > Convert it to fix a build error in CI. > >=20 > > Signed-off-by: Fabio Estevam > > --- > > Stefano, > >=20 > > This is against u-boot-imx, master-next branch. > >=20 > > If you prefer to squash with the original commit, feel free to do > > it. > >=20 > > =C2=A0 configs/msc_sm2s_imx8mp_defconfig | 2 +- > > =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/configs/msc_sm2s_imx8mp_defconfig > > b/configs/msc_sm2s_imx8mp_defconfig > > index a4f39061ae62..6691eb312fe5 100644 > > --- a/configs/msc_sm2s_imx8mp_defconfig > > +++ b/configs/msc_sm2s_imx8mp_defconfig > > @@ -1,6 +1,6 @@ > > =C2=A0 CONFIG_ARM=3Dy > > =C2=A0 CONFIG_ARCH_IMX8M=3Dy > > -CONFIG_SYS_TEXT_BASE=3D0x40200000 > > +CONFIG_TEXT_BASE=3D0x40200000 > > =C2=A0 CONFIG_SYS_MALLOC_LEN=3D0x2000000 > > =C2=A0 CONFIG_SPL_GPIO=3Dy > > =C2=A0 CONFIG_SPL_LIBCOMMON_SUPPORT=3Dy >=20 >=20 > Thanks. I will first run a pipeline, but it makes sense that I squash > this with Martyn's v5-5-5-arm-imx8mp-Initial-MSC-SM2S-iMX8MP-support, > by=20 > adding Fabio's Signed-off. @Martyn, is it okay for you ? >=20 That's fine with me! > Regards, > Stefano >=20