Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96450C43461 for ; Thu, 10 Sep 2020 14:27:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4618F2076C for ; Thu, 10 Sep 2020 14:27:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4618F2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kGNXc-00045s-Qa; Thu, 10 Sep 2020 14:27:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kGNXb-00045l-KA for xen-devel@lists.xenproject.org; Thu, 10 Sep 2020 14:27:11 +0000 X-Inumbo-ID: 061d516b-4643-41a0-abdf-9a78b36ac679 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 061d516b-4643-41a0-abdf-9a78b36ac679; Thu, 10 Sep 2020 14:27:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AFC25AD77; Thu, 10 Sep 2020 14:27:25 +0000 (UTC) Subject: Re: [PATCH v5 8/8] iommu: stop calling IOMMU page tables 'p2m tables' To: Paul Durrant Cc: xen-devel@lists.xenproject.org, Paul Durrant , Andrew Cooper , Kevin Tian References: <20200907074023.1392-1-paul@xen.org> <20200907074023.1392-9-paul@xen.org> From: Jan Beulich Message-ID: <611962bf-4cd9-7da8-ea47-e95e5181515b@suse.com> Date: Thu, 10 Sep 2020 16:27:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200907074023.1392-9-paul@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.09.2020 09:40, Paul Durrant wrote: > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c > @@ -491,8 +491,8 @@ static int amd_iommu_group_id(u16 seg, u8 bus, u8 devfn) > > #include > > -static void amd_dump_p2m_table_level(struct page_info* pg, int level, > - paddr_t gpa, int indent) > +static void amd_dump_page_table_level(struct page_info* pg, int level, Could you flip * and space here as you touch the line anyway? > @@ -504,7 +504,7 @@ static void amd_dump_p2m_table_level(struct page_info* pg, int level, > table_vaddr = __map_domain_page(pg); > if ( table_vaddr == NULL ) > { > - printk("Failed to map IOMMU domain page %"PRIpaddr"\n", > + printk("%s: failed to map domain page %"PRIpaddr"\n", __func__, > page_to_maddr(pg)); Why the addition of __func__? Personally I'd rather see most of its uses go away ... (There are two more further down.) Preferably with this dropped again Reviewed-by: Jan Beulich Jan