Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC4A7C432BE for ; Thu, 26 Aug 2021 07:14:54 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ADBC61053 for ; Thu, 26 Aug 2021 07:14:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4ADBC61053 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-54iHnym1NL6h-QDNQMm_NQ-1; Thu, 26 Aug 2021 03:14:51 -0400 X-MC-Unique: 54iHnym1NL6h-QDNQMm_NQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ADC2692500; Thu, 26 Aug 2021 07:14:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B49D60871; Thu, 26 Aug 2021 07:14:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 072424BB7C; Thu, 26 Aug 2021 07:14:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17Q6lKca014321 for ; Thu, 26 Aug 2021 02:47:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id EAB471007BAD; Thu, 26 Aug 2021 06:47:19 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6B9310075E2 for ; Thu, 26 Aug 2021 06:47:17 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 421A4185A7A4 for ; Thu, 26 Aug 2021 06:47:17 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-282-tWksd2yKMZiZ7dv6TvTg1g-1; Thu, 26 Aug 2021 02:47:15 -0400 X-MC-Unique: tWksd2yKMZiZ7dv6TvTg1g-1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A81A020163; Thu, 26 Aug 2021 06:47:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6E0FD12FC5; Thu, 26 Aug 2021 06:47:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KeWRGPE4J2EoUQAAMHmgww (envelope-from ); Thu, 26 Aug 2021 06:47:13 +0000 Message-ID: <6123dd27bfaa10641c45d0477516e068bc7c8ecb.camel@suse.com> From: Martin Wilck To: Xose Vazquez Perez Date: Thu, 26 Aug 2021 08:47:12 +0200 In-Reply-To: <20210825222413.2822-1-xose.vazquez@gmail.com> References: <20210825222413.2822-1-xose.vazquez@gmail.com> User-Agent: Evolution 3.40.3 MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 17Q6lKca014321 X-loop: dm-devel@redhat.com Cc: DM-DEVEL ML Subject: Re: [dm-devel] [PATCH] multipath-tools: update no_path_retry value for IBM/2145 X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable On Thu, 2021-08-26 at 00:24 +0200, Xose Vazquez Perez wrote: > Based on current configs: > https://www.ibm.com/docs/en/flashsystem-9x00/8.4.x?topic=3Dsystem-setting= s-linux-hosts >=20 > Cc: Martin Wilck > Cc: Benjamin Marzinski > Cc: Christophe Varoqui > Cc: DM-DEVEL ML > Signed-off-by: Xose Vazquez Perez > --- > =A0libmultipath/hwtable.c | 2 +- > =A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index 2a896440..58554cbb 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -662,7 +662,7 @@ static struct hwentry default_hw[] =3D { > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0/* Storwize family / SAN = Volume Controller / Flex > System V7000 / FlashSystem V840/V9000/9100 */ > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0.vendor=A0=A0=A0=A0=A0=A0= =A0 =3D "IBM", > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0.product=A0=A0=A0=A0=A0= =A0 =3D "^2145", > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0.no_path_retry =3D NO_PATH_= RETRY_QUEUE, > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0.no_path_retry =3D 5, > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0.pgpolicy=A0=A0=A0=A0=A0 = =3D GROUP_BY_PRIO, > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0.pgfailback=A0=A0=A0 =3D = -FAILBACK_IMMEDIATE, > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0.prio_name=A0=A0=A0=A0 = =3D PRIO_ALUA, Ref: https://github.com/opensvc/multipath-tools/issues/6 The question is on which basis IBM came up with this recommendation. 5 (aka 25s) is a rather low value. Some users may encounter unpleasant surprises if we change the default this way, as it used to be infinite before. Using 5, the IBS 2145 would have the 2nd-lowest default in hwtable.c after Dell PowerStore (3). Symmetrix has 6; all other arrays default to 10 or higher, many default to "queue". Observing that the above is the documentation for the *Flashsystem* 9200, I consider it likely that the value ".no_path_retry =3D 5" would apply to flash-based IBM storage products, but not to the older products such as the V7000, which unfortunately use the same device ID. It'd be helpful if someone from IBM could jump in here... Pondering the pros and cons, I vote for keeping the current defaults for now. Martin -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel