From: Maarten Lankhorst Subject: Re: [PATCH 02/11] drm/i915: Add more wrapper for fixed_point_16_16 operations Date: Wed, 10 May 2017 14:37:16 +0200 Message-ID: <614b1f10-da6e-0525-aa51-0ab258629fe9@linux.intel.com> References: <20170508114902.18965-1-mahesh1.kumar@intel.com> <20170508114902.18965-3-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16170897C8 for ; Wed, 10 May 2017 12:37:31 +0000 (UTC) In-Reply-To: <20170508114902.18965-3-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar , intel-gfx@lists.freedesktop.org Cc: paulo.r.zanoni@intel.com List-Id: intel-gfx@lists.freedesktop.org T3AgMDgtMDUtMTcgb20gMTM6NDggc2NocmVlZiBNYWhlc2ggS3VtYXI6Cj4gVGhpcyBwYXRjaCBh ZGRzIGZldyB3cmFwcGVyIHRvIHBlcmZvcm0gZml4ZWRfcG9pbnRfMTZfMTYgb3BlcmF0aW9ucwo+ IG11bF91MzJfZml4ZWRfMTZfMTZfcm91bmRfdXAgOiBNdWx0aXBsaWVzIHUzMiBhbmQgZml4ZWRf MTZfMTZfdAo+IAkJCQl2YXJpYWJsZXMgJiByZXR1cm5zIHUzMiByZXN1bHQgd2l0aAo+IAkJCQly b3VuZGluZy1vZmYuCj4gbXVsX2ZpeGVkXzE2XzE2IDogTXVsdGlwbGllcyB0d28gZml4ZWRfMTZf MTZfdCB2YXJpYWJsZSAmIHJldHVybnMKPiAJCQkJZml4ZWRfMTZfMTYKPiBkaXZfcm91bmRfdXBf Zml4ZWRfMTZfMTYgOiBQZXJmb3JtIGRpdmlzaW9uIG9wZXJhdGlvbiBvbiBmaXhlZF8xNl8xNl90 Cj4gCQkJCXZhcmlhYmxlcyAmIHJldHVybiB1MzIgcmVzdWx0IHdpdGggcm91bmQtb2ZmCj4gZml4 ZWRfMTZfMTZfZGl2X3JvdW5kX3VwX3U2NCA6IGRldmlkZSB1aW50MzJfdCB2YXJpYWJsZSBieSBm aXhlZF8xNl8xNgo+IAkJCQl2YXJpYWJsZSBhbmQgcm91bmRfdXAgdGhlIHJlc3VsdCB0byB1aW50 MzJfdC4KPgo+IFRoZXNlIHdyYXBwZXJzIHdpbGwgYmUgdXNlZCBieSBsYXRlciBwYXRjaGVzIGlu IHRoZSBzZXJpZXMuCj4KPiBTaWduZWQtb2ZmLWJ5OiBNYWhlc2ggS3VtYXIgPG1haGVzaDEua3Vt YXJAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIHwg NDMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNo YW5nZWQsIDQzIGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4 IDU4MDQ3MzRkMzBhMy4uNWZmMDA5MTcwN2MwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o Cj4gQEAgLTE1Miw2ICsxNTIsMzggQEAgc3RhdGljIGlubGluZSB1aW50X2ZpeGVkXzE2XzE2X3Qg bWF4X2ZpeGVkXzE2XzE2KHVpbnRfZml4ZWRfMTZfMTZfdCBtYXgxLAo+ICAJcmV0dXJuIG1heDsK PiAgfQo+ICAKPiArc3RhdGljIGlubGluZSB1aW50MzJfdCBkaXZfcm91bmRfdXBfZml4ZWRfMTZf MTYodWludF9maXhlZF8xNl8xNl90IHZhbCwKPiArCQkJCQkJdWludF9maXhlZF8xNl8xNl90IGQp Cj4gK3sKPiArCXJldHVybiBESVZfUk9VTkRfVVAodmFsLnZhbCwgZC52YWwpOwo+ICt9Cj4gKwo+ ICtzdGF0aWMgaW5saW5lIHVpbnQzMl90IG11bF91MzJfZml4ZWRfMTZfMTZfcm91bmRfdXAodWlu dDMyX3QgdmFsLAo+ICsJCQkJCQkgICAgdWludF9maXhlZF8xNl8xNl90IG11bCkKPiArewo+ICsg ICAgICAgdWludDY0X3QgaW50ZXJtZWRpYXRlX3ZhbDsKPiArICAgICAgIHVpbnQzMl90IHJlc3Vs dDsKPiArCj4gKyAgICAgICBpbnRlcm1lZGlhdGVfdmFsID0gKHVpbnQ2NF90KSB2YWwgKiBtdWwu dmFsOwo+ICsgICAgICAgaW50ZXJtZWRpYXRlX3ZhbCA9IERJVl9ST1VORF9VUF9VTEwoaW50ZXJt ZWRpYXRlX3ZhbCwgMSA8PCAxNik7Cj4gKyAgICAgICBXQVJOX09OKGludGVybWVkaWF0ZV92YWwg Pj4gMzIpOwo+ICsgICAgICAgcmVzdWx0ID0gY2xhbXBfdCh1aW50MzJfdCwgaW50ZXJtZWRpYXRl X3ZhbCwgMCwgfjApOwo+ICsgICAgICAgcmV0dXJuIHJlc3VsdDsKPiArfQo+ICsKPiArc3RhdGlj IGlubGluZSB1aW50X2ZpeGVkXzE2XzE2X3QgbXVsX2ZpeGVkXzE2XzE2KHVpbnRfZml4ZWRfMTZf MTZfdCB2YWwsCj4gKwkJCQkJCSB1aW50X2ZpeGVkXzE2XzE2X3QgbXVsKQo+ICt7Cj4gKwl1aW50 NjRfdCBpbnRlcm1lZGlhdGVfdmFsOwo+ICsJdWludF9maXhlZF8xNl8xNl90IGZwOwo+ICsKPiAr CWludGVybWVkaWF0ZV92YWwgPSAodWludDY0X3QpIHZhbC52YWwgKiBtdWwudmFsOwo+ICsJaW50 ZXJtZWRpYXRlX3ZhbCA9IGludGVybWVkaWF0ZV92YWwgPj4gMTY7Cj4gKwlXQVJOX09OKGludGVy bWVkaWF0ZV92YWwgPj4gMzIpOwo+ICsJZnAudmFsID0gY2xhbXBfdCh1aW50MzJfdCwgaW50ZXJt ZWRpYXRlX3ZhbCwgMCwgfjApOwo+ICsJcmV0dXJuIGZwOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW5s aW5lIHVpbnRfZml4ZWRfMTZfMTZfdCBmaXhlZF8xNl8xNl9kaXYodWludDMyX3QgdmFsLCB1aW50 MzJfdCBkKQo+ICB7Cj4gIAl1aW50X2ZpeGVkXzE2XzE2X3QgZnAsIHJlczsKPiBAQCAtMTc0LDYg KzIwNiwxNyBAQCBzdGF0aWMgaW5saW5lIHVpbnRfZml4ZWRfMTZfMTZfdCBmaXhlZF8xNl8xNl9k aXZfdTY0KHVpbnQzMl90IHZhbCwgdWludDMyX3QgZCkKPiAgCXJldHVybiByZXM7Cj4gIH0KPiAg Cj4gK3N0YXRpYyBpbmxpbmUgdWludDMyX3QgZml4ZWRfMTZfMTZfZGl2X3JvdW5kX3VwX3U2NCh1 aW50MzJfdCB2YWwsCj4gKwkJCQkJCSAgICB1aW50X2ZpeGVkXzE2XzE2X3QgZCkKPiArewo+ICsJ dWludDY0X3QgaW50ZXJtX3ZhbDsKPiArCj4gKwlpbnRlcm1fdmFsID0gKHVpbnQ2NF90KXZhbCA8 PCAxNjsKPiArCWludGVybV92YWwgPSBESVZfUk9VTkRfVVBfVUxMKGludGVybV92YWwsIGQudmFs KTsKPiArCVdBUk5fT04oaW50ZXJtX3ZhbCA+PiAzMik7Cj4gKwlyZXR1cm4gY2xhbXBfdCh1aW50 MzJfdCwgaW50ZXJtX3ZhbCwgMCwgfjApOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW5saW5lIHVpbnRf Zml4ZWRfMTZfMTZfdCBtdWxfdTMyX2ZpeGVkXzE2XzE2KHVpbnQzMl90IHZhbCwKPiAgCQkJCQkJ ICAgICB1aW50X2ZpeGVkXzE2XzE2X3QgbXVsKQo+ICB7CgpJIHdvdWxkbid0IG1pbmQgaWYgdGhv c2UgbWFjcm9zIHdvdWxkIGJlIG1vdmVkIGxhdGVyIHRvIGRybSBjb3JlLCBJIGRvbid0IHRoaW5r IGk5MTUgaXMgdGhlIG9ubHkgb25lIHRvIGJlbmVmaXQgZnJvbSBmaXhlZCAxNi4xNiBjYWxjdWxh dGlvbnMuIDopCgp+TWFhcnRlbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==