Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05B7FEB64D7 for ; Fri, 16 Jun 2023 15:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF04D8E0002; Fri, 16 Jun 2023 11:28:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9F6A8E0001; Fri, 16 Jun 2023 11:28:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8F478E0002; Fri, 16 Jun 2023 11:28:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA9178E0001 for ; Fri, 16 Jun 2023 11:28:45 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 984FC120C30 for ; Fri, 16 Jun 2023 15:28:45 +0000 (UTC) X-FDA: 80908993410.12.75BDCC1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id B7ED440008 for ; Fri, 16 Jun 2023 15:28:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HnQwEG5n; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686929323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=maoLH1+iFdOHtUfb3uVlDmFpd4ojetev/CDoWNYqeqE=; b=k7NiY4753d5q7T9FtGrhr1+RsBji3vGZfTFZWEzvryANg0T1wA5ibWk6sTqmPRFvnWuxfB tmL797sKdZ9BLRV7dLLYav5EX/LpjIIxLs87hMnWUmwn3nPX1g6NR7X02kEaT8Pm8yy3Xn ifa0QjoyVghjMJ98kaPMNbvAU2D/sGg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686929323; a=rsa-sha256; cv=none; b=CSt1ofPW7YYW0+ehpYp4T5V2Zk+SqZdw4nFavFFhtkgA1HleePrFbM2Y/OvR1CJOQ2nMle r6gzIlI31fgfeHiprta6efMj7J72cdxI2QUv9+TommJSGqoGdsNwwj4wsEo6e7i2lK/fVk fIW+zgJqDQx3N9FD8uzknVeus0GziJI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HnQwEG5n; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686929323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=maoLH1+iFdOHtUfb3uVlDmFpd4ojetev/CDoWNYqeqE=; b=HnQwEG5npMlJGrv97fE0xZsrU7jfQaRErTJpaEGzCBQmTvgmhfsdO6dpq6+LTElE17aRuT hEe4CEfyFdB6xK1WBsM6PbYfMmqGsJeMPEDHDoV0elXL+oU1dWbyk+++in4Bw/YmfsjPhd DY5UqQOyp4v7+V3Wf7xAV+GqucvADFI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-277-VwVwMy6RNq2uvUCKs61D4w-1; Fri, 16 Jun 2023 11:28:36 -0400 X-MC-Unique: VwVwMy6RNq2uvUCKs61D4w-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A4AFF85A58A; Fri, 16 Jun 2023 15:28:35 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id C62E748FB01; Fri, 16 Jun 2023 15:28:30 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <51161740e832334594960ed43430b868a6f892c3.camel@gmail.com> References: <51161740e832334594960ed43430b868a6f892c3.camel@gmail.com> <20230524153311.3625329-1-dhowells@redhat.com> <20230524153311.3625329-4-dhowells@redhat.com> To: Alexander H Duyck Cc: dhowells@redhat.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeroen de Borst , Catherine Sullivan , Shailend Chand , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH net-next 03/12] mm: Make the page_frag_cache allocator alignment param a pow-of-2 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <617058.1686929309.1@warthog.procyon.org.uk> Date: Fri, 16 Jun 2023 16:28:29 +0100 Message-ID: <617059.1686929309@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Stat-Signature: sskz9jy5au7wkrsy1okt9yc8mnckygou X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B7ED440008 X-Rspam-User: X-HE-Tag: 1686929323-916456 X-HE-Meta: U2FsdGVkX1+xu0AQTJdxcLTBOlLemsONA6LiGDZHFkxKYlIsDnk8RqyiZ8/s2DqGWT1aJZAFEWsZ8jfJq+/Rd6V2YE0qUUvvqYpYyg0FSfhLuY8q4TS/AKmr0xa3jDPFyVzJ1jej93+0z4Y4xW61VS2UU6wnQUHrj1AeaVXy+Dg4sKtoRNTKbtXUeSfYhdmxT23TXJpbJJR9jQkgF8NzPdoJvFBqMYJ4I+/TM1lwUCtucnxHLz2E90OMvYVt0aj9U9XwYjJPRKW00ohV2F23bH4TlnWtvBoXi6qhYkDRnUq951nSv3t+53Hvp6gqRhtIczrK9SPJe/xIBERNIERUO4Hn067fzCLj/dglJdoV+uxYobrgI9h0d/XV/oPJnuiXdHPQ38kqrYd2EdS/2+MfvFg6g1HDrelYJ+etsy46hkLl4y1M9Z6zLQsD4xHVrP8uZm06gpSMr8265PVjaAD/L030/7fynEj5pXJtn6yBytOW0ZaZe+QZu6CoKQZKu2y7QGpEq8rkTSY6kH4kDHqL3mXaCOI4fFXXbl+e1sIBDtS8Cs7JGdonM7y6aa5T1Jy7kSB3Jpz9czfa06tWxxT9p97+WpjxG3vePglcDn5KSCUWsDGRMy701VoGr57cHmwWey+xglHKTXczXOMGVUHDN6quE4dyz9iBCDYcC11jl3QKNeOLrJzuRSGhEA81NHI/bbN4O2EgqnmOFXy0S4mDMzzVZ4LhdtMTsZ2//rhOn468fyEQOExtKvZk4VWTkyCv93/y2A+rmu5HZuM/Fk3VEba8pjpsLBPYIpJqfGao4jkJag4zBL5uhHSkCay10LM6h2D5dLg0ppE15gz0chG3eWT/vGU8FXA4Bn1LOcr68dtNS16tQdGy8+eRoEbjQhiCTcjM8OVlbLrtDLw9SmHqID0rU66uqIN33VNgufjR9IPZjII9efz+/b4x3vqv3kFDvvc6HPJgTnh6Chu+0w1 jV3LxmQE VDDro2BYID/1g+P6n9qahDfIluHCsiOY4cvOzmx2UcJUaIwdnYwdOMPvw5BAxRtoBreUEiD0QxWidJiytP108K2OmPgutg3pzh82bo34T6mUpKErnQ/bqPo4kxxTluuIW9omYwD4S7sZdTSNPO5zDr+LuSPcNY7VhGK18KKd/jgV2OQ/P5mTCQuHPK/OHMVGvPGEOEB9ZJJ0dm9rbPPJyw5abIAx5GKr/9cOgm6FMlxKnBVFJrYdp7PO8+Alfx+b8mRa6hlaLwQ58r6ma7G6Z5XsiJBnFBa/5Na96YVdBSKY9hJ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Alexander H Duyck wrote: > The requirement should only be cache alignment, not power of 2 > alignment. Sure, but, upstream, page_frag_alloc_align() allows the specification of an alignment and applies that alignment by: offset &= align_mask; which doesn't really make sense unless the alignment boils down to being a power of two. Now, it might make sense to kill off the align_mask parameter and just go with SMP_CACHE_BYTES (which will be a power of two). Note, though, that most users seem to use an align_mask of ~0u which feels a bit dodgy (it's not an unsigned long), but is probably fine. David