Message-ID: <61752087-04ba-c571-9ee6-b366adb54c68@...2181...> Date: Tue, 25 Jan 2022 17:27:14 +0100 MIME-Version: 1.0 Content-Language: en-US References: <20220121185752.14138-1-selva.nair@...277...> From: Antonio Quartulli In-Reply-To: <20220121185752.14138-1-selva.nair@...277...> Subject: Re: [Openvpn-devel] [PATCH] Do not error when md_kt_size() is called with mdname="none" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: selva.nair@...277..., openvpn-devel@lists.sourceforge.net Hi, On 21/01/2022 19:57, selva.nair@...277... wrote: > diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c > index 35fb0052..b93c680a 100644 > --- a/src/openvpn/crypto_openssl.c > +++ b/src/openvpn/crypto_openssl.c > @@ -1073,6 +1073,10 @@ md_kt_name(const char *mdname) > unsigned char > md_kt_size(const char *mdname) > { > + if (!strcmp("none", mdname)) Since we have it implemented, can we use streq() here? Cheers, -- Antonio Quartulli