Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2F0530B501 for ; Wed, 21 Jan 2026 17:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769016458; cv=none; b=TKzV37b7doYhtqNlIEeYJT5YSXbbJz8DuhhMTHtlyE59Q5WQgANWIlWyziiWZ/GF9S7rD8EMuydKNFC8QQ1AwUmUKbMWYJ2ElKbQBzL7z8Pj71onqhf2JoCeX5z8Yw5WKmkecdO/Ki2YEj0CVhv1FBXEkL65snWykSynXeeXB7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769016458; c=relaxed/simple; bh=IBcqZcBYK1qV2my0CzndFJ9PW1LwQc/cWistZ3f0E7Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I/AGM5tEOUQd8RHY7tIXnqir5zTsogCRsN6qrPZbBSzx4kfgGBpkAccNR6mjfLrY9sJV3nCUNntYSV5JbknwwE2TH44EkUbJqM6qJMgovq7lnRhFZyCYVFpJjjutQGpSlURV0rY55G5RDtLL01fFPkaz3agO8Gj9V1FucTnneMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=sPbIBxyj; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="sPbIBxyj" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4dxB3572JjzlffvM; Wed, 21 Jan 2026 17:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1769016447; x=1771608448; bh=IBcqZcBYK1qV2my0CzndFJ9P W1LwQc/cWistZ3f0E7Q=; b=sPbIBxyjt4uDD83KO7gg1g8sNSaSUbBbkjYkcst7 hkKHgUsYMObhmHB4UtXMK4ZWmNfJf0W1bcDCT+/pdjxwo7Ld466125diLdG76VFr +lk+J/ZREbFOYyTdHqGKRGq/KvN5fjbqSwtF/h/SUiD14MjZ3wVk1vr57uusgGRo 5jtu+bOzQEyl1Tn6lc9gBKto+pNnWaXuY3KKw39TeOcrJnrgeVuyMURiTn4YvnvJ D+ky45mbBxwWDutAMNAA6exZD3Sb9ZPB/nSYGGbSQCrWKNQVg8pc6/p2U8usqEAg z9xCIP2hw9D8tHEv/pEv1RwwXN+zfqewHDARXKoeUi6bxQ== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 6URgXspDJZE8; Wed, 21 Jan 2026 17:27:27 +0000 (UTC) Received: from [100.119.48.131] (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4dxB2z5FswzlfgS0; Wed, 21 Jan 2026 17:27:23 +0000 (UTC) Message-ID: <617eb7b5-358e-4257-aacc-d64ed109e2a2@acm.org> Date: Wed, 21 Jan 2026 09:27:22 -0800 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ufs: core: Use a host-wide tagset in SDB mode To: =?UTF-8?B?UGV0ZXIgV2FuZyAo546L5L+h5Y+LKQ==?= , "martin.petersen@oracle.com" Cc: "beanhuo@micron.com" , "vamshigajjela@google.com" , "alok.a.tiwari@oracle.com" , "quic_cang@quicinc.com" , "linux-scsi@vger.kernel.org" , "chenyuan0y@gmail.com" , "quic_nguyenb@quicinc.com" , "adrian.hunter@intel.com" , "ping.gao@samsung.com" , "avri.altman@sandisk.com" , "mani@kernel.org" , "James.Bottomley@HansenPartnership.com" References: <20260116180800.3085233-1-bvanassche@acm.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 1/20/26 11:21 PM, Peter Wang (=E7=8E=8B=E4=BF=A1=E5=8F=8B) wrote: > On Fri, 2026-01-16 at 10:07 -0800, Bart Van Assche wrote: >> In single-doorbell (SDB) mode there is only a single request queue. >> Hence, >> it doesn't matter whether or not the SCSI host tagset is configured >> as >> host-wide. Configure the host tagset as host-wide in SDB mode because >> this enables a simplification of the hot path. >=20 > Would this affect the performance of the SDB mode? Hi Peter, I reviewed all the blk_mq_is_shared_tags() calls in the block layer. Based on that analysis I don't expect a measurable performance impact. >> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c >> index 057678f4c50a..889da15a61f0 100644 >> --- a/drivers/ufs/core/ufshcd.c >> +++ b/drivers/ufs/core/ufshcd.c >> @@ -9320,6 +9320,7 @@ static const struct scsi_host_template >> ufshcd_driver_template =3D { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .max_segment_size=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 =3D PRDT_DATA_BYTE_COUNT_MAX, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .max_sectors=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D SZ_1M / SECTOR_SI= ZE, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .max_host_blocked=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 =3D 1, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .host_tagset=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D true, >=20 > Should be =3D 1? .host_tagset is used as a boolean and the compiler converts 'true' into=20 '1' if used as an integer so I think 'true' is fine. Thanks, Bart.