From: Maarten Lankhorst Subject: Re: [PATCH v2 6/6] drm/i915/display/icl: In port sync mode disable slaves first then master Date: Tue, 17 Sep 2019 17:05:58 +0200 Message-ID: <61c29c53-ca1d-3c49-441c-c3981099527a@linux.intel.com> References: <20190909034325.20006-7-manasi.d.navare@intel.com> <20190909155212.24230-2-manasi.d.navare@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBA686ECD4 for ; Tue, 17 Sep 2019 15:06:01 +0000 (UTC) In-Reply-To: <20190909155212.24230-2-manasi.d.navare@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare , intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org T3AgMDktMDktMjAxOSBvbSAxNzo1MiBzY2hyZWVmIE1hbmFzaSBOYXZhcmU6Cj4gSW4gdGhlIHRy YW5zY29kZXIgcG9ydCBzeW5jIG1vZGUsIHRoZSBzbGF2ZSB0cmFuc2NvZGVycyBtYXNrIHRoZWly IHZibGFua3MKPiB1bnRpbCBtYXN0ZXIgdHJhbnNjb2RlcidzIHZibGFuayBzbyB3aGlsZSBkaXNh YmxpbmcgdGhlbSwgbWFrZQo+IHN1cmUgc2xhdmVzIGFyZSBkaXNhYmxlZCBmaXJzdCBhbmQgdGhl biB0aGUgbWFzdGVycy4KPgo+IHY0Ogo+ICogT2J0YWluIHNsYXZlIHN0YXRlIGZyb20gbWFzdGVy IChNYWFydGVuKQo+IHYzOgo+ICogUmViYXNlCj4gdjI6Cj4gKiBVc2UgdGhlIGludGVsX29sZF9j cnRjX3N0YXRlX2Rpc2FibGVzKCkgaGVscGVyCj4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0 ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWF0dCBSb3BlciA8bWF0dGhldy5k LnJvcGVyQGludGVsLmNvbT4KPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXku YyB8IDYyICsrKysrKysrKysrKysrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1NiBpbnNlcnRp b25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCBhYzZlODgwNTcwZWEuLjhjMzMzMjgwZDhmNSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4gQEAg LTE0MDc0LDggKzE0MDc0LDQyIEBAIHN0YXRpYyB2b2lkIGludGVsX29sZF9jcnRjX3N0YXRlX2Rp c2FibGVzKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICAJCQkJCQkgICAgIG5l d19jcnRjX3N0YXRlKTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgaW50ZWxfdHJhbnNfcG9ydF9z eW5jX21vZGVzZXRfZGlzYWJsZXMoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4g KwkJCQkJCSAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICsJCQkJCQkgICBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUsCj4gKwkJCQkJCSAgIHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShzdGF0ZS0+YmFzZS5kZXYpOwo+ICsJc3RydWN0IGludGVs X2NydGMgKnNsYXZlX2NydGMgPSBpbnRlbF9nZXRfc2xhdmVfY3J0YyhkZXZfcHJpdiwKPiArCQkJ CQkJCSAgICAgbmV3X2NydGNfc3RhdGUpOwo+ICsJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5l d19zbGF2ZV9jcnRjX3N0YXRlID0KPiArCQlpbnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRl KHN0YXRlLCBzbGF2ZV9jcnRjKTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfc2xh dmVfY3J0Y19zdGF0ZSA9Cj4gKwkJaW50ZWxfYXRvbWljX2dldF9vbGRfY3J0Y19zdGF0ZShzdGF0 ZSwgc2xhdmVfY3J0Yyk7Cj4gKwo+ICsJV0FSTl9PTighc2xhdmVfY3J0YyB8fCAhbmV3X3NsYXZl X2NydGNfc3RhdGUgfHwKPiArCQkhb2xkX3NsYXZlX2NydGNfc3RhdGUpOwo+ICsKPiArCS8qIERp c2FibGUgU2xhdmUgZmlyc3QgKi8KPiArCWludGVsX3ByZV9wbGFuZV91cGRhdGUob2xkX3NsYXZl X2NydGNfc3RhdGUsIG5ld19zbGF2ZV9jcnRjX3N0YXRlKTsKPiArCWlmIChvbGRfc2xhdmVfY3J0 Y19zdGF0ZS0+YmFzZS5hY3RpdmUpCj4gKwkJaW50ZWxfb2xkX2NydGNfc3RhdGVfZGlzYWJsZXMo c3RhdGUsCj4gKwkJCQkJICAgICAgb2xkX3NsYXZlX2NydGNfc3RhdGUsCj4gKwkJCQkJICAgICAg bmV3X3NsYXZlX2NydGNfc3RhdGUsCj4gKwkJCQkJICAgICAgc2xhdmVfY3J0Yyk7Cj4gKwo+ICsJ LyogRGlzYWJsZSBNYXN0ZXIgKi8KPiArCWludGVsX3ByZV9wbGFuZV91cGRhdGUob2xkX2NydGNf c3RhdGUsIG5ld19jcnRjX3N0YXRlKTsKPiArCWlmIChvbGRfY3J0Y19zdGF0ZS0+YmFzZS5hY3Rp dmUpCj4gKwkJaW50ZWxfb2xkX2NydGNfc3RhdGVfZGlzYWJsZXMoc3RhdGUsCj4gKwkJCQkJICAg ICAgb2xkX2NydGNfc3RhdGUsCj4gKwkJCQkJICAgICAgbmV3X2NydGNfc3RhdGUsCj4gKwkJCQkJ ICAgICAgY3J0Yyk7Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIGludGVsX2NvbW1pdF9tb2Rlc2V0 X2Rpc2FibGVzKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICB7Cj4gKwlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KHN0YXRlLT5iYXNlLmRldik7 Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUsICpvbGRfY3J0Y19z dGF0ZTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ICAJaW50IGk7Cj4gQEAgLTE0MDky LDEzICsxNDEyNiwyOSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9jb21taXRfbW9kZXNldF9kaXNhYmxl cyhzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCQlpZiAoIW5lZWRzX21vZGVz ZXQobmV3X2NydGNfc3RhdGUpKQo+ICAJCQljb250aW51ZTsKPiAgCj4gLQkJaW50ZWxfcHJlX3Bs YW5lX3VwZGF0ZShvbGRfY3J0Y19zdGF0ZSwgbmV3X2NydGNfc3RhdGUpOwo+ICsJCS8qIEluIGNh c2Ugb2YgVHJhbnNjb2RlciBwb3J0IFN5bmMgbWFzdGVyIHNsYXZlIENSVENzIGNhbiBiZQo+ICsJ CSAqIGFzc2lnbmVkIGluIGFueSBvcmRlciBhbmQgd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdAo+ ICsJCSAqIHNsYXZlIENSVENzIGFyZSBkaXNhYmxlZCBmaXJzdCBhbmQgdGhlbiBtYXN0ZXIgQ1JU QyBzaW5jZQo+ICsJCSAqIFNsYXZlIHZibGFua3MgYXJlIG1hc2tlZCB0aWxsIE1hc3RlciBWYmxh bmtzLgo+ICsJCSAqLwo+ICsJCWlmIChpc190cmFuc19wb3J0X3N5bmNfbW9kZShkZXZfcHJpdiwg bmV3X2NydGNfc3RhdGUpKSB7Cj4gKwkJCWlmIChpc190cmFuc19wb3J0X3N5bmNfbWFzdGVyKGRl dl9wcml2LAo+ICsJCQkJCQkgICAgICBuZXdfY3J0Y19zdGF0ZSkpCj4gKwkJCQlpbnRlbF90cmFu c19wb3J0X3N5bmNfbW9kZXNldF9kaXNhYmxlcyhzdGF0ZSwKPiArCQkJCQkJCQkgICAgICAgY3J0 YywKPiArCQkJCQkJCQkgICAgICAgb2xkX2NydGNfc3RhdGUsCj4gKwkJCQkJCQkJICAgICAgIG5l d19jcnRjX3N0YXRlKTsKPiArCQkJZWxzZQo+ICsJCQkJY29udGludWU7Cj4gKwkJfSBlbHNlIHsK PiArCQkJaW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShvbGRfY3J0Y19zdGF0ZSwgbmV3X2NydGNfc3Rh dGUpOwo+ICAKPiAtCQlpZiAob2xkX2NydGNfc3RhdGUtPmJhc2UuYWN0aXZlKQo+IC0JCQlpbnRl bF9vbGRfY3J0Y19zdGF0ZV9kaXNhYmxlcyhzdGF0ZSwKPiAtCQkJCQkJICAgICAgb2xkX2NydGNf c3RhdGUsCj4gLQkJCQkJCSAgICAgIG5ld19jcnRjX3N0YXRlLAo+IC0JCQkJCQkgICAgICBjcnRj KTsKPiArCQkJaWYgKG9sZF9jcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkKPiArCQkJCWludGVsX29s ZF9jcnRjX3N0YXRlX2Rpc2FibGVzKHN0YXRlLAo+ICsJCQkJCQkJICAgICAgb2xkX2NydGNfc3Rh dGUsCj4gKwkJCQkJCQkgICAgICBuZXdfY3J0Y19zdGF0ZSwKPiArCQkJCQkJCSAgICAgIGNydGMp Owo+ICsJCX0KPiAgCX0KPiAgfQo+ICAKClNlcmllcyBsb29rcyBnb29kIHdpdGggdGhvc2UgZml4 ZXM6CgpSZXZpZXdlZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxp bnV4LmludGVsLmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeA==