Content-Type: multipart/mixed; boundary="===============8339818141847586701==" MIME-Version: 1.0 From: Rong Chen To: kbuild-all@lists.01.org Subject: Re: [PATCH] mm: gup: remove FOLL_SPLIT Date: Fri, 09 Apr 2021 16:44:21 +0800 Message-ID: <6236d7d0-7e81-c88a-e019-12707e574274@intel.com> In-Reply-To: List-Id: --===============8339818141847586701== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi John, On 3/30/21 3:08 PM, John Hubbard wrote: > On 3/29/21 11:24 PM, kernel test robot wrote: >> Hi Yang, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on hnaz-linux-mm/master] >> >> url: = >> https://github.com/0day-ci/linux/commits/Yang-Shi/mm-gup-remove-FOLL_SPL= IT/20210330-034042 >> base:=C2=A0=C2=A0 https://github.com/hnaz/linux-mm master >> config: s390-randconfig-r032-20210330 (attached as .config) >> compiler: s390-linux-gcc (GCC) 9.3.0 >> reproduce (this is a W=3D1 build): >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wget = >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross = >> -O ~/bin/make.cross >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 chmod +x ~/bin/make.cro= ss >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # = >> https://github.com/0day-ci/linux/commit/c8563a636718f98af86a3965d94e25b8= f2cf2354 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git remote add linux-re= view https://github.com/0day-ci/linux >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git fetch --no-tags lin= ux-review = >> Yang-Shi/mm-gup-remove-FOLL_SPLIT/20210330-034042 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git checkout c8563a6367= 18f98af86a3965d94e25b8f2cf2354 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # save the attached .co= nfig to linux build tree >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 COMPILER_INSTALL_PATH= =3D$HOME/0day COMPILER=3Dgcc-9.3.0 = >> make.cross ARCH=3Ds390 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >> =C2=A0=C2=A0=C2=A0 arch/s390/mm/gmap.c: In function 'thp_split_mm': >>>> arch/s390/mm/gmap.c:2498:27: error: 'FOLL_SPLIT' undeclared (first = >>>> use in this function); did you mean 'FOLL_PIN'? >> =C2=A0=C2=A0=C2=A0=C2=A0 2498 |=C2=A0=C2=A0=C2=A0 follow_page(vma, addr,= FOLL_SPLIT); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~= ~~ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 FOLL_PIN >> =C2=A0=C2=A0=C2=A0 arch/s390/mm/gmap.c:2498:27: note: each undeclared id= entifier is = >> reported only once for each function it appears in >> >> >> vim +2498 arch/s390/mm/gmap.c > > There appears to be an imperfection in this 0day testing system, = > because (just as the patch > says), commit ba925fa35057a062ac98c3e8138b013ce4ce351c ("s390/gmap: = > improve THP splitting"), > July 29, 2020, removes the above use of FOLL_SPLIT. > > And "git grep", just to be sure, shows it is not there in today's = > linux.git. So I guess the > https://github.com/0day-ci/linux repo needs a better way to stay in sync? Sorry for the delay, indeed, it's a issue from 0day-CI, we'll update = linux-mm in the system. Best Regards, Rong Chen --===============8339818141847586701==--