From: "selvanair (Code Review)"
Date: Thu, 23 Apr 2026 00:12:29 +0000
References:
Reply-To: selva.nair@...277..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <6255c5d3e20e479530c456341fdb38505064add6-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="S2prT2TVQs0="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fixup: prompting
password from management
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--S2prT2TVQs0=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1638?usp=3Demail
to review the following change.
Change subject: Fixup: prompting password from management
......................................................................
Fixup: prompting password from management
Commit b450414 added logic for reading password from management
when not in file or inline, but it was made conditional on
`response_from_stdin` which is always true! Fix by explicitly
checking for `password_from_stdin`.
Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202
Signed-off-by: Selva Nair
---
M src/openvpn/misc.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38/1638/1
diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c
index 979293f..10bfc35 100644
--- a/src/openvpn/misc.c
+++ b/src/openvpn/misc.c
@@ -336,6 +336,7 @@
*/
if (management && (flags & GET_USER_PASS_MANAGEMENT)
&& management_query_user_pass_enabled(management)
+ && password_from_stdin
&& !(flags & GET_USER_PASS_USERNAME_ONLY))
{
msg(D_LOW,
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1638?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202
Gerrit-Change-Number: 1638
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
--S2prT2TVQs0=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: plaisthos.
selvanair would like plaisthos to review this change.
V=
iew Change
Fixup: prompting password from management
Commit b450414 added logic for reading password from management
wh=
en not in file or inline, but it was made conditional on
`response_from_=
stdin` which is always true! Fix by explicitly
checking for `password_fr=
om_stdin`.
Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202
S=
igned-off-by: Selva Nair <selva.nair@...277...>
---
M src/openv=
pn/misc.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38=
/1638/1
diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c=
index 979293f..10bfc35 100644
--- a/src/openvpn/m=
isc.c
+++ b/src/openvpn/misc.c
@@ -336,6 +3=
36,7 @@
*/
if (m=
anagement && (flags & GET_USER_PASS_MANAGEMENT)
&& management_query_user_pass_enabled(management)=
+ &am=
p;& password_from_stdin
&& !(f=
lags & GET_USER_PASS_USERNAME_ONLY))
{
msg(D_LOW,
<=
p>To view, visit change 1638. To unsubscribe, or for help writing mail filters=
, visit settings=
.
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d46c3672691b159cbd98a17020=
c4f30782bc202
Gerrit-Change-Number: 1638
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <selva.nair@...1354...=
..>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
=
--S2prT2TVQs0=--