From: "flichtenheld (Code Review)" Date: Mon, 29 Jan 2024 10:45:48 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <62782a197aefc6227cf97b1549a0807d39f96b42-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="y7u2kN7uxhQ="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: gerrit-send-mail: Make output consistent across systems List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --y7u2kN7uxhQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/508?usp=3Demail to review the following change. Change subject: gerrit-send-mail: Make output consistent across systems ...................................................................... gerrit-send-mail: Make output consistent across systems When writing the file specify encoding and newline, so that the local settings (like locale) do not change the output. Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40 Signed-off-by: Frank Lichtenheld --- M dev-tools/gerrit-send-mail.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/08/508/1 diff --git a/dev-tools/gerrit-send-mail.py b/dev-tools/gerrit-send-mail.py index 5429aef..67a2cf1 100755 --- a/dev-tools/gerrit-send-mail.py +++ b/dev-tools/gerrit-send-mail.py @@ -109,7 +109,7 @@ ) filename =3D f"gerrit-{args.changeid}-{details['revision']}.patch" patch_text_final =3D patch_text_mod.replace("Subject: [PATCH]", f"Subj= ect: [PATCH v{details['revision']}]") - with open(filename, "w") as patch_file: + with open(filename, "w", encoding=3D"utf-8", newline=3D"\n") as patch_= file: patch_file.write(patch_text_final) print("send with:") print(f"git send-email --in-reply-to {details['msg_id']} {filename}") -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/508?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40 Gerrit-Change-Number: 508 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --y7u2kN7uxhQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

Vi= ew Change

gerrit-send-mail: Make output consistent across systems
When writing the file specify encoding and newline, so that
the local = settings (like locale) do not change the output.

Change-Id: Id7b4bda= 38adfbb446bdac635ac5d5207ef3f2f40
Signed-off-by: Frank Lichtenheld <f= rank@...2641...>
---
M dev-tools/gerrit-send-mail.py
1 file cha= nged, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn=
.net:29418/openvpn refs/changes/08/508/1
diff --git a/dev-tools/ger=
rit-send-mail.py b/dev-tools/gerrit-send-mail.py
index 5429= aef..67a2cf1 100755
--- a/dev-tools/gerrit-send-mail.py
+++ b/dev-tools/gerrit-send-mail.py
@@ -109,7 = +109,7 @@
)
filename =3D f"g= errit-{args.changeid}-{details['revision']}.patch"
<= span> patch_text_final =3D patch_text_mod.replace("Subject: [PATCH= ]", f"Subject: [PATCH v{details['revision']}]")
- with open(filename, &q= uot;w") as patch_file:
+ with open(filename, "w", encoding=3D"utf-8"= , newline=3D"\n") as patch_file:
patch_f= ile.write(patch_text_final)
print("send with:&quo= t;)
print(f"git send-email --in-reply-to {details= ['msg_id']} {filename}")

T= o view, visit change 508. To unsubscribe, or for help writing mail filters, visi= t settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id7b4bda38adfbb446bdac635ac5= d5207ef3f2f40
Gerrit-Change-Number: 508
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--y7u2kN7uxhQ=--