From: Dave Gordon Subject: Re: [PATCH v3 1/4] drm/i915/guc: symbolic names for GuC submission preferences Date: Mon, 1 Aug 2016 19:57:54 +0100 Message-ID: <62a35c6f-bf7a-03ba-9f7e-4ae34dfd6c12@intel.com> References: <1469194342-8102-1-git-send-email-david.s.gordon@intel.com> <1469194342-8102-2-git-send-email-david.s.gordon@intel.com> <87invktx0u.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 88CB46E3AE for ; Mon, 1 Aug 2016 18:57:56 +0000 (UTC) In-Reply-To: <87invktx0u.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDEvMDgvMTYgMTQ6NTQsIEphbmkgTmlrdWxhIHdyb3RlOgo+IE9uIEZyaSwgMjIgSnVsIDIw MTYsIERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+IHdyb3RlOgo+PiBUaGUg ZXhpc3RpbmcgY29kZSB0aGF0IGFjY2Vzc2VzIHRoZSAiZW5hYmxlX2d1Y19zdWJtaXNzaW9uIgo+ PiBwYXJhbWV0ZXIgdXNlcyBleHBsaWNpdCBudW1lcmljYWwgdmFsdWVzIGZvciB0aGUgdmFyaW91 cwo+PiBwb3NzaWJpbGl0aWVzLCBpbmNsdWRpbmcgaW4gb25lIGNhc2UgcmVseWluZyBvbiBib29s ZWFuIDAvMQo+PiBtYXBwaW5nIHRvIHNwZWNpZmljIHZhbHVlcyAod2hpY2ggY291bGQgYmUgY29u ZnVzaW5nIGZvcgo+PiBtYWludGFpbmVycykuCj4+Cj4+IFNvIHRoaXMgcGF0Y2gganVzdCBwcm92 aWRlcyBhbmQgdXNlcyBuYW1lcyBmb3IgdGhlIHZhbHVlcwo+PiByZXByZXNlbnRpbmcgdGhlIERF RkFVTFQsIERJU0FCTEVELCBQUkVGRVJSRUQsIGFuZCBNQU5EQVRPUlkKPj4gc3VibWlzc2lvbiBv cHRpb25zIHRoYXQgdGhlIHVzZXIgY2FuIHNlbGVjdCAoLTEsIDAsIDEsIDIKPj4gcmVzcGVjdGl2 ZWx5KS4KPj4KPj4gVGhpcyBzaG91bGQgcHJvZHVjZSBpZGVudGljYWwgY29kZSB0byB0aGUgcHJl dmlvdXMgdmVyc2lvbiEKPj4KPj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMu Z29yZG9uQGludGVsLmNvbT4KPj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBs aW51eC5pbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNf c3VibWlzc2lvbi5jIHwgIDIgKy0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5o ICAgICAgICAgICB8ICA2ICsrKysrKwo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3Vj X2xvYWRlci5jICAgIHwgMTUgKysrKysrKystLS0tLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9scmMuYyAgICAgICAgICAgfCAgNiArKystLS0KPj4gIDQgZmlsZXMgY2hhbmdlZCwg MTggaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gaW5kZXggMDFjMWMxNi4uZTU2NGM5NzYgMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gQEAg LTk3MSw3ICs5NzEsNyBAQCBpbnQgaTkxNV9ndWNfc3VibWlzc2lvbl9pbml0KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gIAliaXRtYXBfY2xlYXIoZ3VjLT5kb29yYmVsbF9i aXRtYXAsIDAsIEdVQ19NQVhfRE9PUkJFTExTKTsKPj4gIAlpOTE1X2d1Y19zdWJtaXNzaW9uX2Rp c2FibGUoZGV2X3ByaXYpOwo+Pgo+PiAtCWlmICghaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24p Cj4+ICsJaWYgKGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uID09IEdVQ19TVUJNSVNTSU9OX0RJ U0FCTEVEKQo+PiAgCQlyZXR1cm4gMDsgLyogbm90IGVuYWJsZWQgICovCj4+Cj4+ICAJaWYgKGd1 Yy0+Y3R4X3Bvb2xfb2JqKQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+PiBpbmRleCAzZTNl NzQzLi41MmVjYmJhIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9n dWMuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+PiBAQCAtOTAs NiArOTAsMTIgQEAgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCB7Cj4+ICAJdWludDY0X3Qgc3VibWlz c2lvbnNbSTkxNV9OVU1fRU5HSU5FU107Cj4+ICB9Owo+Pgo+PiArZW51bSB7Cj4+ICsJR1VDX1NV Qk1JU1NJT05fREVGQVVMVCA9IC0xLAo+PiArCUdVQ19TVUJNSVNTSU9OX0RJU0FCTEVEID0gMCwK Pj4gKwlHVUNfU1VCTUlTU0lPTl9QUkVGRVJSRUQsCj4+ICsJR1VDX1NVQk1JU1NJT05fTUFOREFU T1JZCj4+ICt9Owo+PiAgZW51bSBpbnRlbF9ndWNfZndfc3RhdHVzIHsKPj4gIAlHVUNfRklSTVdB UkVfRkFJTCA9IC0xLAo+PiAgCUdVQ19GSVJNV0FSRV9OT05FID0gMCwKPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+PiBpbmRleCBiODgzZWZkLi5kOGJkNGNiIDEwMDY0 NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4+IEBAIC0xODksNyAr MTg5LDcgQEAgc3RhdGljIHZvaWQgc2V0X2d1Y19pbml0X3BhcmFtcyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAJfQo+Pgo+PiAgCS8qIElmIEd1QyBzdWJtaXNzaW9uIGlz IGVuYWJsZWQsIHNldCB1cCBhZGRpdGlvbmFsIHBhcmFtZXRlcnMgaGVyZSAqLwo+PiAtCWlmIChp OTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbikgewo+PiArCWlmIChpOTE1LmVuYWJsZV9ndWNfc3Vi bWlzc2lvbiAhPSBHVUNfU1VCTUlTU0lPTl9ESVNBQkxFRCkgewo+PiAgCQl1MzIgcGdzID0gaTkx NV9nZW1fb2JqX2dndHRfb2Zmc2V0KGRldl9wcml2LT5ndWMuY3R4X3Bvb2xfb2JqKTsKPj4gIAkJ dTMyIGN0eF9pbl8xNiA9IEdVQ19NQVhfR1BVX0NPTlRFWFRTIC8gMTY7Cj4+Cj4+IEBAIC00OTUs NyArNDk1LDcgQEAgaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ PiAgCQlpbnRlbF9ndWNfZndfc3RhdHVzX3JlcHIoZ3VjX2Z3LT5ndWNfZndfZmV0Y2hfc3RhdHVz KSwKPj4gIAkJaW50ZWxfZ3VjX2Z3X3N0YXR1c19yZXByKGd1Y19mdy0+Z3VjX2Z3X2xvYWRfc3Rh dHVzKSk7Cj4+Cj4+IC0JaWYgKGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uKSB7Cj4+ICsJaWYg KGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uICE9IEdVQ19TVUJNSVNTSU9OX0RJU0FCTEVEKSB7 Cj4+ICAJCWVyciA9IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKGRldl9wcml2KTsKPj4gIAkJ aWYgKGVycikKPj4gIAkJCWdvdG8gZmFpbDsKPj4gQEAgLTUyMyw3ICs1MjMsNyBAQCBpbnQgaW50 ZWxfZ3VjX3NldHVwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ICAJICovCj4+ICAJaWYgKGk5 MTUuZW5hYmxlX2d1Y19sb2FkaW5nID4gMSkgewo+PiAgCQlyZXQgPSAtRUlPOwo+PiAtCX0gZWxz ZSBpZiAoaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24gPiAxKSB7Cj4+ICsJfSBlbHNlIGlmIChp OTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA+PSBHVUNfU1VCTUlTU0lPTl9NQU5EQVRPUlkpIHsK Pgo+IEkgbGlrZSB0aGUgcGF0Y2hlcyBpbiBnZW5lcmFsLCBidXQgbm93IHRoZXNlID49IGFuZCA8 PSBzZWVtIHJhdGhlciBvdXQKPiBvZiBwbGFjZS4gSG93IGFib3V0IHVzaW5nID09IGFuZCAhPSBl eGNsdXNpdmVseT8KPgo+IEJSLAo+IEphbmkuCgpUaGF0IHdvdWxkIGxlYXZlIHVzIHdpdGggdW5k ZWZpbmVkIGJlaGF2aW91ciBmb3IgdmFsdWVzIG91dHNpZGUgdGhlIApyZWNvZ25pc2VkIHJhbmdl LiBUaGlzIHdheSBpdCBjbGlwcyBvdXQtb2YtcmFuZ2UgdmFsdWVzIHRvIHRoZSBuZWFyZXN0IApl eHRyZW11bS4gT2YgY291cnNlIHdlIGNvdWxkIG1ha2UgaXQgZmFpbCBjb21wbGV0ZWx5IGZvciBp bnZhbGlkIHZhbHVlcywgCmJ1dCB0aGF0J3MganVzdCByZWFsbHkgYW5ub3lpbmcgZm9yIHRoZSBk ZXZlbG9wZXIgb3IgYWRtaW4gd2hvJ3MgCm1pc3R5cGVkIC0xIGFzIC0yIG9yIGZvcmdvdHRlbiB3 aGF0IHRoZSBtYXhpbXVtIHN1cHBvcnRlZCB2YWx1ZSBpcyBpbiAKdGhpcyByZWxlYXNlLiBBbHRl cm5hdGl2ZWx5IHdlIGNvdWxkIGNvbnZlcnQgYWxsIG91dC1vZi1yYW5nZSB2YWx1ZXMgdG8gCiJz eXN0ZW0gZGVmYXVsdCIgaS5lLiBpZ25vcmVkLCB3aGljaCBtaWdodCBzdGlsbCBiZSBhbm5veWlu ZyBidXQgbm90IApxdWl0ZSBhcyBtdWNoLgoKQW55IG90aGVyIHN1Z2dlc3Rpb25zIGZvciBob3cg dG8gaGFuZGxlIG91dC1vZi1yYW5nZSB2YWx1ZXM/CgpCdXQgaWYgd2Ugd2VyZSBjaGFuZ2luZyB0 aGUgcG9saWN5IHNob3VsZG4ndCB0aGF0IGJlIGEgc2VwYXJhdGUgcGF0Y2g/IApUaGlzIHBhdGNo IGlzIHN1cHBvc2VkIHRvIGNoYW5nZSBvbmx5IHRoZSB3YXkgdGhlIGNvZGUgaXMgd3JpdHRlbiwg d2l0aCAKbm8gZWZmZWN0IHRvIGV4aXN0aW5nIGJlaGF2aW91ciEKCi5EYXZlLgoKPj4gIAkJcmV0 ID0gLUVJTzsKPj4gIAl9IGVsc2Ugewo+PiAgCQlyZXQgPSAwOwo+PiBAQCAtNTM4LDcgKzUzOCw3 IEBAIGludCBpbnRlbF9ndWNfc2V0dXAoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4gIAllbHNl Cj4+ICAJCURSTV9FUlJPUigiR3VDIGZpcm13YXJlIGxvYWQgZmFpbGVkOiAlZFxuIiwgZXJyKTsK Pj4KPj4gLQlpZiAoaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24pIHsKPj4gKwlpZiAoaTkxNS5l bmFibGVfZ3VjX3N1Ym1pc3Npb24gIT0gR1VDX1NVQk1JU1NJT05fRElTQUJMRUQpIHsKPj4gIAkJ aWYgKGZ3X3BhdGggPT0gTlVMTCkKPj4gIAkJCURSTV9JTkZPKCJHdUMgc3VibWlzc2lvbiB3aXRo b3V0IGZpcm13YXJlIG5vdCBzdXBwb3J0ZWRcbiIpOwo+PiAgCQlpZiAocmV0ID09IDApCj4+IEBA IC01NDYsNyArNTQ2LDcgQEAgaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+PiAgCQllbHNlCj4+ICAJCQlEUk1fRVJST1IoIkd1QyBpbml0IGZhaWxlZDogJWRcbiIs IHJldCk7Cj4+ICAJfQo+PiAtCWk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uID0gMDsKPj4gKwlp OTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA9IEdVQ19TVUJNSVNTSU9OX0RJU0FCTEVEOwo+Pgo+ PiAgCXJldHVybiByZXQ7Cj4+ICB9Cj4+IEBAIC02OTAsOCArNjkwLDkgQEAgdm9pZCBpbnRlbF9n dWNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgCS8qIEEgbmVnYXRpdmUgdmFsdWUg bWVhbnMgInVzZSBwbGF0Zm9ybSBkZWZhdWx0IiAqLwo+PiAgCWlmIChpOTE1LmVuYWJsZV9ndWNf bG9hZGluZyA8IDApCj4+ICAJCWk5MTUuZW5hYmxlX2d1Y19sb2FkaW5nID0gSEFTX0dVQ19VQ09E RShkZXYpOwo+PiAtCWlmIChpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA8IDApCj4+IC0JCWk5 MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uID0gSEFTX0dVQ19TQ0hFRChkZXYpOwo+PiArCWlmIChp OTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA8PSBHVUNfU1VCTUlTU0lPTl9ERUZBVUxUKQo+PiAr CQlpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA9IEhBU19HVUNfU0NIRUQoZGV2KSA/Cj4+ICsJ CQlHVUNfU1VCTUlTU0lPTl9QUkVGRVJSRUQgOiBHVUNfU1VCTUlTU0lPTl9ESVNBQkxFRDsKPj4K Pj4gIAlpZiAoIUhBU19HVUNfVUNPREUoZGV2KSkgewo+PiAgCQlmd19wYXRoID0gTlVMTDsKPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gaW5kZXggZGFmMTI3OS4uOTYwZTY3NiAxMDA2NDQK Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gQEAgLTcxNiw3ICs3MTYsNyBAQCBpbnQgaW50 ZWxfbG9naWNhbF9yaW5nX2FsbG9jX3JlcXVlc3RfZXh0cmFzKHN0cnVjdCBkcm1faTkxNV9nZW1f cmVxdWVzdCAqcmVxdWVzdAo+Pgo+PiAgCXJlcXVlc3QtPnJpbmdidWYgPSBjZS0+cmluZ2J1ZjsK Pj4KPj4gLQlpZiAoaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24pIHsKPj4gKwlpZiAoaTkxNS5l bmFibGVfZ3VjX3N1Ym1pc3Npb24gIT0gR1VDX1NVQk1JU1NJT05fRElTQUJMRUQpIHsKPj4gIAkJ LyoKPj4gIAkJICogQ2hlY2sgdGhhdCB0aGUgR3VDIGhhcyBzcGFjZSBmb3IgdGhlIHJlcXVlc3Qg YmVmb3JlCj4+ICAJCSAqIGdvaW5nIGFueSBmdXJ0aGVyLCBhcyB0aGUgaTkxNV9hZGRfcmVxdWVz dCgpIGNhbGwKPj4gQEAgLTc5NSw3ICs3OTUsNyBAQCBpbnQgaW50ZWxfbG9naWNhbF9yaW5nX2Fs bG9jX3JlcXVlc3RfZXh0cmFzKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdAo+ PiAgCXJlcXVlc3QtPnByZXZpb3VzX2NvbnRleHQgPSBlbmdpbmUtPmxhc3RfY29udGV4dDsKPj4g IAllbmdpbmUtPmxhc3RfY29udGV4dCA9IHJlcXVlc3QtPmN0eDsKPj4KPj4gLQlpZiAoaTkxNS5l bmFibGVfZ3VjX3N1Ym1pc3Npb24pCj4+ICsJaWYgKGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9u ICE9IEdVQ19TVUJNSVNTSU9OX0RJU0FCTEVEKQo+PiAgCQlpOTE1X2d1Y19zdWJtaXQocmVxdWVz dCk7Cj4+ICAJZWxzZQo+PiAgCQlleGVjbGlzdHNfY29udGV4dF9xdWV1ZShyZXF1ZXN0KTsKPj4g QEAgLTk4OCw3ICs5ODgsNyBAQCBzdGF0aWMgaW50IGludGVsX2xyX2NvbnRleHRfcGluKHN0cnVj dCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4+ICAJY2UtPnN0YXRlLT5kaXJ0eSA9IHRydWU7Cj4+ Cj4+ICAJLyogSW52YWxpZGF0ZSBHdUMgVExCLiAqLwo+PiAtCWlmIChpOTE1LmVuYWJsZV9ndWNf c3VibWlzc2lvbikKPj4gKwlpZiAoaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24gIT0gR1VDX1NV Qk1JU1NJT05fRElTQUJMRUQpCj4+ICAJCUk5MTVfV1JJVEUoR0VOOF9HVENSLCBHRU44X0dUQ1Jf SU5WQUxJREFURSk7Cj4+Cj4+ICAJaTkxNV9nZW1fY29udGV4dF9nZXQoY3R4KTsKPgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==