From: Dmitry Osipenko Subject: Re: [PATCH v2 1/2] clk: tegra: divider: Add missing check for enable-bit on rate's recalculation Date: Tue, 29 Oct 2019 03:14:40 +0300 Message-ID: <62c375bd-09ae-e09f-6ca2-c1395eebc5fa@gmail.com> References: <20190723025245.27754-1-digetx@gmail.com> <20191028142753.GC27141@pdeschrijver-desktop.Nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20191028142753.GC27141@pdeschrijver-desktop.Nvidia.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Peter De Schrijver Cc: Michael Turquette , Thierry Reding , Jonathan Hunter , Prashant Gaikwad , Stephen Boyd , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org 28.10.2019 17:27, Peter De Schrijver пишет: > On Tue, Jul 23, 2019 at 05:52:44AM +0300, Dmitry Osipenko wrote: >> Unset "enable" bit means that divider is in bypass mode, hence it doesn't >> have any effect in that case. Please note that there are no known bugs >> caused by the missing check. >> > > Technically this is not quite true, but for the purposes of CCF you can > treat it that way. This bits defines if the value in the lower 16 bits > of the divider register is used to configure the divider or if the > contents of the UART DLM/DLL registers is used. So the divider isn't > actually bypassed, it's just configured differently. > In practice this bit is only set when the divider is non-zero when doing > set rate. So the extra test isn't strictly needed as long as the sw > running before the kernel also ensures the bit is only set when the > divider is non-zero. > > Acked-by: Peter De Schrijver Thank you for the clarification. I hope that bootloader doesn't enable the divider because it looks like standard 8250 driver won't be ready for that. But serial-tegra driver seems should be good.