From: =?UTF-8?Q?Christian_K=c3=b6nig?= Date: Wed, 20 May 2020 12:05:19 +0000 Subject: Re: [PATCH] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling Message-Id: <62d9d539-8401-233a-3f20-984042489987@gmail.com> List-Id: References: <20200520120054.GB172354@mwanda> In-Reply-To: <20200520120054.GB172354@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Alex Deucher , Kevin Wang Cc: David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Rui Huang , dri-devel@lists.freedesktop.org, Daniel Vetter , Yintian Tao , Evan Quan , Kenneth Feng , =?UTF-8?Q?Christian_K=c3=b6nig?= , Hawking Zhang Am 20.05.20 um 14:00 schrieb Dan Carpenter: > This loop in the error handling code should start a "i - 1" and end at > "i = 0". Currently it starts a "i" and ends at "i = 1". The result > is that it removes one attribute that wasn't created yet, and leaks the > zeroeth attribute. > > Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > index b75362bf0742..ee4a8e44fbeb 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > @@ -1931,7 +1931,7 @@ static int amdgpu_device_attr_create_groups(struct amdgpu_device *adev, > uint32_t mask) > { > int ret = 0; > - uint32_t i = 0; > + int i; > > for (i = 0; i < counts; i++) { > ret = amdgpu_device_attr_create(adev, &attrs[i], mask); > @@ -1942,9 +1942,8 @@ static int amdgpu_device_attr_create_groups(struct amdgpu_device *adev, > return 0; > > failed: > - for (; i > 0; i--) { > + while (--i >= 0) As far as I know the common idiom for this is while (i--) which even works without changing the type of i to signed. Christian. > amdgpu_device_attr_remove(adev, &attrs[i]); > - } > > return ret; > }