References: <20201211125957.7764-1-arne@...1227...> From: Steffan Karger Message-ID: <62f57160-4048-888e-875e-38e3084aba9f@...1856...> Date: Sun, 13 Dec 2020 09:36:01 +0100 MIME-Version: 1.0 In-Reply-To: <20201211125957.7764-1-arne@...1227...> Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH] Fix tls-auth mismatch OCC message when tls-cryptv2 is used. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: openvpn-devel@lists.sourceforge.net Hi, On 11-12-2020 13:59, Arne Schwabe wrote: > A server with tls-cryptv2 and tls-auth produces the warning: > > WARNING: 'tls-auth' is present in local config but missing in remote config, local='tls-auth'" > > The tls-auth option has no argument so the strpefix with the space > included does not match it. > > Signed-off-by: Arne Schwabe > --- > src/openvpn/options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > index d824cbad..d9d492b2 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -4138,7 +4138,7 @@ options_warning_safe_scan2(const int msglevel, > if (strprefix(p1, "key-method ") > || strprefix(p1, "keydir ") > || strprefix(p1, "proto ") > - || strprefix(p1, "tls-auth ") > + || streq(p1, "tls-auth") > || strprefix(p1, "tun-ipv6") > || strprefix(p1, "cipher ")) > { > Thanks for fixing this. Acked-by: Steffan Karger -Steffan