From: "stipa (Code Review)" Date: Wed, 27 Nov 2024 11:41:18 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., marco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <62f8b2728ecea167f111bccf587c85bc1a78de86-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="GvwA5PxjdTI="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrbff Cc: flichtenheld , plaisthos , openvpn-devel --GvwA5PxjdTI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/808?usp=3Demail ) Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and ha= ndle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 4: (7 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/808/comment/6208a664_8a387af8 : PS4, Line 812: nit: whitespace File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/4862d3bd_9b57ad9f : PS4, Line 2033: int status =3D do_route(&c->options, c->c1.rout= e_list, c->c1.route_ipv6_list, nice catch! File src/openvpn/options_util.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/93ec136c_da93606f : PS4, Line 124: check_push_update_option_flags(char **line, unsigned int *fl= ags) Add doxygen what does this function do. http://gerrit.openvpn.net/c/openvpn/+/808/comment/cacb7fd2_2e6844f7 : PS4, Line 138: if (str[1]) below 8 lines are duplicated 3 times. Maybe define a macro and reuse it, an= d later undefine? Like #define ADVANCE_OR_FAIL(ptr) \ do { \ if (!(ptr)[1]) \ return false; \ c =3D *(++(ptr)); \ } while (0) http://gerrit.openvpn.net/c/openvpn/+/808/comment/fc0ee113_1823490a : PS4, Line 160: if (c =3D=3D '-' && !(*flags & PUSH_OPT_TO_REMOVE)) you could remove the "c =3D=3D '-'" check here and move this whole block un= der the "if" condition above http://gerrit.openvpn.net/c/openvpn/+/808/comment/76877514_402d6e34 : PS4, Line 221: apply_pull_filter(const struct options *o, char *line, bool = is_update, unsigned int *push_update_option_flags) Let's move doxygen to the header. File src/openvpn/push.h: http://gerrit.openvpn.net/c/openvpn/+/808/comment/811984a2_89dbae3b : PS4, Line 47: int process_incoming_push_update(struct context *c, Doxygen -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 4 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: stipa Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: mrbff Gerrit-Comment-Date: Wed, 27 Nov 2024 11:41:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --GvwA5PxjdTI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, mrbff, plaisthos. <= /p>

View C= hange

7 comments:

To view, visit change 808. = To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595= c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 4
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <= /div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: mrbff <marco@...2726...&g= t;
Gerrit-Comment-Date: Wed, 27 Nov 2024 11:41:18= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--GvwA5PxjdTI=--