From: "cron2 (Code Review)" Date: Wed, 23 Jul 2025 06:07:22 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., antonio@...2726... Message-ID: <630d32c88fb9f33dbb4695eb569c61f58df77605-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="7CxF/WQeuX4="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: dco_linux: rearrange functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --7CxF/WQeuX4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1098?usp=3Demail ) Change subject: dco_linux: rearrange functions ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: I have quite a dislike for "move functions around" patches, as they break "= git blame" and thus cause future extra work... this one could have been add= ressed by moving `ovpn_handle_msg()` *down* (which gets rewritten anyway). = But anyway. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1098?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I94004579aef4a1ccccdbcf8edd7b722e5a611c72 Gerrit-Change-Number: 1098 Gerrit-PatchSet: 2 Gerrit-Owner: ordex Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Wed, 23 Jul 2025 06:07:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --7CxF/WQeuX4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, ordex, plaisthos. <= /p>

Patch set 2:Code-Review +2=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #2:

      I have quite a dislike for "move functi= ons around" patches, as they break "git blame" and thus caus= e future extra work... this one could have been addressed by moving `ovpn_h= andle_msg()` *down* (which gets rewritten anyway). But anyway.

    To view, visit change 1098. To unsubscribe, or for help writing = mail filters, visit settings= .

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I94004579aef4a1ccccdbcf8edd7= b722e5a611c72
    Gerrit-Change-Number: 1098
    Gerrit-PatchSet: 2
    Gerrit-Owner: ordex <antonio@...2726...>=
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Attention: ordex <antonio@...2726...= >
    Gerrit-Comment-Date: Wed, 23 Jul 2025 06:07:22= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --7CxF/WQeuX4=--