Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B34D2C77B61 for ; Thu, 13 Apr 2023 13:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MX6SzGbqGl0l6noMXH4ooBt0DZ0nEQZn1530s8B8Gyc=; b=YBMGxDW6cJo7v2 bxiEkmhwYKk67zN7sv+Y8QRskfTUPjNI/aHIrgyWGiQLAbdAfFsX/2+SzlTTyqplvnqsmuGHorf11 G6XKhNW+S3C5PR++YDUKQ4pCwOrqujbx1pwPiw6xFMQhfbAniyIoABtNSju0VzlbwcWDg8UULj03I F9dt4nVjOB7NJdLX3dVLCqC2dE3den5nuO4aG7yXRIEgGbMer3pjjeQWhhE3365mL1JmHOzNdZULa 8eXL/11qsWMFR57H62tlj+6ltVH0iDKHIzMhyTbDslKh5NrX1lrlUcqv6eTe9r+GhxB7MRuEGNAOl cnfDPSz8gNuUr6Y3BNNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmx6p-006HnW-0O; Thu, 13 Apr 2023 13:35:31 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmx6m-006Hmq-0o for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 13:35:29 +0000 Received: by mail-wm1-x329.google.com with SMTP id bi22-20020a05600c3d9600b003f0ad935166so520080wmb.4 for ; Thu, 13 Apr 2023 06:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681392925; x=1683984925; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=8TjBZzOOiUgO+kPtxRd7fVCLfb724PvO409lq7nUTs0=; b=FVXnBRXb6Z6XxnsBV+IeLPfjsgEtX82YOBpUOZdObpHAP4HsohkezHyCZJxpgOHOqs Dh5XK/yLHqpR2Etxy2llHaDk+ECBj5vcr4OiyCpeQpBw4Xcr/v6g5MQfVxMW6B2KXsrN 1JOzNg5YQGuQT8IJPwyBxKRJGsT2pTy8CXPYLd0NishC7i1X6PyBdYUcAdXXO/iaezOg AILWSLTWY6sB2awEkx2MAj71vUCpqpN1qMwQFyXSMaoZzkNENBZhulOincOb8snUHrsY pRc4zpV8kSUzVZrbb84dp7jObIGZEFoqNOUweYZ27i/rUQYr1OgOfwaUmowTKc86jJ9j Hocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681392925; x=1683984925; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8TjBZzOOiUgO+kPtxRd7fVCLfb724PvO409lq7nUTs0=; b=AkULRgrEcHQOkyX10OCJjW5+9luRJaojCeFfVZ/2uCDjt3aBNaS1c1EgI4t99MC1/r qcKbgO5FETIzgmn836Pe0mgwQ5+B63IakYqXxJDe5/d137C8gUkERK9qmqnoUb8sVXfR ivJr9gVQEoe7neM27zT4pyk9ahJHV4r0PyOiHJkMQJ0qB8SJB9rDVfOAm/qK+q0N2/7H lG9jHbxR59nCc2oTdCxIp4ZABg3O3d0ORhV5YI5RNhO+232gxHpPsgvxcK6Ezzpj/8CH /30wap96ZtEZqazQuNR6b8JoEiI2yljm6OKZ7G2vU6aYc/jf1dFm8zRJo77T8H28+jjD gYEw== X-Gm-Message-State: AAQBX9dQWdxSm54CNtYk/n5rcF5oeIokyk9OtfGgNZFISXjn4VKS1cfF T57D5zxaA2/LZLEbo+I4TkY= X-Google-Smtp-Source: AKy350YJ2r3wCl95kUb5MnB+RTinXg4FYMSNGuFQm03tfAqvfcmOAHrPbsmhYq/PWiUf5132l7aRRg== X-Received: by 2002:a1c:6a0d:0:b0:3ed:377b:19cc with SMTP id f13-20020a1c6a0d000000b003ed377b19ccmr1849363wmc.0.1681392925135; Thu, 13 Apr 2023 06:35:25 -0700 (PDT) Received: from Ansuel-xps. (host-87-7-13-196.retail.telecomitalia.it. [87.7.13.196]) by smtp.gmail.com with ESMTPSA id h15-20020a05600c350f00b003ee9f396dcesm5585905wmq.30.2023.04.13.06.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 06:35:24 -0700 (PDT) Message-ID: <6438051c.050a0220.d7db1.e1f7@mx.google.com> X-Google-Original-Message-ID: Date: Thu, 13 Apr 2023 00:42:47 +0200 From: Christian Marangi To: Rob Herring Cc: Pavel Machek , Lee Jones , Krzysztof Kozlowski , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [net-next PATCH v6 12/16] dt-bindings: net: dsa: qca8k: add LEDs definition example References: <20230327141031.11904-1-ansuelsmth@gmail.com> <20230327141031.11904-13-ansuelsmth@gmail.com> <20230406141018.GA2956156-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230406141018.GA2956156-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_063528_291014_C0A7F43B X-CRM114-Status: GOOD ( 24.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 06, 2023 at 09:10:18AM -0500, Rob Herring wrote: > On Mon, Mar 27, 2023 at 04:10:27PM +0200, Christian Marangi wrote: > > Add LEDs definition example for qca8k Switch Family to describe how they > > should be defined for a correct usage. > > > > Signed-off-by: Christian Marangi > > --- > > .../devicetree/bindings/net/dsa/qca8k.yaml | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > > index 389892592aac..ad354864187a 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > > @@ -18,6 +18,8 @@ description: > > PHY it is connected to. In this config, an internal mdio-bus is registered and > > the MDIO master is used for communication. Mixed external and internal > > mdio-bus configurations are not supported by the hardware. > > + Each phy has at most 3 LEDs connected and can be declared > > + using the standard LEDs structure. > > > > properties: > > compatible: > > @@ -117,6 +119,7 @@ unevaluatedProperties: false > > examples: > > - | > > #include > > + #include > > > > mdio { > > #address-cells = <1>; > > @@ -226,6 +229,27 @@ examples: > > label = "lan1"; > > phy-mode = "internal"; > > phy-handle = <&internal_phy_port1>; > > + > > + leds { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + led@0 { > > + reg = <0>; > > + color = ; > > + function = LED_FUNCTION_LAN; > > + function-enumerator = <1>; > > + default-state = "keep"; > > + }; > > + > > + led@1 { > > + reg = <1>; > > + color = ; > > + function = LED_FUNCTION_LAN; > > + function-enumerator = <1>; > > Isn't function-enumerator supposed to be unique within a given > 'function'? > In the following example the output would be: - amber:lan-1 - white:lan-1 So in theory it's unique for the same color and function. Is it acceptable? Seems sane that there may be multiple color for the same function (and enum) > > + default-state = "keep"; > > + }; > > + }; > > }; > > > > port@2 { > > -- > > 2.39.2 > > -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel