Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 900E3C433DB for ; Fri, 15 Jan 2021 16:28:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 272BE238EB for ; Fri, 15 Jan 2021 16:28:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 272BE238EB Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.68428.122535 (Exim 4.92) (envelope-from ) id 1l0Rx6-0001ut-W0; Fri, 15 Jan 2021 16:27:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 68428.122535; Fri, 15 Jan 2021 16:27:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l0Rx6-0001um-T5; Fri, 15 Jan 2021 16:27:56 +0000 Received: by outflank-mailman (input) for mailman id 68428; Fri, 15 Jan 2021 16:27:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l0Rx5-0001ue-6M for xen-devel@lists.xenproject.org; Fri, 15 Jan 2021 16:27:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a9186ffb-d573-41c5-b2a0-4e00ee68dcd9; Fri, 15 Jan 2021 16:27:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5E175AC24; Fri, 15 Jan 2021 16:27:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9186ffb-d573-41c5-b2a0-4e00ee68dcd9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1610728073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SGHZ6OosIOy5jhqa78RE/kEt0JNaNffBu8fAcsN2rkE=; b=UF/HK/wGUy2G1z5Qcrg5g1EGmj4HsfEFNHgNBdq5RlW3LGOz8N2xFHCeMy4h/QmMvKW9c0 s3bAI5WLvFOQc5SgYovIjdYQ8T5yBbJbw6raZS9yUIa7BLMkF++WwLeT81RNb3c6YTMUpA tOeodoyyZwMKuxpvSSGcutEcm3hUlv0= Subject: Re: [PATCH v3 1/7] xen/gnttab: Rework resource acquisition From: Jan Beulich To: Andrew Cooper Cc: George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , Julien Grall , Paul Durrant , =?UTF-8?Q?Micha=c5=82_Leszczy=c5=84ski?= , Hubert Jasudowicz , Tamas K Lengyel , Xen-devel References: <20210112194841.1537-1-andrew.cooper3@citrix.com> <20210112194841.1537-2-andrew.cooper3@citrix.com> <7695c88b-0c25-1a1e-19d5-e0a81f2288b2@suse.com> Message-ID: <643c6eb7-c5a4-856e-bfc8-94501de3c42b@suse.com> Date: Fri, 15 Jan 2021 17:27:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <7695c88b-0c25-1a1e-19d5-e0a81f2288b2@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 15.01.2021 17:26, Jan Beulich wrote: > On 15.01.2021 17:03, Andrew Cooper wrote: >> On 15/01/2021 11:43, Jan Beulich wrote: >>>> + mfn_t tmp; >>>> + void **vaddrs; >>>> + int rc; >>>> + >>>> + /* Overflow checks */ >>>> + if ( frame + nr_frames < frame ) >>>> + return -EINVAL; >>>> + >>>> + tot_frames = frame + nr_frames; >>>> + if ( tot_frames != frame + nr_frames ) >>>> + return -EINVAL; >>> Can't these two be folded into >>> >>> unsigned int tot_frames = frame + nr_frames; >>> >>> if ( tot_frames < frame ) >>> return -EINVAL; >>> >>> ? Both truncation and wrapping look to be taken care of this >>> way. >> >> Not when frame is a multiple of 4G (or fractionally over, I think). > > How that? In this case any unsigned int value will be less than > frame. And in the 32-bit case the above becomes a simple overflow check. Jan