Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B753C76196 for ; Fri, 31 Mar 2023 11:14:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CC42485F7A; Fri, 31 Mar 2023 13:14:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="CxZigwhQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B1AEE85F7B; Fri, 31 Mar 2023 13:14:38 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6971F85F79 for ; Fri, 31 Mar 2023 13:14:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32VBESZa008481; Fri, 31 Mar 2023 06:14:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680261268; bh=A5sJLf1dINPJFLPSgbB1o3IZqLUQHqj1R6OLHUAY61U=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=CxZigwhQiUXNm/TynzQlQcM5yCXMCBphaOFBP7DniFFf7dj+rzuHqRqXyEzQ6lGPK aGeuDJuR00QrLPuCoDpWvJNHZx3w0UJuGAXO9qnIrXqXIvEuVUzx04MTqo8Ui0ZRKS bc7+arqILqxvH5jSbM0+Iwol5W15hDPbbjex2ik8= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32VBESYH114804 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 31 Mar 2023 06:14:28 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 31 Mar 2023 06:14:27 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 31 Mar 2023 06:14:27 -0500 Received: from [172.24.145.162] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32VBEP2l017599; Fri, 31 Mar 2023 06:14:25 -0500 Message-ID: <6461874e-4c95-038d-ee3f-0176759d25d4@ti.com> Date: Fri, 31 Mar 2023 16:44:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: WIP: Signing TI x509 certificates using binman To: Simon Glass CC: Vignesh Raghavendra , "Andrew F. Davis" , Roger Quadros , , Nishanth Menon , "Kumar, Udit" References: <5109d7ad-3d98-289f-9c2d-e8aafb9ab7f8@ti.com> Content-Language: en-US From: Neha Malcom Francis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon On 31/03/23 02:01, Simon Glass wrote: > Hi Neha, > > On Fri, 24 Mar 2023 at 22:28, Neha Malcom Francis wrote: >> >> Hi Simon, >> >> Before I roll out the entire series that works for packaging K3 >> bootloader images, wanted to get some reviews and comments regarding the >> implementation of the signing etype [1] . I believe I've taken into >> consideration what we've discussed earlier [2]. >> >> Let me know your thoughts. The tree is also WIP, and was mainly designed >> for testing the signing etype on two of the devices. I will add the >> remaining and refine the series based on the next comments. > > Yes this looks reasonable to me. For the openssl method, can you > create a new 'real' method and put the cert stuff in there instead of > using a 'custom' one? It seems to have a lot in common with what is > there. We should really have an internal cert-generator method in that > class, with other functions in that class doing appropriate things. I > am looking for code reuse here, as well as clear indication of what > the cert is for or does. So you're suggesting to include the config creation within the openssl btool, am I right? For example methods to generate a config, add section to a config, add extension to a section of a config... etc? I can take a look at implementing this if this is what you have suggested. If most of the cert is the same, you could > pass a dict for the CN stuff, perhaps? > > What is the taml for? It is hard to tell, from the example provided. Did you mean YAML? If so in the patch I linked, I don't think I had a example for that. Could you point out what exactly you're asking about? > > Do you have a .dts which shows the full image for a board? I think the > cert stuff looks right, but it's a bit hard to tell. Yes, in the same github link I have the whole tree [3] that contains DTBs for couple of the devices [4] and [5], please have a look and let me know (I might force push a few changes in the next couple of days, so better to look from the tree) > > When sending the patches please do do follow the function-commenting > style and make sure that it is clear what each arg means. E.g. I saw a > hash integer which I assume is used to pass 256 or 384 or 512 for sha > hashing. It should indicate the possible values / meaning in the arg. > In fact, in that case, it might be better to pass a string like > 'sha256'. Yes, you're right. Will address that when sending the patch series completely. > > Anyway, apart from my questions it seems good. > > Regards, > Simon > >> >> [1] >> https://github.com/nehamalcom/u-boot/commit/ea7413ed5864340bd6f01e704e8bdcc073a7896b#diff-efb03d61a324724c4f86bf42b45c4e4e614cab18e1b3184f63721d62280a11b5 >> >> [2] >> https://patchwork.ozlabs.org/project/uboot/patch/20230224120340.587786-1-n-francis@ti.com/ >> >> -- >> Thanking You >> Neha Malcom Francis [3] https://github.com/nehamalcom/u-boot/commits/ti-secure-functionality [4] https://github.com/nehamalcom/u-boot/commit/dda1f9caf436df59c576466f35262df90aa1c0af -- Thanking You Neha Malcom Francis