Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AC4C433E1 for ; Wed, 19 Aug 2020 09:12:45 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8F3C20738 for ; Wed, 19 Aug 2020 09:12:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8F3C20738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k8K96-0002r8-1c; Wed, 19 Aug 2020 09:12:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k8K95-0002r3-8J for xen-devel@lists.xenproject.org; Wed, 19 Aug 2020 09:12:35 +0000 X-Inumbo-ID: 495045af-1bb9-4b3c-a730-39483ff76115 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 495045af-1bb9-4b3c-a730-39483ff76115; Wed, 19 Aug 2020 09:12:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2ABABB6F8; Wed, 19 Aug 2020 09:12:57 +0000 (UTC) Subject: Re: [PATCH] x86/vpic: fix vpic_elcr_mask macro parameter usage To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Wei Liu References: <20200819090951.15374-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: <646958d3-e858-ae4e-dccc-c9a2eda1874c@suse.com> Date: Wed, 19 Aug 2020 11:12:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200819090951.15374-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 19.08.2020 11:09, Roger Pau Monne wrote: > vpic_elcr_mask wasn't using the v parameter, and instead worked > because in the context of the callers v would be vpic. Fix this by > correctly using the parameter. While there also remove the unneeded > casts to uint8_t and the ending semicolon. > > No functional change intended. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich