Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4482C433F5 for ; Fri, 22 Apr 2022 17:04:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C55B10E31B; Fri, 22 Apr 2022 17:04:46 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61EFD10E31B for ; Fri, 22 Apr 2022 17:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650647084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6QQiY2IuiN4KN2jf63+soXn8T3SQzl/mtR86RllPdFw=; b=Oe39dZiOroQsQYgcRu7XtmFmPDzak1+DgJy03Xqw/ild/qpp5WYrAC7jb+uEih3gqGW9a0 nmzPMroqcGnco+3W1IDemlbqpTSWollGxiuU859t7onLGCq/CwgyuDv5txqdGh2b+IZTdl dNA1PhXSUTLhLx1hDvSbyVxT4Y+5tUw= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-HXDN82YfND-rl6KkiClGAA-1; Fri, 22 Apr 2022 13:04:43 -0400 X-MC-Unique: HXDN82YfND-rl6KkiClGAA-1 Received: by mail-qv1-f72.google.com with SMTP id u19-20020ad449b3000000b004523cc11b95so1891789qvx.7 for ; Fri, 22 Apr 2022 10:04:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=6QQiY2IuiN4KN2jf63+soXn8T3SQzl/mtR86RllPdFw=; b=ssw0se9zUaiDc9aiyGriOtXZDJb/GerE2oApwvdizM0ezR/UwIVkcL/N9RFGp2l2sQ N17O6nyMT9eoDMbRxqO2w4NbuG4tvj1oFzW4R85Zw9l0HkCIPSgNv0JOV7OrIcj4VUzN wVJ8D913SDF8+Vx0Prxz6UP8q/oy//j/IwamPD1BD/5JExHDzqMeFqBwDdEdxo1MSuFE qvEm09b63Sffnwz7Fu59lfND5pHQoYbQbGlru7mqtlkJRqLnCBH1ynQG7B1HJuDG29dL gGYrDZOPrQ525XG1u98ou5B/t3BjvOrS0E7iJRPO3WXYr3KWjS4JhK/wKXGvwCOHXXH6 28rg== X-Gm-Message-State: AOAM530OWMtcKU6SKuqA4Ty2dHi/ZXrv9N2VO0gWkQIVNn6BxMCo3llQ xwgGT9psNRAH25dDNcxF0qfjNoE/jqnrLZQ0caMJljw29lP2mYckxpmXPXVU8hdDfUQIlOSL3/t s+CryNLaFM4LahPdCSuGk7IP5Jg== X-Received: by 2002:ad4:576b:0:b0:453:cc2c:e6f8 with SMTP id r11-20020ad4576b000000b00453cc2ce6f8mr2063753qvx.127.1650647082460; Fri, 22 Apr 2022 10:04:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrAx69KALPbKbVyDjA5XRoT5dp0gFMLLP0r0F4OF9bZ5kqdwOdUE0ru7J+zpV9RKzoq/K22w== X-Received: by 2002:ad4:576b:0:b0:453:cc2c:e6f8 with SMTP id r11-20020ad4576b000000b00453cc2ce6f8mr2063725qvx.127.1650647082234; Fri, 22 Apr 2022 10:04:42 -0700 (PDT) Received: from [192.168.8.138] (pool-71-126-244-162.bstnma.fios.verizon.net. [71.126.244.162]) by smtp.gmail.com with ESMTPSA id t67-20020ae9df46000000b006809a144ac1sm1137490qkf.99.2022.04.22.10.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 10:04:41 -0700 (PDT) Message-ID: <647ec060ec96fd8055344fcc466d890ed3bb147a.camel@redhat.com> From: Lyude Paul To: Tom Rix , bskeggs@redhat.com, kherbst@redhat.com, airlied@linux.ie, daniel@ffwll.ch Date: Fri, 22 Apr 2022 13:04:40 -0400 In-Reply-To: <20220421133028.724954-1-trix@redhat.com> References: <20220421133028.724954-1-trix@redhat.com> Organization: Red Hat Inc. User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [Nouveau] [PATCH] drm/nouveau/gsp: change gv100_gsp from global to static X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Reviewed-by: Lyude Paul Will push upstream in a moment On Thu, 2022-04-21 at 09:30 -0400, Tom Rix wrote: > Smatch reports this issue > gv100.c:46:1: warning: symbol 'gv100_gsp' was not declared. Should it be > static? > > gv100_gsp is only used in gv100.c so change its > storage-class specifier to static. > > Signed-off-by: Tom Rix > --- >  drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c > index 2ac7fc934c09..6c4ef62a746a 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c > @@ -42,7 +42,7 @@ gv100_gsp_nofw(struct nvkm_gsp *gsp, int ver, const struct > nvkm_gsp_fwif *fwif) >         return 0; >  } >   > -struct nvkm_gsp_fwif > +static struct nvkm_gsp_fwif >  gv100_gsp[] = { >         { -1, gv100_gsp_nofw, &gv100_gsp_flcn }, >         {} -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat