Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA66BC282CE for ; Wed, 13 Feb 2019 08:46:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96A43222C0 for ; Wed, 13 Feb 2019 08:46:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aEYr4I2J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96A43222C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i2se.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:Subject:From:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8CHa9VA4OGwJ4w2+O1EExWztEQBLD4NGIyG0g7xpJm8=; b=aEYr4I2JrteYzy rcs3KTMzJgXuwJ00Cb9SiNjpCnnQc5apuxgk6OzIFw0dBXDXpPsWUoY5nL0l1OkYzV/itw1bAHaYZ usp6J00AG1q+vhM36XNpKMDFUZXRZhibVqI5g+P2hhhrporJYgrvE0Oi7wvFnfFHYKuXnh/EfkCdx gVJ4InhOoY7gbe9f8HrSeJCaw9uDfYtkvhcAmkUyNDf/rIdFayaPqLQeUcC7PbOcpmFVP+cIjI6h+ ty2/maKiDFi5rtTbG4yC/j/sPjfJlhTaqWv4BnAn8sOErVgrGo6NlGX/KR6Qse2lv9Vt0MUVKiOZX +oEr1skU+cYj5PSW9aNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtqBS-0008WT-HP; Wed, 13 Feb 2019 08:46:22 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtqBP-0008Vw-Em; Wed, 13 Feb 2019 08:46:21 +0000 Received: from [192.168.178.52] ([109.104.49.86]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MUGNZ-1gSaGW1fRz-00REPa; Wed, 13 Feb 2019 09:46:11 +0100 From: Stefan Wahren Subject: [PATCH 2/2] soc: bcm: bcm2835-pm: Fix error paths of initialization. To: Eric Anholt , Florian Fainelli References: <20190213003324.15224-1-eric@anholt.net> <20190213003324.15224-2-eric@anholt.net> Message-ID: <648bbc3e-6690-9b05-cae5-bf81edbec74a@i2se.com> Date: Wed, 13 Feb 2019 09:46:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190213003324.15224-2-eric@anholt.net> Content-Language: en-US X-Provags-ID: V03:K1:sEMhSnRh5hyFnZBc9bt4wMupYNRokD4gOd4f09aNZ+HBKnI9lQr sOSekht1DM4xsdyxAAN6jQW1BfPPaxFs8nGlT/fVqbQxkqIkGlSjO0XmaVlHTGiQ+DhbPc+ XF4w4pOkS8LqynK9AKHO8vu9HLvtRWLmHaZ3aKddu0jr7VIJ7tAvqhZGW8m4i810YIz1B18 FdH0V5ZozjdGQDgfbpk/Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:skIvdwNlXJg=:v4/TVx3FrzN2DUUp7iDpii PgTZuA2vlVQ7cS8PX/qZucxTCT4UtqLdqXw2sWpDvLy53WHN++qsuAHpU3PgKRRowR4hpfVDz WynOBiHQueOGhjn9+exRFeKMGMbjDb8C5pdodrbTHl2vufSfeo5HAkqjrgRUnjpVlq9WWIgmA mp0Jyzjjy5EV9GlyvGcEU/V/NWkcGFVdC3SZHWLu8ktMWwQKQaEEVs1a0x+XlXr/gSqsgUXaz uG8kKRxetQ2A/EoIMpJCSH2etluF2kOsnot6vEXXuN48V0OpNZWSvgjkktPPDxXFu2YxEenyg shnbX8Vidg4ZetTQ1fs71ouTFw4SyKWRNz39elANKwTuo2mEb05Hqb0FBOQlBlTgndAqzuICW e5zOATHMUH220GLp6woReclDswoTVwGici4aGKUVRwkBRcGX3M9PkjseVu8g+MPvNF66eOn+M E3J5xo7LeUK5t2CyVKDYn4UFASaQkpf0lDPE+8HzkYUY6lwdeYDN3U74RpY3xDjp+kZy89DR+ TiJc98EX1yXvVdtWLklUV7R+7m/xH4hHqognU5yiRj7S7zp0/JVQr7dfjZ9M9b4Fm5FSSRQve sEwQp7DowUFFEoHWv8o0F8aST4JzRV4RUHNKwB0qFw8xjDGUa64BGK0ZsGt5b4H+FmmOgPUGy Vzoek82TJT3C99qcHM6/SyiZgxJDU2gzd7SymI5JIQTzfqDxPjn1xX0jOXaLudeRGtTq55Qrw s4ayiGNnpSazQXtIa6XRVJsHegQpKIEV5qzeTSfxA89/Lmbm+f7tJzJ6zyQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190213_004619_806044_BA34008F X-CRM114-Status: GOOD ( 19.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Eric, Am 13.02.19 um 01:33 schrieb Eric Anholt: > The clock driver may probe after ours and so we need to pass the > -EPROBE_DEFER out. Fix the other error path while we're here. > > Signed-off-by: Eric Anholt > Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.") > --- > drivers/soc/bcm/bcm2835-power.c | 30 +++++++++++++++++++++++++----- > 1 file changed, 25 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c > index 4a1b99b773c0..11f9469423f7 100644 > --- a/drivers/soc/bcm/bcm2835-power.c > +++ b/drivers/soc/bcm/bcm2835-power.c > @@ -485,7 +485,7 @@ static int bcm2835_power_pd_power_off(struct generic_pm_domain *domain) > } > } > > -static void > +static int > bcm2835_init_power_domain(struct bcm2835_power *power, > int pd_xlate_index, const char *name) > { > @@ -493,6 +493,12 @@ bcm2835_init_power_domain(struct bcm2835_power *power, > struct bcm2835_power_domain *dom = &power->domains[pd_xlate_index]; > > dom->clk = devm_clk_get(dev->parent, name); > + if (IS_ERR(dom->clk)) { > + int ret = PTR_ERR(dom->clk); > + > + if (ret == -EPROBE_DEFER) > + return ret; is it safe to proceed in the other error cases? Even it would be more consistent with clk_prepare_enable() to print an error here. > + } > > Thanks Stefan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel