Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3798CC3A5A7 for ; Thu, 8 Dec 2022 10:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YG3p2XVZYiX/kDT7dDvguRgv6d0TyL/Q5ASxKyP1Op0=; b=E8Oc3DzwmAQqmh cCfVTyCRR5+pjXRJEKf1pPdkuXKyCzw8fQPVYsK3zdESXm5yqq9pt6G5vxKmxICdTLvE9gJq4Vdvc s4lnqSiu+alGp0CzW5rFv7ebBtx1h0nTF9d0B/b5MWzbvQep7tBM2M+4m00XP94HQTxcwc2SrYiA+ 7yheHS6+P8xRyQfYo7LkaB0D55DuDntRB78gYzQVNGAxJwUD1HsxdHfqGkFIxrShid5QDfluah2NF 7lu4tod/LgNRJ5Hx7w6ht1v9Sgo2ftmoaV8eZ2BUx/YPowqu7sc648uw9TH+rgAAg4uxliLUm+1Eu P7oIxFQ9ZzNToaii2fOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3EaK-00DTte-Px; Thu, 08 Dec 2022 10:57:00 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3EaH-00DTj5-CT for linux-arm-kernel@lists.infradead.org; Thu, 08 Dec 2022 10:56:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670497017; x=1702033017; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=jZm84mXS2zwnbUgC6cdFKWsTsw/xZ4TYuKZBkJwd2Z0=; b=Ph4jOCddj856i9eldDtHjSRHbssNY0haYJH/5Xageqgbqqb0YOJ5qMe5 CrmTAZlRM5qjsg9ZoIENKW+UAthC+zYTDsFGbM2gyhuUG4rCNRXRl2cdD 14ZDaZOee01Vh2Lgsti9nDwhkAYnAZU0ts5WNFXxjyj0acuA4BTe9v3zh j/YMup0cq7ve6BEQftgz9mfTYti5AIZ9pRfr/jVgFT5Q04J8BIvyZulyY FyOh/7GK+JfQdvKFRMWAWhtD+5KIjFNbzySrEnUQZeHb5AFExMecQ+HCk FemesEhQwahKurHWtxv2ZPGwdozsBhg3md7KuqLjAOu4dEx+/BTa5iN2O A==; X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="192209365" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Dec 2022 03:56:50 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 8 Dec 2022 03:56:50 -0700 Received: from [10.12.72.78] (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Thu, 8 Dec 2022 03:56:48 -0700 Message-ID: <64c9bdaf-a138-a9bb-17dd-63ad96d2292b@microchip.com> Date: Thu, 8 Dec 2022 11:56:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] crypto: atmel: Add capability case for the 0x600 SHA and AES IP versions Content-Language: en-US To: Sergiu Moga , , , , CC: , , References: <20221207135953.136557-1-sergiu.moga@microchip.com> From: Nicolas Ferre Organization: microchip In-Reply-To: <20221207135953.136557-1-sergiu.moga@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221208_025657_506556_CB006C45 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/12/2022 at 14:59, Sergiu Moga wrote: > In order for the driver to be made aware of the capabilities of the SHA > and AES IP versions 0x600 , such as those present on the SAM9X60 SoC's, > add a corresponding switch case to the capability method of the respective > drivers. Without this, besides the capabilities not being correctly set, > the self tests may hang since the driver is endlessly waiting for a > completion to be set by a never occurring DMA interrupt handler. > > Signed-off-by: Sergiu Moga Acked-by: Nicolas Ferre Thanks Sergiu, best regards, Nicolas > --- > drivers/crypto/atmel-aes.c | 1 + > drivers/crypto/atmel-sha.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c > index 886bf258544c..063394cfa874 100644 > --- a/drivers/crypto/atmel-aes.c > +++ b/drivers/crypto/atmel-aes.c > @@ -2510,6 +2510,7 @@ static void atmel_aes_get_cap(struct atmel_aes_dev *dd) > /* keep only major version number */ > switch (dd->hw_version & 0xff0) { > case 0x700: > + case 0x600: > case 0x500: > dd->caps.has_dualbuff = 1; > dd->caps.has_cfb64 = 1; > diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c > index ca4b01926d1b..00be792e605c 100644 > --- a/drivers/crypto/atmel-sha.c > +++ b/drivers/crypto/atmel-sha.c > @@ -2509,6 +2509,7 @@ static void atmel_sha_get_cap(struct atmel_sha_dev *dd) > /* keep only major version number */ > switch (dd->hw_version & 0xff0) { > case 0x700: > + case 0x600: > case 0x510: > dd->caps.has_dma = 1; > dd->caps.has_dualbuff = 1; -- Nicolas Ferre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel