From: "flichtenheld (Code Review)" Date: Thu, 30 Apr 2026 12:47:53 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <64e364bfbe180d8e394b4739785972e6ed743e0b-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="QLUicTr3Y24="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: dns-scripts: Fix dnssec values in comments and Copyright statement fo... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --QLUicTr3Y24= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1645?usp=3Demail to review the following change. Change subject: dns-scripts: Fix dnssec values in comments and Copyright st= atement format ...................................................................... dns-scripts: Fix dnssec values in comments and Copyright statement format - Fix the example value of dnssec to an actual valid one - Fix the formatting of the Copyright statements to be consistent with all other files in the project Change-Id: Id6832e3f56420debc8b19d0144d53ca41abb678b Signed-off-by: Frank Lichtenheld --- M distro/dns-scripts/haikuos_file-dns-updown.sh M distro/dns-scripts/macos-dns-updown.sh M distro/dns-scripts/openresolv-dns-updown.sh M distro/dns-scripts/resolvconf_file-dns-updown.sh M distro/dns-scripts/systemd-dns-updown.sh 5 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/45/1645/1 diff --git a/distro/dns-scripts/haikuos_file-dns-updown.sh b/distro/dns-scr= ipts/haikuos_file-dns-updown.sh index 6da0954..e19b2b7 100644 --- a/distro/dns-scripts/haikuos_file-dns-updown.sh +++ b/distro/dns-scripts/haikuos_file-dns-updown.sh @@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying Haiku OS resolv.conf -# (C) Copyright 2024 OpenVPN Inc +# Copyright (C) 2024-2026 OpenVPN Inc # # SPDX-License-Identifier: BSD-2-Clause # @@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # diff --git a/distro/dns-scripts/macos-dns-updown.sh b/distro/dns-scripts/ma= cos-dns-updown.sh index fb17b2b0..fccc6b5 100644 --- a/distro/dns-scripts/macos-dns-updown.sh +++ b/distro/dns-scripts/macos-dns-updown.sh @@ -2,7 +2,7 @@ # # dns-updown - add/remove openvpn provided DNS information # -# (C) Copyright 2025 OpenVPN Inc +# Copyright (C) 2025-2026 OpenVPN Inc # # SPDX-License-Identifier: BSD-2-Clause # @@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # diff --git a/distro/dns-scripts/openresolv-dns-updown.sh b/distro/dns-scrip= ts/openresolv-dns-updown.sh index 1404819..4aca99f 100644 --- a/distro/dns-scripts/openresolv-dns-updown.sh +++ b/distro/dns-scripts/openresolv-dns-updown.sh @@ -1,8 +1,8 @@ #!/bin/sh # # Simple OpenVPN up/down script for openresolv integration -# (C) Copyright 2016 Baptiste Daroussin -# 2024 OpenVPN Inc +# Copyright (C) 2016 Baptiste Daroussin +# Copyright (C) 2024-2026 OpenVPN Inc # # SPDX-License-Identifier: BSD-2-Clause # @@ -22,7 +22,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # diff --git a/distro/dns-scripts/resolvconf_file-dns-updown.sh b/distro/dns-= scripts/resolvconf_file-dns-updown.sh index 70872c7..8d23ed6 100644 --- a/distro/dns-scripts/resolvconf_file-dns-updown.sh +++ b/distro/dns-scripts/resolvconf_file-dns-updown.sh @@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying /etc/resolv.conf -# (C) Copyright 2024 OpenVPN Inc +# Copyright (C) 2024-2026 OpenVPN Inc # # SPDX-License-Identifier: BSD-2-Clause # @@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # diff --git a/distro/dns-scripts/systemd-dns-updown.sh b/distro/dns-scripts/= systemd-dns-updown.sh index f91cde6..553056b 100644 --- a/distro/dns-scripts/systemd-dns-updown.sh +++ b/distro/dns-scripts/systemd-dns-updown.sh @@ -29,7 +29,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1645?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id6832e3f56420debc8b19d0144d53ca41abb678b Gerrit-Change-Number: 1645 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --QLUicTr3Y24= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

dns-scripts: Fix dnssec values in comments =
and Copyright statement format

- Fix the example value of dnssec to = an actual valid one
- Fix the formatting of the Copyright statements to = be
consistent with all other files in the project

Change-Id: Id= 6832e3f56420debc8b19d0144d53ca41abb678b
Signed-off-by: Frank Lichtenheld= <frank@...2641...>
---
M distro/dns-scripts/haikuos_file-dns-u= pdown.sh
M distro/dns-scripts/macos-dns-updown.sh
M distro/dns-script= s/openresolv-dns-updown.sh
M distro/dns-scripts/resolvconf_file-dns-updo= wn.sh
M distro/dns-scripts/systemd-dns-updown.sh
5 files changed, 10 = insertions(+), 10 deletions(-)

git pull ssh://ge=
rrit.openvpn.net:29418/openvpn refs/changes/45/1645/1
diff --git a/=
distro/dns-scripts/haikuos_file-dns-updown.sh b/distro/dns-scripts/haikuos_=
file-dns-updown.sh
index 6da0954..e19b2b7 100644
= --- a/distro/dns-scripts/haikuos_file-dns-updown.sh
+= ++ b/distro/dns-scripts/haikuos_file-dns-updown.sh
@@ -1,7 = +1,7 @@
#!/bin/sh
#
# Si= mple OpenVPN up/down script for modifying Haiku OS resolv.conf
-# (C) Copyright 2024 OpenVPN Inc &= lt;sales@...515...>
-# dns_server_1_dnssec true
+# dns_server_1_dnssec = yes
# dns_server_1_transport DoH
# dn= s_server_1_sni dns.mycorp.in
#
diff --git = a/distro/dns-scripts/macos-dns-updown.sh b/distro/dns-scripts/macos-dns-upd= own.sh
index fb17b2b0..fccc6b5 100644
--- a= /distro/dns-scripts/macos-dns-updown.sh
+++ b/distro/dns-sc= ripts/macos-dns-updown.sh
@@ -2,7 +2,7 @@
= #
# dns-updown - add/remove openvpn provided DNS informati= on
#
-= # (C) Copyright 2025 OpenVPN Inc <sales@...515...>
+# Copyright (C) 2025-2026 OpenVPN Inc = <sales@...515...>
#
# SPDX-License-= Identifier: BSD-2-Clause
#
@@ -21,7 +21,7 = @@
# dns_server_1_port_2 53
# dns_ser= ver_1_resolve_domain_1 mycorp.in
# dns_server_1_resolve_= domain_2 eu.mycorp.com
= -# dns_server_1_dnssec true
+# dns_server_1_dnssec yes
# dns_server_1_tra= nsport DoH
# dns_server_1_sni dns.mycorp.in
#

diff --git a/distro/dns-scripts/openresolv-dns-updow= n.sh b/distro/dns-scripts/openresolv-dns-updown.sh
index 14= 04819..4aca99f 100644
--- a/distro/dns-scripts/openresolv-d= ns-updown.sh
+++ b/distro/dns-scripts/openresolv-dns-updown= .sh
@@ -1,8 +1,8 @@
#!/bin/sh
#
# Simple OpenVPN up/down script for openresolv inte= gration
-# (C) Copyrigh= t 2016 Baptiste Daroussin
-# 2024 OpenVPN Inc <sales@...515...>
+# Copyright (C) 2016 Baptiste Daro= ussin
+# Copyright (C= ) 2024-2026 OpenVPN Inc <sales@...515...>
# # SPDX-License-Identifier: BSD-2-Clause
#<= br>@@ -22,7 +22,7 @@
# dns_server_1_port_2 53

# dns_server_1_resolve_domain_1 mycorp.in
#= dns_server_1_resolve_domain_2 eu.mycorp.com
-# dns_server_1_dnssec true
+# dns_server_1_dnssec yes
# dns_server_1_transport DoH
# dns_server_1_sni dn= s.mycorp.in
#
diff --git a/distro/dns-scri= pts/resolvconf_file-dns-updown.sh b/distro/dns-scripts/resolvconf_file-dns-= updown.sh
index 70872c7..8d23ed6 100644
---= a/distro/dns-scripts/resolvconf_file-dns-updown.sh
+++ b/d= istro/dns-scripts/resolvconf_file-dns-updown.sh
@@ -1,7 +1,= 7 @@
#!/bin/sh
#
# Simpl= e OpenVPN up/down script for modifying /etc/resolv.conf
-# (C) Copyright 2024 OpenVPN Inc <sale= s@...515...>
+# Co= pyright (C) 2024-2026 OpenVPN Inc <sales@...515...>
= #
# SPDX-License-Identifier: BSD-2-Clause
= #
@@ -21,7 +21,7 @@
# dns_server_1_port= _2 53
# dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com
-# dns_server_1_dnssec true
<= span style=3D"color: hsl(120, 100%, 40%);">+# dns_server_1_dnssec yes

# dns_server_1_transport DoH
# dns_serve= r_1_sni dns.mycorp.in
#
diff --git a/distr= o/dns-scripts/systemd-dns-updown.sh b/distro/dns-scripts/systemd-dns-updown= .sh
index f91cde6..553056b 100644
--- a/dis= tro/dns-scripts/systemd-dns-updown.sh
+++ b/distro/dns-scri= pts/systemd-dns-updown.sh
@@ -29,7 +29,7 @@
# dns_server_1_port_2 53
# dns_server_1_resolve_doma= in_1 mycorp.in
# dns_server_1_resolve_domain_2 eu.mycorp= .com
-# dns_server_1_= dnssec true
+# dns_= server_1_dnssec yes
# dns_server_1_transport DoH<= br> # dns_server_1_sni dns.mycorp.in
#
<= span>

To view, visit change 1645. To unsubscribe, or for hel= p writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id6832e3f56420debc8b19d0144d= 53ca41abb678b
Gerrit-Change-Number: 1645
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --QLUicTr3Y24=--