Content-Type: multipart/mixed; boundary="===============0820059987383399689==" MIME-Version: 1.0 From: Josua Mayer To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 2/3] net: phy: adin: add support for clock output Date: Wed, 27 Apr 2022 10:06:40 +0300 Message-ID: <651b6fce-cf2a-439f-7454-533bf830a048@solid-run.com> In-Reply-To: <202204211324.qgcPMycQ-lkp@intel.com> List-Id: --===============0820059987383399689== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable \o/ I am going to fix this by using NULL in v3. Is there any other feedback I should take into account on this patch? - Josua Mayer Am 21.04.22 um 09:45 schrieb kernel test robot: > Hi Josua, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on robh/for-next] > [also build test WARNING on net/master net-next/master v5.18-rc3 next-202= 20420] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/intel-lab-lkp/linux/commits/Josua-Mayer/dt-bin= dings-net-adin-document-phy-clock-output-properties/20220419-192719 > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git fo= r-next > config: openrisc-randconfig-s032-20220420 (https://download.01.org/0day-c= i/archive/20220421/202204211324.qgcPMycQ-lkp(a)intel.com/config) > compiler: or1k-linux-gcc (GCC) 11.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sb= in/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.4-dirty > # https://github.com/intel-lab-lkp/linux/commit/74d856f1c89a6534= fd58889f20ad4b481b8191c9 > git remote add linux-review https://github.com/intel-lab-lkp/lin= ux > git fetch --no-tags linux-review Josua-Mayer/dt-bindings-net-adi= n-document-phy-clock-output-properties/20220419-192719 > git checkout 74d856f1c89a6534fd58889f20ad4b481b8191c9 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cr= oss C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=3Dbuild_dir ARCH= =3Dopenrisc SHELL=3D/bin/bash drivers/net/phy/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > > sparse warnings: (new ones prefixed by >>) >>> drivers/net/phy/adin.c:448:27: sparse: sparse: Using plain integer as N= ULL pointer > vim +448 drivers/net/phy/adin.c > > 444 = > 445 static int adin_config_clk_out(struct phy_device *phydev) > 446 { > 447 struct device *dev =3D &phydev->mdio.dev; > > 448 const char *val =3D 0; > 449 u8 sel =3D 0; > 450 = > 451 device_property_read_string(dev, "adi,phy-output-clock", &val); > 452 if(!val) { > 453 /* property not present, do not enable GP_CLK pin */ > 454 } else if(strcmp(val, "25mhz-reference") =3D=3D 0) { > 455 sel |=3D ADIN1300_GE_CLK_CFG_25; > 456 } else if(strcmp(val, "125mhz-free-running") =3D=3D 0) { > 457 sel |=3D ADIN1300_GE_CLK_CFG_FREE_125; > 458 } else if(strcmp(val, "125mhz-recovered") =3D=3D 0) { > 459 sel |=3D ADIN1300_GE_CLK_CFG_RCVR_125; > 460 } else if(strcmp(val, "adaptive-free-running") =3D=3D 0) { > 461 sel |=3D ADIN1300_GE_CLK_CFG_HRT_FREE; > 462 } else if(strcmp(val, "adaptive-recovered") =3D=3D 0) { > 463 sel |=3D ADIN1300_GE_CLK_CFG_HRT_RCVR; > 464 } else { > 465 phydev_err(phydev, "invalid adi,phy-output-clock\n"); > 466 return -EINVAL; > 467 } > 468 = > 469 if(device_property_read_bool(dev, "adi,phy-output-reference-cloc= k")) > 470 sel |=3D ADIN1300_GE_CLK_CFG_REF_EN; > 471 = > 472 return phy_modify_mmd(phydev, MDIO_MMD_VEND1, ADIN1300_GE_CLK_CF= G_REG, > 473 ADIN1300_GE_CLK_CFG_MASK, sel); > 474 } > 475 = > --===============0820059987383399689==--