Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219F6C05027 for ; Fri, 17 Feb 2023 21:17:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BE656B0072; Fri, 17 Feb 2023 16:17:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66EC26B0074; Fri, 17 Feb 2023 16:17:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5358A6B0075; Fri, 17 Feb 2023 16:17:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4234F6B0072 for ; Fri, 17 Feb 2023 16:17:03 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D371E160552 for ; Fri, 17 Feb 2023 21:17:02 +0000 (UTC) X-FDA: 80478043884.27.E552B54 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 0B1B618000C for ; Fri, 17 Feb 2023 21:17:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MkWHFCDF; spf=pass (imf16.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676668621; a=rsa-sha256; cv=none; b=8nixcrxyRHrOr9KqdYPiemZ/Rli4KpMebWSTxxdAOWcCBJrHIvJ5ZrGD4jqNUCB41+ooXo 0dLy7CM5SGPB9XQTetI49REz2Ol1L5RQPaqsG7lkAmIonQsRgcK+/eLtXeM7oNX+wFDI7I +Odlg5bjqUsx7PA6kcK2IBjKwjFiHCM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MkWHFCDF; spf=pass (imf16.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676668621; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U58nb+DEF8GEy813UGwea6K+4QQ4/Qwsx/KnDbNVFig=; b=eo84iAW1i/uo1bJDUBvvDVb3GAQRIaoZ+nLbqw5Qd/A+OQshJN1wLxNwfsdI+eqrUOw4WL 1H6aMPZDmlcWMu7OxiEO5++lQvVROA/fpVafZz8/xyVPU/dvFhD4LXnS1qwppUblANNYA/ 9ef0rLD/CqCFOKnC5lxkNiAdq5zGSYA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676668620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U58nb+DEF8GEy813UGwea6K+4QQ4/Qwsx/KnDbNVFig=; b=MkWHFCDF2dD1OOHzP5bZ9abSDrrm4RggNxMge2UZfGdbxye+MSnCtUR/sv/Kg1uJlyd+aR Xgds2zvn7oEjqc9Q3LIBakl0iDgyhz81ghkU3L37+EiGgzpR/6DBqjruMOpS+cAeXFrFVF wqpYot99uZihVc4nsjrDtcxOjcpHxGE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-CF_ujmaLOvCX2kcLbvELXg-1; Fri, 17 Feb 2023 16:16:57 -0500 X-MC-Unique: CF_ujmaLOvCX2kcLbvELXg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 577CF1871D94; Fri, 17 Feb 2023 21:16:56 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2CA71121314; Fri, 17 Feb 2023 21:16:53 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <87a61ckowk.fsf@oc8242746057.ibm.com> References: <87a61ckowk.fsf@oc8242746057.ibm.com> To: Alexander Egorenkov Cc: dhowells@redhat.com, axboe@kernel.dk, david@redhat.com, hch@infradead.org, hch@lst.de, hdanton@sina.com, jack@suse.cz, jgg@nvidia.com, jhubbard@nvidia.com, jlayton@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, logang@deltatee.com, viro@zeniv.linux.org.uk, willy@infradead.org, Marc Hartmayer Subject: Re: [PATCH v14 08/17] splice: Do splice read from a file without using ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <654864.1676668613.1@warthog.procyon.org.uk> Date: Fri, 17 Feb 2023 21:16:53 +0000 Message-ID: <654865.1676668613@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspam-User: X-Rspamd-Queue-Id: 0B1B618000C X-Rspamd-Server: rspam01 X-Stat-Signature: 5e85sa8te3a6sch97wrjienuw4sf9qx6 X-HE-Tag: 1676668620-809291 X-HE-Meta: U2FsdGVkX183vatQryr/R28Xkru1Ldp3vX7x2vQaAxP54AaQrQktynt/BrDe1D7m6POUeEawg9du0OSVQsLcKAZLEwbKSpRfkR535B+qYLXg2BRT5s0iwASCO8F6Y/CCcAaKJncg4iAShdODsvndcu9oHdLIpAQ9oW8KdZM3KbsDN3tj+C2t9AOTYRguySsaFsB91j+cxVhEwwN7C67VRdZ+FHNDuQaB4FQ26r3K17HclBgPOwV0fSXL9PoNUZkbBqrbgyhGYP5C7g085SyQocI2FrVJjldZX0Wv945+sw4HdZmJYIlYReZQ0WN8GzJJxn6yHAYDXT5eSbNnLF91zR8zKvRYtdlxpzWaEEaLwqmtWOMgSRi5Hx/+FtmgSIKVwMz37Fg6rvrvOYncIy3L79Fpz2G84F4ZvAQr8bGXZtigYIIWk4aLFqNnjXCEUiGya46nkmzqMOQxYpZxYPYMOf/8CB5KQ1hn32roZgghruRIBecs5rO2XHDB0yYuD9AEq+MAXRfHJ095QSm9DySnboTQeDfscQ95Dy4wpDhM4IFaZ+uvXypfulGTrI7AQWyk/hREX/KcBZ8LBeO11YMrm+3fNqZ3ejsA7wfLWrTv6CFOP2c+sG5Q1zgBPwhVy1hkPQxYvBCsqHbwe2t8f5A0JjIflwV02jbtW2UQ5SRm/OY2SL9EMddcV3oWFBXa+LMo58R/5plcxsWCIEsI2afaTplQwOXLHiprxsyPyERkKNNhThpOsUK7A+ZpU+XPoIyDRF7mnKFISsJRauP5U0lAic7hDI2CTu1sK9i0h0WhjdlQ5Kvbip67kxAasuFTcjN/GGiGtou7z+9d0iwj91b0GEV4ZZIjN66e7CDnlmtuwuctsfn8TWIk/aURvTDHFSKZ5MauB+MMjHYBb35m5zXAgLU6KMFhQtCZrA7hqOugDPBN7YQditU1/woJMvg0kb/xvT83PhPgcp4I/cmexlM XzpPKIX0 w0G/ndd0vA8lv42Qicu3ctK3PqEpR7cgecfyQUt0O+NY6YEE9OI76p1a9nrdfPoImqRSRm96FMx0h5LXPKBBaPKlWOHSUay0xW0FArKSnovcUp69M9B7ueqE3+2u1DjoSmJAPsHweoZYH38BYTL6RDt30unQgUFhV4szkXms9DGDigZZA+XTr+at3JaeiFKNJEXlxqks5fGBLbXxjFwQlOzD/FIiNPyoz2M7u3Cpe8aY3QZZeKAiB2zfnUYXEw/Tx1b42xSk/3TfC86OjbuWY0g/2tzGka70wPeD7YY7helQQJG3YASNddwPung== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Alexander Egorenkov wrote: > Subject: Re: [PATCH v14 08/17] splice: Do splice read from a file without > using ITER_PIPE Well, I can reproduce it. Putting a printks in generic_file_splice_read(), direct_splice_read() and filemap_splice_read(), however, seems to show that it isn't using any of those functions; nor can I see any sign of a splice syscall in a strace:-/ David