Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A6DD38BF9E for ; Thu, 28 May 2026 08:57:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779958658; cv=none; b=bCMkrMOd5TTVzlEU07iEwxKAgiv/wMEJkipNpC9MQUS8gQgBUTibVOUfzXYiEy9vzmaq2r9FDN6u5eNQnwoS1WVl9ohGctbl/pnAWqNfBy7Q2sI7ZASY3z9yZj0If4jKfPIdDGw4TdpJ0sKdiJQuPQEH63L0+57F3C7hZAPKlXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779958658; c=relaxed/simple; bh=QP7m0lUJAg867agC282iNM6xu3YaGTEZOn7mkAuYOcM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ZlSdcixKgXX5gg1TPsocWJWI7BkLGefkH0Ubwe9issYKz203oitSV0qYxSoiqt0sJm+kpWo4Ia7ZKyIWRRb7pqgS1YY6SMFFvkNOGEj0Ud/NYe+vPY4qCzCkUp/m1A17EusSwY46/oQ0qYlHRjeFTpsdpX0189dCxpqI6s3EBl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y1zexwUO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y1zexwUO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48CCE1F00A3A; Thu, 28 May 2026 08:57:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779958657; bh=kOzeMDqxfTBaApn+cYgpJWKy4aDbKIJg8CHhRrNZ+0g=; h=Date:Subject:To:References:From:In-Reply-To; b=Y1zexwUOC+jSyQWxOrldjkP26F+lTstillbeIBEviEcOSWiV5k9zXtHFEDeIw1nHN siushPZMpxhbCUvZRd4YDPZ08LRPf2f/Z//MhmplZWflw3cOsBiKplWWS/xChLdVNu Vd3mgvOMgR//ZBGXl5agUstNA5FaNhlfPtv8d0P6Iy+dtkYgbIUPdLlCeaQqnq/5Mg bcX6xFP/yIXDS7E0WUAtIty1n5JJoyQ4/b5OpR7ZMKiNI0sCVTF7uahT07n2Y9xsKH tnnwguOTFXhKwFXajqHRqSUNY+ciYQNTy/FFKCkr1WYXxiTCMZGQnXgiYMnPYRS5ni tlBkpgzs/DKfg== Message-ID: <6605c5c2-6d2b-4e3f-a863-9fd273f8146b@kernel.org> Date: Thu, 28 May 2026 18:57:33 +1000 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v9 mptcp-next 6/6] mptcp: let the retrans scheduler do its job. Content-Language: fr To: Paolo Abeni , mptcp@lists.linux.dev References: From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Paolo, On 28/05/2026 17:45, Paolo Abeni wrote: > 5/27/26 12:45 PM, Paolo Abeni wrote: >> Currently the MPTCP core enforces that when MPTCP-level retrans timer >> fires, at most a single dfrag is retransmitted. If some corner-cases it >> may be necessary retransmit multiple dfrags, and the MPTCP socket will >> need to wait multiple retrans timeout to accomplish that. >> >> Remove the mentioned constraint, allowing to transmit multiple dfrags per >> retrans period, as long as the scheduler keeps selecting subflows for >> retransmissions and pending data is available in the rtx queue. >> The default scheduler will transmit a dfrag per available subflow. >> >> Signed-off-by: Paolo Abeni > > Sashiko concerns on this patch is real, and a new revision is needed. > @Matttbe: could you please apply patches 1-4, as they makes sense as a > whole? I'll resubmit a new version for the last 2. Patch 5 is correct, > but makes no sense without this one. Just did a quick review (I have a comment on patch 4), and applied patches 1-4: New patches for t/upstream-net and t/upstream: - e1da5203df71: mptcp: allow subflow rcv wnd to shrink - Results: 9ed1e5bcaf67..9f3fb817e1a6 (export-net) - Results: c154734ef126..b0745f4933ef (export) New patches for t/upstream: - acd6981b76f5: mptcp: explicitly drop over memory limits - 152803991ff0: mptcp: enforce hard limit on backlog flushing - 58f9ba52dd21: mptcp: implemented OoO queue pruning - Results: b0745f4933ef..e439b5a4647e (export) Tests are now in progress: - export-net: https://github.com/multipath-tcp/mptcp_net-next/commit/b581e1e5e4658bbef17e336e94acea9a7062244c/checks - export: https://github.com/multipath-tcp/mptcp_net-next/commit/6394b9805eeb481113927da4d259c2798685114a/checks Cheers, Matt -- Sponsored by the NGI0 Core fund.