From: "cron2 (Code Review)" Date: Wed, 13 Dec 2023 17:42:09 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <66629491eb756ff36a31e0661039d61e9ef2bf15-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="1tm7MQQA4YM="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --1tm7MQQA4YM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/460?usp=3Demail ) Change subject: Check PRF availability on initialisation and add --force-tl= s-key-material-export ...................................................................... Patch Set 7: Code-Review-2 (2 comments) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/336c9224_c681507d : PS5, Line 1841: return false; > Done done for "(RFC 5705)support", not done for "thisserver" (first line). File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/850dc22b_4f3310f4 : PS5, Line 3649: "by TLS library. Your system does not support t= his calculation " the change v5->v7 brought in a new whitespace error here, "(FIPS 140-2)forb= ids". -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee6ca89c7e86c70 Gerrit-Change-Number: 460 Gerrit-PatchSet: 7 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 13 Dec 2023 17:42:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --1tm7MQQA4YM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 7:Code-Review -2=

Vi= ew Change

2 comments:

  • File src/openvpn/multi.c:

  • Patch Set #5, Line 1841:= return false;<= /code>

    Done

    done for "(RFC 5705)support", not done= for "thisserver" (first line).

  • File src/openvpn/options.c:

    • Patch Set #5, Line 3649: "by TLS library. Your= system does not support this calculation "

      the change v5->v7 brought in = a new whitespace error here, "(FIPS 140-2)forbids".

    =
  • To view, visit change 460. To unsubscribe, or for help writing mail= filters, visit settings= .

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee= 6ca89c7e86c70
    Gerrit-Change-Number: 460
    Gerrit-PatchSet: 7
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Wed, 13 Dec 2023 17:42:09= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: plaisthos <arne-openvp= n@...1227...>
    Comment-In-Reply-To: cron2 <gert@...1296...= >
    Gerrit-MessageType: comment
    --1tm7MQQA4YM=--