From: "plaisthos (Code Review)"
Date: Fri, 27 Dec 2024 18:17:30 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641..., lstipakov@...277...
Message-ID: <6669592b6578fa0cf2a118a78dd4dbfeb88358dd-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="HWyPC96NYFw="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add methods to
read/write packet ids for epoch data
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , stipa , openvpn-devel
--HWyPC96NYFw=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, stipa.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/803?usp=3Demail )
Change subject: Add methods to read/write packet ids for epoch data
......................................................................
Patch Set 8:
(3 comments)
File src/openvpn/packet_id.h:
http://gerrit.openvpn.net/c/openvpn/+/803/comment/f34723d4_5781004e :
PS8, Line 49: /** Maks of the bits that make out the epoch in the packet co=
unter */
> "Maks" -> "Mask". [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/803/comment/6fc94b17_3cb2fa5b :
PS8, Line 333: * @param buf buffer to write the packet id/epcoh to
> "epoch"
Done
File src/openvpn/packet_id.c:
http://gerrit.openvpn.net/c/openvpn/+/803/comment/3a7675bb_c3f00413 :
PS8, Line 684: * integer contain our counter but the upper two bytes a=
re always 0 */
> This is confusing. [=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5
Gerrit-Change-Number: 803
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-CC: stipa
Gerrit-Attention: flichtenheld
Gerrit-Attention: stipa
Gerrit-Comment-Date: Fri, 27 Dec 2024 18:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--HWyPC96NYFw=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, stipa.
View C=
hange
3 comments:
Done
Patch S=
et #8, Line 333: * @pa=
ram buf buffer to write the packet id/epcoh to
=
"epoch"
Done
File src/openvpn/packet_id.c:
To view, visit change 803. To unsubscribe, or for hel=
p writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bc=
d0560b67a07b5
Gerrit-Change-Number: 803
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <=
/div>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Fri, 27 Dec 2024 18:17:30=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--HWyPC96NYFw=--