Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB3C4ECAAD8 for ; Wed, 21 Sep 2022 11:02:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D649284910; Wed, 21 Sep 2022 13:02:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="TaUJGZjN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 470E384A6F; Wed, 21 Sep 2022 13:02:13 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2049.outbound.protection.outlook.com [40.107.244.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 50B0484839 for ; Wed, 21 Sep 2022 13:02:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=daGTOYhJ8CUYWYPkr+UIv+PUpNWSigXrtjkqixmH/aEdECjD4PzBMyUpk3Ip0Bq8Googd1kColx0TuOnIz6BjO/+OeHCrDsqv+WPo4kBQXW+IO9z0t5NqyAhV2UqtZj52SsD230m5yOP65D0Nw/7I+/pQg0elo7HUXWKiha3kn4VnlvMC2q0vnm4/k1fmhF0y//qDTIrAmeec8szaZHlQxhwbWiIkh/nswIr9q/u/UVtLQo+32NGC3xaaKYSnfiReV7ViNnyCXcZxoo9GtSNYcppjxUIIosVXZkEDp1UH+M6Xlrd4E2bAeLCJlwDn2QIYCHplgg5utCjq5f43f8NZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PWktBYgTT2Ei3dlKVTFUeI69vkF/Yg7Q9hlttLgAhxU=; b=GHmFHh4WOC9wPsXnpqwgAaffsr9w5l7hTIQvQi7so1ka9ZzS+H3JGFsMDg4E4Qkwc1f/Y74sCDYKyJabWG8dvQxoDnpJGYoFtPUOuNmJ6jVgqN0Tmk6b22UQ2AhYIN+IHEoEvJpMu5cmI1JbumjCeGi/MqGw7dsUIPiBYphj0ZXNz2GnVPKJOj5zcL1FUAVCcwgBmKvBzSR5yUrvTews3lKa+2fK8kolfwguZtVw7zeU4VAKHVR7PLZAVAkEzbFyOe+vFyGcJ+/JDy9BEyGnD/M7xsRy+39Nyw/lz7qUgFwT/fgWy8GId708HC0swc2Hm3j3ajXCqO0HLBe9o5tyeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=thorsis.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWktBYgTT2Ei3dlKVTFUeI69vkF/Yg7Q9hlttLgAhxU=; b=TaUJGZjNS76V8YAiTn4u5Nckaz6IAtdUlAInma5HAwN43KfLmwoM3iSfw91p9Me61FLD0BEgyDIPobEUenbFXcmUujY08Bd/i2WpO4WueiciBGPEFKoiWzz3oDB48Ibsdlbq/uREO/OYkdoA4OdniUq1viEhnuGi8aOT4Lpt9/w= Received: from MW4PR02CA0004.namprd02.prod.outlook.com (2603:10b6:303:16d::19) by SN7PR12MB6670.namprd12.prod.outlook.com (2603:10b6:806:26e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Wed, 21 Sep 2022 11:02:06 +0000 Received: from CO1NAM11FT015.eop-nam11.prod.protection.outlook.com (2603:10b6:303:16d:cafe::99) by MW4PR02CA0004.outlook.office365.com (2603:10b6:303:16d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 11:02:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT015.mail.protection.outlook.com (10.13.175.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 11:02:05 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 21 Sep 2022 06:02:04 -0500 Message-ID: <66713212-246d-d058-eca2-8a4f496728dc@amd.com> Date: Wed, 21 Sep 2022 13:02:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH 1/7] fpga: altera: Use logging feature instead of FPGA_DEBUG Content-Language: en-US To: Alexander Dahl , References: <20220919103912.26554-1-ada@thorsis.com> <20220919103912.26554-2-ada@thorsis.com> From: Michal Simek In-Reply-To: <20220919103912.26554-2-ada@thorsis.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT015:EE_|SN7PR12MB6670:EE_ X-MS-Office365-Filtering-Correlation-Id: fa703ac7-a446-476d-97da-08da9bc0b877 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tBuYz21uiKYR5E130oZgbU0ZNVCN4vEWl0ki/c6IYnGAmlTOv1gKfy5y/n+VRwguca7ecAPlSuehg6AFjVvPmNVNAxQx64vECZO3ZMUYrwDhxMO99GlaHg3IKT2GsqL7/uTNn8bvGyhNvjs5L0+An5FM8uSeGq7cC4miTxGMUvSdB33w56vRloRpdL8KJFrYLR3f7ieWSBbQ1iuBC/IcdfJVCM77UHbbDBfdXzCMKRBn/TAu0NlH9a+T370kdKAXogqWqTdfaH3bpn3v+cjyOjHfiuyle9ogtAeL3wv1YcYZATKjL9/l64vBzwW1pjA6o7MWTzRc7yUDZDMYyaqjnwMRqwRR2B1L8COoBj8n/VlmovAkLFl1AeCksfD+WDWsEEA7yJfOH7Rwz7natd8YaDmCVP5g/3YKsyLqt2sFqsFWWwruelbRvC93NWKN6SnXudmPM1KD6SGZn1YUXHlgd9u7HrzrEeF3Og27GglvtM48LO/s45EsAZNW3TBNUaDFFCYKl+i7bLLPU6Dt//sD+7AZij5WDU28IEQJx+QwLi6QD7WWoQhp25H/jLmINISBTa7EImhCDuRZT/deCvsqhIlx0879Q3t86Oy5z0edFGynGZTrHtw5OYNXCRaNitMKK/uxgJVc1Yy6jUSqxhEO8G94Lnm82Xg6KANJGeKyfNuSxO8Sy81JSkdsZTqmTS54W7xSjvSF7TCfLo8ExPcWhxIHASOdSZLMyrMfPGtr2LJudohn01gvNJKL1kOi15mKCWlp5rrQ081lJIh7yTdHOVVZ8TinJ8/PZC70LRblOCy2w0piQP1l+CNbtIbqAiOr/SFcL2dgQMtzUeWUwtsOWA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(396003)(346002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(316002)(83380400001)(16576012)(36860700001)(4744005)(426003)(47076005)(44832011)(36756003)(70586007)(70206006)(82310400005)(86362001)(31696002)(2906002)(40460700003)(8676002)(81166007)(356005)(82740400003)(31686004)(478600001)(40480700001)(26005)(53546011)(186003)(2616005)(16526019)(336012)(5660300002)(110136005)(6666004)(41300700001)(8936002)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 11:02:05.5343 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa703ac7-a446-476d-97da-08da9bc0b877 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT015.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6670 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/19/22 12:39, Alexander Dahl wrote: > Instead of using DEBUG or LOG_DEBUG the driver still had its own > definition for debug output. > > Signed-off-by: Alexander Dahl > --- > drivers/fpga/altera.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/fpga/altera.c b/drivers/fpga/altera.c > index 10c0475d25..5a8fee10a5 100644 > --- a/drivers/fpga/altera.c > +++ b/drivers/fpga/altera.c > @@ -7,6 +7,8 @@ > * Rich Ireland, Enterasys Networks, rireland@enterasys.com. > */ > > +#define LOG_CATEGORY UCLASS_FS_FIRMWARE_LOADER I think all changes in this series are fine expect this LOG_CATEGORY. This is generic FS loader. I think fgpa uclass should be created. Thanks, Michal