From: "flichtenheld (Code Review)" Date: Mon, 26 Jan 2026 12:47:43 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: <6673cecd7da8faac23b9f8647fc870d5cb5f72b9-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="hhFT4yaD1yI="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: status: Avoid conversion warnings in status_read/status_printf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --hhFT4yaD1yI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://g= errit.openvpn.net/c/openvpn/+/1485?usp=3Demail ) Change subject: status: Avoid conversion warnings in status_read/status_pri= ntf ...................................................................... Patch Set 2: (1 comment) File src/openvpn/status.c: http://gerrit.openvpn.net/c/openvpn/+/1485/comment/9696cdac_b218c0bb?usp=3D= email : PS2, Line 241: if (write(so->fd, buf, (unsigned int)len) != =3D len) > this change confuses me. [=E2=80=A6] This is required for Windows (see https://learn.microsoft.com/en-us/cpp/c-r= untime-library/reference/write?view=3Dmsvc-170) In some of the places we have comments that this is for Windows (e.g. in te= st_ssl.c). Shall I add one here as well? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1485?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iff1343a2f8cc7e32b8f36b359a00248e4dc3e8c9 Gerrit-Change-Number: 1485 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Comment-Date: Mon, 26 Jan 2026 12:47:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 --hhFT4yaD1yI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: cron2, plaisthos.

View = Change

1 comment:

    =
  • File src/openvpn/status.c:

    • Patch Set #2, = Line 241: = if (write(so->fd, buf, (unsigned int)len) !=3D len)

      this change confuses me. [=E2=80=A6]

      This is required= for Windows (see https://learn.microsoft.com/en-us/cpp/c-runtime-library/r= eference/write?view=3Dmsvc-170)
      In some of the places we have comments t= hat this is for Windows (e.g. in test_ssl.c). Shall I add one here as well?=

To view, visit change 1485. To unsubscribe, or for h= elp writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iff1343a2f8cc7e32b8f36b359a0= 0248e4dc3e8c9
Gerrit-Change-Number: 1485
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Comment-Date: Mon, 26 Jan 2026 12:47:43= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
= --hhFT4yaD1yI=--