Received: from list by lists.gnu.org with archive (Exim 4.71) id 1USMIC-0006Ox-W6 for mharc-grub-devel@gnu.org; Wed, 17 Apr 2013 02:56:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USMIA-0006OD-CG for grub-devel@gnu.org; Wed, 17 Apr 2013 02:56:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USMI9-0006A9-9A for grub-devel@gnu.org; Wed, 17 Apr 2013 02:56:30 -0400 Received: from collab.rosalab.ru ([217.199.216.181]:56392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USMI9-00069l-26 for grub-devel@gnu.org; Wed, 17 Apr 2013 02:56:29 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by collab.rosalab.ru (Postfix) with ESMTP id 41E0229C283; Wed, 17 Apr 2013 10:56:27 +0400 (MSK) X-Virus-Scanned: amavisd-new at rosalab.ru Received: from collab.rosalab.ru ([127.0.0.1]) by localhost (collab.rosalab.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 95joz9tIkR-L; Wed, 17 Apr 2013 10:56:26 +0400 (MSK) Received: from icedphoenix.localnet (unknown [10.168.1.56]) by collab.rosalab.ru (Postfix) with ESMTPSA id CE61129C280; Wed, 17 Apr 2013 10:56:26 +0400 (MSK) From: Vladimir Testov To: grub-devel@gnu.org Subject: Re: [PATCH] multistring support in gui_label Date: Wed, 17 Apr 2013 10:56:26 +0400 Message-ID: <6699378.0O6bOZlDYk@icedphoenix> User-Agent: KMail/4.9.5 (Linux/3.5.0-26-generic; KDE/4.9.5; x86_64; ; ) In-Reply-To: <20130416211023.34876656@opensuse.site> References: <1720724.fd4NVO69U8@icedphoenix> <20130416211023.34876656@opensuse.site> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 217.199.216.181 Cc: Andrey Borzenkov X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2013 06:56:31 -0000 On Tuesday, April 16, 2013 09:10:23 PM Andrey Borzenkov wrote: > > +/* Differs from grub_font_draw_line only in multiline output */ > > You mean grub_font_draw_string? Is it possible to extend this function > instead of duplicating it? Hmmm... I'll think through it. Would it be wise? The sets of parameteres in these two functions are very different and the code is totally different... > All nested functions were removed from trunk. Please do not reintroduce > them. This should not even compile. My fault. Made the patch for grub-2.00, and forgot to remade it for upstream version. I've noticed that nested functions were removed. I will remake it soon. I've included the patch more for seeing the idea. It is not complete and (I think) shouldn't be included in the upstream until two problems, I've mentioned in previous letter, are not fixed. :) Thank for the reply. -- With best regards, _______________________________ Vladimir Testov, ROSA Laboratory. www.rosalab.ru