From: Tvrtko Ursulin Subject: Re: [PATCH 2/3] drm/i915/guc: general tidying up (loader) Date: Wed, 14 Sep 2016 16:12:49 +0100 Message-ID: <669d3d2b-6cb6-9256-5a87-0448ecc6e4f3@linux.intel.com> References: <1473711577-11454-1-git-send-email-david.s.gordon@intel.com> <1473711577-11454-3-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B7A56E780 for ; Wed, 14 Sep 2016 15:12:53 +0000 (UTC) In-Reply-To: <1473711577-11454-3-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzA5LzIwMTYgMjE6MTksIERhdmUgR29yZG9uIHdyb3RlOgo+IFJlbmFtaW5nIHRvIG1v cmUgY29uc2lzdGVudCBzY2hlbWUsIGRlbGV0ZSB1bnVzZWQgZGVmaW5pdGlvbnMKPgo+IFNpZ25l ZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4gLS0tCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19yZWcuaCAgICAgfCAgMyAtLS0KPiAgIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyB8IDI3ICsrKysrKysrKysrKysr KystLS0tLS0tLS0tLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxNCBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1 Y19yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3JlZy5oCj4gaW5kZXggY2Y1 YTY1Yi4uYTQ3ZTFlNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1 Y19yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3JlZy5oCj4gQEAg LTEwMyw5ICsxMDMsNiBAQAo+ICAgI2RlZmluZSBIT1NUMkdVQ19JTlRFUlJVUFQJCV9NTUlPKDB4 YzRjOCkKPiAgICNkZWZpbmUgICBIT1NUMkdVQ19UUklHR0VSCQkgICgxPDwwKQo+ICAgCj4gLSNk ZWZpbmUgRFJCTUlTQzEJCQkweDE5ODQKPiAtI2RlZmluZSAgIERPT1JCRUxMX0VOQUJMRQkJICAo MTw8MCkKPiAtCj4gICAjZGVmaW5lIEdFTjhfRFJCUkVHTCh4KQkJCV9NTUlPKDB4MTAwMCArICh4 KSAqIDgpCj4gICAjZGVmaW5lICAgR0VOOF9EUkJfVkFMSUQJCSAgKDE8PDApCj4gICAjZGVmaW5l IEdFTjhfRFJCUkVHVSh4KQkJCV9NTUlPKDB4MTAwMCArICh4KSAqIDggKyA0KQo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPiBpbmRleCAwMDIxNzQ4Li42ZmQzOWVmIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+IEBAIC05Nyw3ICs5 Nyw3IEBAIGNvbnN0IGNoYXIgKmludGVsX2d1Y19md19zdGF0dXNfcmVwcihlbnVtIGludGVsX2d1 Y19md19zdGF0dXMgc3RhdHVzKQo+ICAgCX0KPiAgIH07Cj4gICAKPiAtc3RhdGljIHZvaWQgZGly ZWN0X2ludGVycnVwdHNfdG9faG9zdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gK3N0YXRpYyB2b2lkIGd1Y19pbnRlcnJ1cHRzX3JlbGVhc2Uoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ICAgewo+ICAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2lu ZTsKPiAgIAlpbnQgaXJxczsKPiBAQCAtMTE0LDcgKzExNCw3IEBAIHN0YXRpYyB2b2lkIGRpcmVj dF9pbnRlcnJ1cHRzX3RvX2hvc3Qoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ ICAgCUk5MTVfV1JJVEUoR1VDX1dEX1ZFQ1NfSUVSLCAwKTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMg dm9pZCBkaXJlY3RfaW50ZXJydXB0c190b19ndWMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ICtzdGF0aWMgdm9pZCBndWNfaW50ZXJydXB0c19jYXB0dXJlKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIHsKPiAgIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmU7Cj4gICAJaW50IGlycXM7Cj4gQEAgLTE3OSw3ICsxNzksMTIgQEAgc3RhdGljIHUz MiBnZXRfY29yZV9mYW1pbHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAg CX0KPiAgIH0KPiAgIAo+IC1zdGF0aWMgdm9pZCBzZXRfZ3VjX2luaXRfcGFyYW1zKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArLyoKPiArICogSW5pdGlhbGlzZSB0aGUgR3VD IHBhcmFtZXRlciBibG9jayBiZWZvcmUgc3RhcnRpbmcgdGhlIGZpcm13YXJlCj4gKyAqIHRyYW5z ZmVyLiBUaGVzZSBwYXJhbWV0ZXJzIGFyZSByZWFkIGJ5IHRoZSBmaXJtd2FyZSBvbiBzdGFydHVw Cj4gKyAqIGFuZCBjYW5ub3QgYmUgY2hhbmdlZCB0aGVyZWFmdGVyLgo+ICsgKi8KPiArc3RhdGlj IHZvaWQgZ3VjX3BhcmFtc19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiAgIHsKPiAgIAlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmZGV2X3ByaXYtPmd1YzsKPiAgIAl1 MzIgcGFyYW1zW0dVQ19DVExfTUFYX0RXT1JEU107Cj4gQEAgLTM5MiwxMSArMzk3LDExIEBAIHN0 YXRpYyBpbnQgZ3VjX3Vjb2RlX3hmZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAgCQlJOTE1X1dSSVRFKEdFTjdfTUlTQ0NQQ1RMLCAoR0VOOF9ET1BfQ0xPQ0tfR0FURV9H VUNfRU5BQkxFIHwKPiAgIAkJCQkJICAgIEk5MTVfUkVBRChHRU43X01JU0NDUENUTCkpKTsKPiAg IAo+IC0JCS8qIGFsbG93cyBmb3IgNXVzIGJlZm9yZSBHVCBjYW4gZ28gdG8gUkM2ICovCj4gKwkJ LyogYWxsb3dzIGZvciA1dXMgKGluIDEwbnMgdW5pdHMpIGJlZm9yZSBHVCBjYW4gZ28gdG8gUkM2 ICovCj4gICAJCUk5MTVfV1JJVEUoR1VDX0FSQVRfQzZESVMsIDB4MUZGKTsKPiAgIAl9Cj4gICAK PiAtCXNldF9ndWNfaW5pdF9wYXJhbXMoZGV2X3ByaXYpOwo+ICsJZ3VjX3BhcmFtc19pbml0KGRl dl9wcml2KTsKPiAgIAo+ICAgCXJldCA9IGd1Y191Y29kZV94ZmVyX2RtYShkZXZfcHJpdiwgdm1h KTsKPiAgIAo+IEBAIC00MTEsNyArNDE2LDcgQEAgc3RhdGljIGludCBndWNfdWNvZGVfeGZlcihz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJcmV0dXJuIHJldDsKPiAgIH0K PiAgIAo+IC1zdGF0aWMgaW50IGk5MTVfcmVzZXRfZ3VjKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiArc3RhdGljIGludCBndWNfaHdfcmVzZXQoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ICAgewo+ICAgCWludCByZXQ7Cj4gICAJdTMyIGd1Y19zdGF0dXM7 Cj4gQEAgLTQ3OCw3ICs0ODMsNyBAQCBpbnQgaW50ZWxfZ3VjX3NldHVwKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4gICAJCWdvdG8gZmFpbDsKPiAgIAl9Cj4gICAKPiAtCWRpcmVjdF9pbnRlcnJ1 cHRzX3RvX2hvc3QoZGV2X3ByaXYpOwo+ICsJZ3VjX2ludGVycnVwdHNfcmVsZWFzZShkZXZfcHJp dik7Cj4gICAKPiAgIAlndWNfZnctPmd1Y19md19sb2FkX3N0YXR1cyA9IEdVQ19GSVJNV0FSRV9Q RU5ESU5HOwo+ICAgCj4gQEAgLTUwMSw3ICs1MDYsNyBAQCBpbnQgaW50ZWxfZ3VjX3NldHVwKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJCSAqIEFsd2F5cyByZXNldCB0aGUgR3VDIGp1c3Qg YmVmb3JlIChyZSlsb2FkaW5nLCBzbwo+ICAgCQkgKiB0aGF0IHRoZSBzdGF0ZSBhbmQgdGltaW5n IGFyZSBmYWlybHkgcHJlZGljdGFibGUKPiAgIAkJICovCj4gLQkJZXJyID0gaTkxNV9yZXNldF9n dWMoZGV2X3ByaXYpOwo+ICsJCWVyciA9IGd1Y19od19yZXNldChkZXZfcHJpdik7Cj4gICAJCWlm IChlcnIpCj4gICAJCQlnb3RvIGZhaWw7Cj4gICAKPiBAQCAtNTI2LDcgKzUzMSw3IEBAIGludCBp bnRlbF9ndWNfc2V0dXAoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgIAkJZXJyID0gaTkxNV9n dWNfc3VibWlzc2lvbl9lbmFibGUoZGV2X3ByaXYpOwo+ICAgCQlpZiAoZXJyKQo+ICAgCQkJZ290 byBmYWlsOwo+IC0JCWRpcmVjdF9pbnRlcnJ1cHRzX3RvX2d1YyhkZXZfcHJpdik7Cj4gKwkJZ3Vj X2ludGVycnVwdHNfY2FwdHVyZShkZXZfcHJpdik7Cj4gICAJfQo+ICAgCj4gICAJcmV0dXJuIDA7 Cj4gQEAgLTUzNSw3ICs1NDAsNyBAQCBpbnQgaW50ZWxfZ3VjX3NldHVwKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4gICAJaWYgKGd1Y19mdy0+Z3VjX2Z3X2xvYWRfc3RhdHVzID09IEdVQ19GSVJN V0FSRV9QRU5ESU5HKQo+ICAgCQlndWNfZnctPmd1Y19md19sb2FkX3N0YXR1cyA9IEdVQ19GSVJN V0FSRV9GQUlMOwo+ICAgCj4gLQlkaXJlY3RfaW50ZXJydXB0c190b19ob3N0KGRldl9wcml2KTsK PiArCWd1Y19pbnRlcnJ1cHRzX3JlbGVhc2UoZGV2X3ByaXYpOwo+ICAgCWk5MTVfZ3VjX3N1Ym1p c3Npb25fZGlzYWJsZShkZXZfcHJpdik7Cj4gICAJaTkxNV9ndWNfc3VibWlzc2lvbl9maW5pKGRl dl9wcml2KTsKPiAgIAo+IEBAIC03NjgsNyArNzczLDcgQEAgdm9pZCBpbnRlbF9ndWNfZmluaShz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgCXN0cnVjdCBpbnRlbF9ndWNfZncgKmd1Y19mdyA9 ICZkZXZfcHJpdi0+Z3VjLmd1Y19mdzsKPiAgIAo+ICAgCW11dGV4X2xvY2soJmRldi0+c3RydWN0 X211dGV4KTsKPiAtCWRpcmVjdF9pbnRlcnJ1cHRzX3RvX2hvc3QoZGV2X3ByaXYpOwo+ICsJZ3Vj X2ludGVycnVwdHNfcmVsZWFzZShkZXZfcHJpdik7Cj4gICAJaTkxNV9ndWNfc3VibWlzc2lvbl9k aXNhYmxlKGRldl9wcml2KTsKPiAgIAlpOTE1X2d1Y19zdWJtaXNzaW9uX2ZpbmkoZGV2X3ByaXYp Owo+ICAgCgpJIGxpa2VkIHRoZSBkaXJlY3QgaW50ZXJydXB0cyBuYW1pbmcgbW9yZSwgYnV0IGl0 IGlzIG5vdCB0aGF0IGNyaXRpY2FsLiAKVGhlIHJlc3QgaXMgT0suCgpSZXZpZXdlZC1ieTogVHZy dGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=