From: Michel Thierry Subject: Re: [PATCH 6/9] drm/i915/tdr: Add engine reset count to error state Date: Fri, 16 Dec 2016 13:19:13 -0800 Message-ID: <66d0b708-9203-132d-b030-0ee62e2138ae@intel.com> References: <20161216202010.7983-1-michel.thierry@intel.com> <20161216202010.7983-7-michel.thierry@intel.com> <20161216203753.GF29871@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1C976ED4A for ; Fri, 16 Dec 2016 21:19:14 +0000 (UTC) In-Reply-To: <20161216203753.GF29871@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE2LzEyLzE2IDEyOjM3LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gRnJpLCBEZWMgMTYs IDIwMTYgYXQgMTI6MjA6MDdQTSAtMDgwMCwgTWljaGVsIFRoaWVycnkgd3JvdGU6Cj4+IEZyb206 IEFydW4gU2lsdXZlcnkgPGFydW4uc2lsdXZlcnlAbGludXguaW50ZWwuY29tPgo+Pgo+PiBEcml2 ZXIgbWFpbnRhaW5zIGNvdW50IG9mIGhvdyBtYW55IHRpbWVzIGEgZ2l2ZW4gZW5naW5lIGlzIHJl c2V0LCB1c2VmdWwgdG8KPj4gY2FwdHVyZSB0aGlzIGluIGVycm9yIHN0YXRlIGFsc28uIEl0IGdp dmVzIGFuIGlkZWEgb2YgaG93IGVuZ2luZSBpcyBjb3BpbmcKPj4gdXAgd2l0aCB0aGUgd29ya2xv YWRzIGl0IGlzIGV4ZWN1dGluZyBiZWZvcmUgdGhpcyBlcnJvciBzdGF0ZS4KPgo+IEFsc28gaTkx NV9lbmdpbmVfaW5mbygpLgo+CkknbGwgYWRkIGl0IHRoZXJlIHRvby4KCj4+IENjOiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1p a2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBBcnVuIFNpbHV2 ZXJ5IDxhcnVuLnNpbHV2ZXJ5QGxpbnV4LmludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogTWlj aGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jICAgICAgIHwgMSArCj4+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oICAgICAgIHwgOSArKysrKysrKysKPj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ3B1X2Vycm9yLmMgfCAzICsrKwo+PiAgMyBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNl cnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+PiBpbmRleCBhMDM0NzkzYmMy NDYuLjFjNzA2YTA4MmQ2MCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4+IEBAIC0x ODc3LDYgKzE4NzcsNyBAQCBpbnQgaTkxNV9yZXNldF9lbmdpbmUoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lKQo+PiAgCWludGVsX2VuZ2luZV9yZXNldF9jYW5jZWwoZW5naW5lKTsKPj4g IAlpbnRlbF9leGVjbGlzdHNfcmVzdGFydF9zdWJtaXNzaW9uKGVuZ2luZSk7Cj4+Cj4+ICsJZGV2 X3ByaXYtPmdwdV9lcnJvci5lbmdpbmVfcmVzZXRfY291bnRbZW5naW5lLT5pZF0rKzsKPj4gIAlp bnRlbF91bmNvcmVfZm9yY2V3YWtlX3B1dChkZXZfcHJpdiwgRk9SQ0VXQUtFX0FMTCk7Cj4+ICAJ cmV0dXJuIDA7Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBpbmRleCBhOTdjYzhmNTBh ZGUuLjI1MTgzNzYyZWQ5NCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IEBAIC05 MzcsNiArOTM3LDcgQEAgc3RydWN0IGRybV9pOTE1X2Vycm9yX3N0YXRlIHsKPj4gIAkJZW51bSBp bnRlbF9lbmdpbmVfaGFuZ2NoZWNrX2FjdGlvbiBoYW5nY2hlY2tfYWN0aW9uOwo+PiAgCQlzdHJ1 Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bTsKPj4gIAkJaW50IG51bV9yZXF1ZXN0czsKPj4gKwkJ dTMyIHJlc2V0X2NvdW50Owo+Pgo+PiAgCQkvKiBwb3NpdGlvbiBvZiBhY3RpdmUgcmVxdWVzdCBp bnNpZGUgdGhlIHJpbmcgKi8KPj4gIAkJdTMyIHJxX2hlYWQsIHJxX3Bvc3QsIHJxX3RhaWw7Cj4+ IEBAIC0xNjI5LDYgKzE2MzAsOCBAQCBzdHJ1Y3QgaTkxNV9ncHVfZXJyb3Igewo+PiAgI2RlZmlu ZSBJOTE1X1JFU0VUX0lOX1BST0dSRVNTCTAKPj4gICNkZWZpbmUgSTkxNV9XRURHRUQJCShCSVRT X1BFUl9MT05HIC0gMSkKPj4KPj4gKwl1bnNpZ25lZCBsb25nIGVuZ2luZV9yZXNldF9jb3VudFtJ OTE1X05VTV9FTkdJTkVTXTsKPj4gKwo+PiAgCS8qKgo+PiAgCSAqIFdhaXRxdWV1ZSB0byBzaWdu YWwgd2hlbiBhIGhhbmcgaXMgZGV0ZWN0ZWQuIFVzZWQgdG8gZm9yIHdhaXRlcnMKPj4gIAkgKiB0 byByZWxlYXNlIHRoZSBzdHJ1Y3RfbXV0ZXggZm9yIHRoZSByZXNldCB0byBwcm9jZWRlLgo+PiBA QCAtMzM5Nyw2ICszNDAwLDEyIEBAIHN0YXRpYyBpbmxpbmUgdTMyIGk5MTVfcmVzZXRfY291bnQo c3RydWN0IGk5MTVfZ3B1X2Vycm9yICplcnJvcikKPj4gIAlyZXR1cm4gUkVBRF9PTkNFKGVycm9y LT5yZXNldF9jb3VudCk7Cj4+ICB9Cj4+Cj4+ICtzdGF0aWMgaW5saW5lIHUzMiBpOTE1X2VuZ2lu ZV9yZXNldF9jb3VudChzdHJ1Y3QgaTkxNV9ncHVfZXJyb3IgKmVycm9yLAo+Cj4gVGhhdCdzIGEg d2VpcmQgaG9kZ2Vwb2RnZS4gV2UgZmlyc3QgdGhpbmsgb2YgaW50ZWxfZW5naW5lIGFuZCBhcmUK PiBjb25mdXNlZCwgdGhlbiB3ZSBzcG90IHRoZSByZXNldC4gaTkxNV9yZXNldF9lbmdpbmVfY291 bnQ/Cj4KCkFncmVlZCBpOTE1X3Jlc2V0X2VuZ2luZV9jb3VudCBpcyBiZXR0ZXIgKHBsdXMgaXQn cyBjYWxsZWQgZnJvbSAKaTkxNV9yZXNldF9pbmZvKS4KCj4+ICsJCQkJCSAgc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lKQo+PiArewo+PiArCXJldHVybiBSRUFEX09OQ0UoZXJyb3ItPmVu Z2luZV9yZXNldF9jb3VudFtlbmdpbmUtPmlkXSk7Cj4+ICt9Cj4+ICsKClRoZW4gdGhlIHNhbWUg cmVuYW1lIGhlcmUsIHJlc2V0X2VuZ2luZV9jb3VudFtdLgoKVGhhbmtzCj4+ICB2b2lkIGk5MTVf Z2VtX3Jlc2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4+ICB2b2lkIGk5 MTVfZ2VtX3NldF93ZWRnZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPj4g IHZvaWQgaTkxNV9nZW1fcmVzZXRfZW5naW5lKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2lu ZSk7Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+PiBpbmRleCBlMTYwMzdk MWIwYmEuLmYxNjhhZDg3MzUyMSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9ncHVfZXJyb3IuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9l cnJvci5jCj4+IEBAIC00NTMsNiArNDUzLDcgQEAgc3RhdGljIHZvaWQgZXJyb3JfcHJpbnRfZW5n aW5lKHN0cnVjdCBkcm1faTkxNV9lcnJvcl9zdGF0ZV9idWYgKm0sCj4+ICAJZXJyX3ByaW50Ziht LCAiICBoYW5nY2hlY2sgYWN0aW9uIHRpbWVzdGFtcDogJWx1LCAldSBtcyBhZ29cbiIsCj4+ICAJ CSAgIGVlLT5oYW5nY2hlY2tfdGltZXN0YW1wLAo+PiAgCQkgICBqaWZmaWVzX3RvX21zZWNzKGpp ZmZpZXMgLSBlZS0+aGFuZ2NoZWNrX3RpbWVzdGFtcCkpOwo+PiArCWVycl9wcmludGYobSwgIiAg ZW5naW5lIHJlc2V0IGNvdW50OiAldVxuIiwgZWUtPnJlc2V0X2NvdW50KTsKPj4KPj4gIAllcnJv cl9wcmludF9yZXF1ZXN0KG0sICIgIEVMU1BbMF06ICIsICZlZS0+ZXhlY2xpc3RbMF0pOwo+PiAg CWVycm9yX3ByaW50X3JlcXVlc3QobSwgIiAgRUxTUFsxXTogIiwgJmVlLT5leGVjbGlzdFsxXSk7 Cj4+IEBAIC0xMTcwLDYgKzExNzEsOCBAQCBzdGF0aWMgdm9pZCBlcnJvcl9yZWNvcmRfZW5naW5l X3JlZ2lzdGVycyhzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfc3RhdGUgKmVycm9yLAo+PiAgCWVlLT5o YW5nY2hlY2tfdGltZXN0YW1wID0gZW5naW5lLT5oYW5nY2hlY2suYWN0aW9uX3RpbWVzdGFtcDsK Pj4gIAllZS0+aGFuZ2NoZWNrX2FjdGlvbiA9IGVuZ2luZS0+aGFuZ2NoZWNrLmFjdGlvbjsKPj4g IAllZS0+aGFuZ2NoZWNrX3N0YWxsZWQgPSBlbmdpbmUtPmhhbmdjaGVjay5zdGFsbGVkOwo+PiAr CWVlLT5yZXNldF9jb3VudCA9IGk5MTVfZW5naW5lX3Jlc2V0X2NvdW50KCZkZXZfcHJpdi0+Z3B1 X2Vycm9yLAo+PiArCQkJCQkJICBlbmdpbmUpOwo+Pgo+PiAgCWlmIChVU0VTX1BQR1RUKGRldl9w cml2KSkgewo+PiAgCQlpbnQgaTsKPj4gLS0KPj4gMi4xMS4wCj4+Cj4KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==