From: Maarten Lankhorst Subject: Re: [PATCH v3 05/11] drm/i915/gen9+: Do not initialise active_crtcs for !modeset Date: Thu, 10 Nov 2016 15:32:22 +0100 Message-ID: <66d42917-0e15-e793-f134-035daf12773f@linux.intel.com> References: <1478609742-13603-1-git-send-email-maarten.lankhorst@linux.intel.com> <1478609742-13603-6-git-send-email-maarten.lankhorst@linux.intel.com> <20161108141156.GM4617@intel.com> <20161110105350.GC31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D7B36E022 for ; Thu, 10 Nov 2016 14:32:24 +0000 (UTC) In-Reply-To: <20161110105350.GC31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTAtMTEtMTYgb20gMTE6NTMgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gV2VkLCBO b3YgMDksIDIwMTYgYXQgMDE6NDU6MjBQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IE9wIDA4LTExLTE2IG9tIDE1OjExIHNjaHJlZWYgVmlsbGUgU3lyasOkbMOkOgo+Pj4gT24g VHVlLCBOb3YgMDgsIDIwMTYgYXQgMDE6NTU6MzZQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qg d3JvdGU6Cj4+Pj4gVGhpcyBpcyBhIGhhY2sgYW5kIG5vdCBuZWVkZWQuIFVzZSB0aGUgcmlnaHQg bWFzayBieSBjaGVja2luZwo+Pj4+IGludGVsX3N0YXRlLT5tb2Rlc2V0LiBUaGlzIHdvcmtzIGZv ciB3YXRlcm1hcmsgc2FuaXRpemF0aW9uIHRvby4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IE1h YXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+Pj4g LS0tCj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAzOCArKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5z ZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bt LmMKPj4+PiBpbmRleCAwMmY1MmI1MmEwM2QuLmQzOGE0NmVmY2ZlZCAxMDA2NDQKPj4+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcG0uYwo+Pj4+IEBAIC0zMDg5LDI2ICszMDg5LDIyIEBAIHNrbF9kZGJf Z2V0X3BpcGVfYWxsb2NhdGlvbl9saW1pdHMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4+PiAg CXN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKmludGVsX3N0YXRlID0gdG9faW50ZWxfYXRvbWlj X3N0YXRlKHN0YXRlKTsKPj4+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IHRvX2k5MTUoZGV2KTsKPj4+PiAgCXN0cnVjdCBkcm1fY3J0YyAqZm9yX2NydGMgPSBjc3RhdGUt PmJhc2UuY3J0YzsKPj4+PiAtCXVuc2lnbmVkIGludCBwaXBlX3NpemUsIGRkYl9zaXplOwo+Pj4+ ICsJdW5zaWduZWQgaW50IHBpcGVfc2l6ZSwgZGRiX3NpemUsIGFjdGl2ZV9jcnRjczsKPj4+PiAg CWludCBudGhfYWN0aXZlX3BpcGU7Cj4+Pj4gIAo+Pj4+ICsJaWYgKGludGVsX3N0YXRlLT5tb2Rl c2V0KQo+Pj4+ICsJCWFjdGl2ZV9jcnRjcyA9IGludGVsX3N0YXRlLT5hY3RpdmVfY3J0Y3M7Cj4+ Pj4gKwllbHNlCj4+Pj4gKwkJYWN0aXZlX2NydGNzID0gZGV2X3ByaXYtPmFjdGl2ZV9jcnRjczsK Pj4+IFdoYXQncyB0aGUgc3Rvcnkgd2l0aCB0aGUgbG9ja2luZyBoZXJlPwo+PiBpZiAhbW9kZXNl dCwgMyB0aGluZ3MgY2FuIGhhcHBlbjoKPj4gMS4gZmFzdHNldCwgY29ubmVjdGlvbl9tdXRleCBo ZWxkLCBkZXZfcHJpdi0+YWN0aXZlX2NydGNzIGNhbm5vdCBjaGFuZ2UuCj4+IDIuIGNydGMgZGlz YWJsZWQsIGFjdGl2ZV9jcnRjcyBpcyBwb3RlbnRpYWxseSBnYXJiYWdlLCBidXQgaGFybWxlc3Mg c2luY2Ugd2UgZG9uJ3Qgd3JpdGUgZGlzYWJsZWQgd20ncyB3aGVuIHRoZSBjcnRjIGlzIGFscmVh ZHkgZGlzYWJsZWQuCj4+IChzYW1lIGFzIHdoYXQgaGFwcGVucyBjdXJyZW50bHkpCj4gQnV0IHdl IHN0aWxsIGNvbXB1dGUgdGhlbT8gQ2FuIHRoZSBjb21wdXRhdGlvbiBmYWlsIG9uIGFjY291bnQg b2YKPiB0aGF0PyBJIGd1ZXNzIGl0IHNob3VsZG4ndCBiZWNhdXNlIHdoZW4gdGhpbmdzIGFyZSBk aXNhYmxlZCBhbGwgd21zCj4gc2hvdWxkIGNvbWUgb3V0IGFzIDA/CkluZGVlZCwgdGhleSBjb21l IG91dCBhcyB6ZXJvIHNvIGl0IGNhbid0IGZhaWwsIHJlZ2FyZGxlc3Mgb2YgdGhlIHZhbHVlIG9m IGFjdGl2ZV9jcnRjcy4gOikKPj4gMy4gY3J0YyBlbmFibGVkLCBkZXZfcHJpdi0+YWN0aXZlX2Ny dGNzIGlzIHZhbGlkIGJlY2F1c2UgZGRiIHJlYWxsb2NhdGlvbiByZXF1aXJlcyBsb2NraW5nIGFs bCBhY3RpdmUgY3J0YydzIGZvciByZWFsbG9jYXRpb24sCj4+IHdoaWNoIHJlcXVpcmVzIHRha2lu ZyB0aGlzIGxvY2sgZm9yIHRoaXMgY3J0Yy4KPiBDYXNlIDMgYXQgbGVhc3QgbG9va3MgYSBsaXR0 bGUgc3VzcGVjdCB0byBtZS4gV2hhdCB0aGUgY29kZSBkb2VzIGlzOgo+Cj4gZm9yX2VhY2hfaW50 ZWxfY3J0Y19pbl9tYXNrKHJlYWxsb2NfcGlwZXMpIHsKPiAJaW50ZWxfYXRvbWljX2dldF9jcnRj X3N0YXRlKCk7Cj4gCXNrbF9hbGxvY2F0ZV9waXBlX2RkYigpIHsKPiAJCXNrbF9kZGJfZ2V0X3Bp cGVfYWxsb2NhdGlvbl9saW1pdHMoKTsKPiAJfQo+IAkuLi4KPiB9Cj4KPiBTaW5jZSBpdCBzdGFy dHMgdG8gY29tcHV0ZSB0aGlzIHN0dWZmIGFscmVhZHkgYmVmb3JlIGl0J3MgbmVjZXNzYXJpbHkK PiBsb2NrZWQgYWxsIHRoZSBjcnRjcywgSSdtIGhhdmluZyBhIGhhcmQgdGltZSBjb252aW5jaW5n IG15c2VsZiB0aGF0Cj4gdGhlIHN0YXRlIHdpbGwgYWx3YXlzIGJlIHVwIHRvIGRhdGUuIEkgZ3Vl c3MgaXQgbWlnaHQgc2luY2UKPiByZWFsbG9jX3BpcGVzIHNob3VsZCBvbmx5IGhhdmUgdGhlIG9u ZSBwaXBlIHVubGVzcyBhY3RpdmVfY3J0Y3MgaXMgZ29pbmcKPiB0byBjaGFuZ2UsIGJ1dCBJIGRv bid0IHRoaW5rIGl0J3Mgb2J2aW91cyBhdCBhbGwgd2hlbiBsb29raW5nIGF0IHRoZQo+IGNvZGUu IE1pZ2h0IHdhbnQgdG8gY2hhbmdlIHRoZSB3YXkgdGhpcyBpcyBkb25lIGZvciBjbGFyaXR5IGlm IG5vdGhpbmcKPiBlbHNlLgo+Cj4gSSB0aGluayB3ZSBuZWVkIHRvIHN0YXJ0IGRvY3VtZW50aW5n IHRoZSBsb2NraW5nIHJ1bGVzIGZvciB0aGlzIGtpbmQKPiBvZiBkZXZpY2Ugd2lkZSBzdGF0ZSBi ZXR0ZXIsIGFuZCBtYXliZSB0cnkgdG8gc3ByaW5rbGUgbW9yZSBsb2NraW5nCj4gYXNzZXJ0cyBh cm91bmQuClBhcmFsbGVsIGVuYWJsZXMgYXJlIGhhbmRsZWQgYnkgY29ubmVjdGlvbl9tdXRleCwg c28gb25seSAxIGNhbiBoYXBwZW4gYXQgdGhlIHNhbWUgdGltZS4KSXQgY2FuIHJhY2Ugd2l0aCBh IHBhcmFsbGVsIGNydGMgdXBkYXRlIHRvIGFub3RoZXIgY3J0YywgYnV0IGVpdGhlciB3YXkgdGhl IGRkYiB2YWx1ZSBpcyB0aGUgc2FtZSwKc28gaXQncyBoYXJtbGVzcyBhcyBsb25nIGFzIGl0IGdy YWJzIHRoZSBjcnRjX3N0YXRlIGF0IHNvbWUgcG9pbnQgYmVmb3JlIGNvbW1pdHRpbmcuCgp+TWFh cnRlbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK