Received: from eggs.gnu.org ([2001:4830:134:3::10]:59399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq1qE-0006m0-JP for qemu-devel@nongnu.org; Fri, 30 Sep 2016 13:43:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bq1qC-00026D-JH for qemu-devel@nongnu.org; Fri, 30 Sep 2016 13:43:21 -0400 References: <1475246744-29302-1-git-send-email-berrange@redhat.com> <1475246744-29302-7-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <66fa4161-108a-660a-b8fa-5afdd17b030d@redhat.com> Date: Fri, 30 Sep 2016 12:43:12 -0500 MIME-Version: 1.0 In-Reply-To: <1475246744-29302-7-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DBPeE1d5PTnpbl55Bt6KoxJr9dePwQugH" Subject: Re: [Qemu-devel] [PATCH v14 06/21] qapi: don't pass two copies of TestInputVisitorData to tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Markus Armbruster , Max Reitz , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DBPeE1d5PTnpbl55Bt6KoxJr9dePwQugH From: Eric Blake To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Markus Armbruster , Max Reitz , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <66fa4161-108a-660a-b8fa-5afdd17b030d@redhat.com> Subject: Re: [PATCH v14 06/21] qapi: don't pass two copies of TestInputVisitorData to tests References: <1475246744-29302-1-git-send-email-berrange@redhat.com> <1475246744-29302-7-git-send-email-berrange@redhat.com> In-Reply-To: <1475246744-29302-7-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/30/2016 09:45 AM, Daniel P. Berrange wrote: > The input_visitor_test_add() method was accepting an instance > of 'TestInputVisitorData' and passing it as the 'user_data' > parameter to test functions. The main 'TestInputVisitorData' > instance that was actually used, was meanwhile being allocated > automatically by the test framework fixture setup. >=20 > The 'user_data' parameter is going to be needed for tests > added in later patches, so getting rid of the current mistaken > usage now allows this. >=20 > Signed-off-by: Daniel P. Berrange > --- > tests/test-qobject-input-visitor.c | 76 ++++++++++++++++--------------= -------- > 1 file changed, 32 insertions(+), 44 deletions(-) Reviewed-by: Eric Blake The improved commit message makes the difference :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DBPeE1d5PTnpbl55Bt6KoxJr9dePwQugH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX7qQwAAoJEKeha0olJ0NqtmoH/jFMe6bXY4Bl/tOqfNssDgSo n4uZhZ3gnvj7/86alvtwV6iV3NIcitKVRzJfipYdRoLIOkU7p6PEf2g4asbdAuGJ MMtlGd8nmukIzTfc8/BDmTdqefZCkSu148FWRW2YMgWQsD02cbB3ROdKTQ8vcnvY 3fJSbpWOoiAqoAB8sqj7E/Y8Tdkc0Syp6p3ZYwDwUPl/5YdyFpi1qXb1whqxYVhz QduxcDLKUUqKOmK4VIkeHJ3Ii41aTKAP9oplgwHPyFB8MTc3p0s9y/hUcfWijl/1 QkaHxDp4zD/3/6EGQYcsn1YgwXqS2ExdjM6fiwApKaefgFwgDFwS1H4Pg1PL1eo= =h6K1 -----END PGP SIGNATURE----- --DBPeE1d5PTnpbl55Bt6KoxJr9dePwQugH--